Delete contract hash module #871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module has been deprecated in commit 1ffdce9 in August 2020, it is safe to delete it now. Fixes: rust-bitcoin#322
|
cc @sanket1729 can/should we reimplement this module's functionality in rust-miniscript? It looks like we use the Regardless, concept ACK removing it here. |
apoelstra
approved these changes
Mar 10, 2022
dr-orlovsky
approved these changes
Mar 12, 2022
There was a problem hiding this comment.
ACK 7f33fe6
I'm ok on merging for RC fix, but still put a milestone for 0.29 if we forget to do it now
Yes, elements-miniscript needs this functionality. Will re-implement this over there |
sanket1729
added a commit
to sanket1729/rust-bitcoin
that referenced
this pull request
Jul 18, 2022
apoelstra
added a commit
that referenced
this pull request
Jul 18, 2022
0a0934a Remove the Pay-to-Contract reference from README. (sanket1729) Pull request description: Removed in #871 ACKs for top commit: apoelstra: ACK 0a0934a tcharding: ACK 0a0934a Tree-SHA512: eed4e2f381effba8976668574bb2a19e524cf8d9fff305e1cde2bd09f52ae0100b8d06dc289bb0953433757c15301e89b88f71fa1255e0f18e695bb6e4f4af14
ChallengeDev210
pushed a commit
to ChallengeDev210/rust-bitcoin
that referenced
this pull request
Aug 1, 2022
ChallengeDev210
pushed a commit
to ChallengeDev210/rust-bitcoin
that referenced
this pull request
Aug 1, 2022
†92C3 ¦rence from README. 0a0934a Remove the Pay-to-Contract reference from README. (sanket1729) Pull request description: Removed in rust-bitcoin/rust-bitcoin#871 ACKs for top commit: apoelstra: ACK 0a0934a tcharding: ACK 0a0934a Tree-SHA512: eed4e2f381effba8976668574bb2a19e524cf8d9fff305e1cde2bd09f52ae0100b8d06dc289bb0953433757c15301e89b88f71fa1255e0f18e695bb6e4f4af14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module has been deprecated in commit 1ffdce9 in August 2020, it is safe to delete it now.
Fixes: #322