8000 Fix deprecated since version by tcharding · Pull Request #918 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix deprecated since version #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2022
Merged

Fix deprecated since version #918

merged 1 commit into from
Mar 29, 2022

Conversation

tcharding
Copy link
Member

We deprecated the bip143::SigHashCache in

commit 53d0e176d3c79c666cf75952f6f610fa37a105f5
Author: <elided>
Date:   Fri Jul 16 10:44:18 2021 +0200

    Deprecate bip143::SigHashCache in favor of sighash::SigHashCache

    ...

This means these changes are unreleased so the deprecated since version
should be the upcoming 0.28 release.

@tcharding
Fix 8000 deprecated since version
8d602b8 
We deprecated the `bip143::SigHashCache` in

```
commit 53d0e17
Author: <elided>
Date:   Fri Jul 16 10:44:18 2021 +0200

    Deprecate bip143::SigHashCache in favor of sighash::SigHashCache

    ...
```

This means these changes are unreleased so the deprecated since version
should be the upcoming 0.28 release.
sanket1729
sanket1729 approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member
@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! ACK 8d602b8

@sanket1729 sanket1729 added the one ack PRs that have one ACK, so one more can progress them label Mar 29, 2022
dr-orlovsky
dr-orlovsky approved these changes Mar 29, 2022
View reviewed changes
Copy link
Collaborator
@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8d602b8

@dr-orlovsky dr-orlovsky merged commit 0a2d45d into rust-bitcoin:master Mar 29, 2022
@tcharding tcharding deleted the fix-deprecated branch March 30, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr-orlovsky dr-orlovsky dr-orlovsky approved these changes

@sanket1729 sanket1729 sanket1729 approved these changes

Assignees
No one assigned
Labels
one ack PRs that have one ACK, so one more can progress them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcharding @dr-orlovsky @sanket1729
0