Added module with consensus parameters #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasblummer
suggested changes
Jun 12, 2018
src/network/consensus_params.rs
Outdated
| pub bip34_height: u32, | ||
| /// Block height at which BIP65 becomes active. | ||
| pub bip65_height: u32, | ||
| /// Block height at which BIP65 becomes active. |
src/network/consensus_params.rs
Outdated
| } | ||
| } | ||
|
|
||
| /// Calculates amount of blocks between difficulty adjustments. |
There was a problem hiding this comment.
*the number of blocks
src/network/constants.rs
Outdated
| @@ -52,6 +53,13 @@ pub fn magic(network: Network) -> u32 { | |||
| } | |||
| } | |||
|
|
|||
| /// Lowest possible difficulty for Mainnet. | |||
There was a problem hiding this comment.
these constants should be in consensus_params and not be global. if they were global then what is the use of collecting them into parameter objects?
4a841fa to
e0b10ae
Compare
|
Done. |
tamasblummer
approved these changes
Jun 13, 2018
|
@apoelstra I am not sure if soft fork rule miner activation thresholds will ever be used again. Maybe better add simple heights for those BIPs activated that way (e.g. Segwit) |
|
@tamasblummer I think it's fine as-is since we're copying constants from Core that people migth expect to be there. |
|
@apoelstra this is pending on #99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new module contains a set of constants associated with different chains.
It may be very useful for client-side validation/verification of blocks.