Use listener.accept()
#1119
Merged
Use listener.accept()
#1119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During test network simulation we only accept a single connection, we can simplify the code by using `accept`. Done as a follow up to review suggestion: rust-bitcoin#1042 (comment)
dpc
approved these changes
Jul 22, 2022
Closed
apoelstra
approved these changes
Jul 22, 2022
ChallengeDev210
pushed a commit
to ChallengeDev210/rust-bitcoin
that referenced
this pull request
Aug 1, 2022
b1faf63 Use listener.accept() (Tobin C. Harding) Pull request description: During test network simulation we only accept a single connection, we can simplify the code by using `accept`. Done as a follow up to review suggestion: rust-bitcoin/rust-bitcoin#1042 (comment) ACKs for top commit: Kixunil: ACK b1faf63 apoelstra: ACK b1faf63 Tree-SHA512: b2ead15d3108db3e01d9faab5e3521403dad6a0f4c3cf505f88fefd020110c520a89b9406484c10b04c9a34073c8abc465941577b17b5a193b54502c23b14c61
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During test network simulation we only accept a single connection, we can simplify the code by using
accept.Done as a follow up to review suggestion:
#1042 (comment)