Add docs re Rust 1.51.1 #1122
Merged
Add docs re Rust 1.51.1 #1122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpc
previously approved these changes
Jul 22, 2022
10000
Kixunil
reviewed
Jul 22, 2022
src/util/amount.rs
Outdated
| @@ -336,7 +336,7 @@ fn dec_width(mut num: u64) -> usize { | |||
| width | |||
| } | |||
|
|
|||
| // NIH due to MSRV, impl copied from `core` | |||
| // NIH due to MSRV, impl copied from `core::unsigned_abs` (Rust 1.51.1). | |||
There was a problem hiding this comment.
If you want to avoid confusion of people who don't know the method at all prefer the actual full path :) core::i8::unsigned_abs
There was a problem hiding this comment.
If you're going to edit the line anyway, I'd also like it to say "introduced in Rust 1.51.1". As written it kinda looks like we copied the code from Rust 1.51.1, which might be good to know but doesn't seem particularly useful :)
There was a problem hiding this comment.
Yep and yep, sure thing. Thanks
05a9522 to
7f498ee
Compare
Kixunil
approved these changes
Jul 24, 2022
apoelstra
approved these changes
Jul 24, 2022
ChallengeDev210
pushed a commit
to ChallengeDev210/rust-bitcoin
that referenced
this pull request
Aug 1, 2022
7f498ee Add docs re Rust 1.51.1 (Tobin C. Harding) Pull request description: After auditing the code base for 'msrv' the only remaining mention (excl. md files) is on `unsigned_abs`. Add docs to save the next guy looking up what version of Rust introduced `unsigned_abs`. (I also added an item to the [msrv tracking issue](rust-bitcoin/rust-bitcoin#1060).) ACKs for top commit: Kixunil: ACK 7f498ee apoelstra: ACK 7f498ee Tree-SHA512: 9b4bdca09d3f7ac1c0584f4eb5207983a064cfe81ed26952d00396b2e0019ef40eee192b7f09d36c68b8c4e1f8de9cac2d1f3ee0946626bae089b46fe38704ab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After auditing the code base for 'msrv' the only remaining mention (excl. md files) is on
unsigned_abs.Add docs to save the next guy looking up what version of Rust introduced
unsigned_abs. (I also added an item to the msrv tracking issue.)