8000 Add a comment to delineate test_macros re-export by tcharding · Pull Request #1255 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add a comment to delineate test_macros re-export #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

tcharding
Copy link
Member

The formatter removes an empty line that is clearly better to have. Add a rustdoc comment to at least delineate the line a bit.

@tcharding tcharding added trivial Obvious, easy and quick to review (few lines or doc-only...) no release notes mention labels Sep 9, 2022
@tcharding tcharding mentioned this pull request Sep 9, 2022
@Kixunil
Copy link
Collaborator
Kixunil commented Sep 9, 2022

Perhaps make it non-doc comment instead?

The formatter removes an empty line that is clearly better to have. Add
a rustdoc comment to at least delineate the line a bit.
@tcharding
Copy link
Member Author

Done, no other changes.

Copy link
Collaborator
@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a9d1e08

@Kixunil Kixunil added the one ack PRs that have one ACK, so one more can progress them label Sep 12, 2022
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a9d1e08

@apoelstra apoelstra merged commit 0f5a585 into rust-bitcoin:master Sep 12, 2022
@tcharding tcharding deleted the 09-09-add-comment branch September 12, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no release notes mention one ack PRs that have one ACK, so one more can progress them trivial Obvious, easy and quick to review (few lines or doc-only...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0