Remove unused consensus encoding error variants #1252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error variants `UnexpectedNetworkMagic` and `UnknownNetworkMagic` were not only duplicated but also completely unused. This removes both of them.
tcharding
approved these changes
Sep 8, 2022
apoelstra
approved these changes
Sep 9, 2022
apoelstra
added a commit
that referenced
this pull request
Dec 5, 2022
1a2cf26 Implement consensus encoding adapter for serde (Martin Habovstiak) a6ecc58 Add `put_bytes_min` and `space_remaining` methods (Martin Habovstiak) Pull request description: In some protocols it is preferred to serialize consensus-encodable types using consensus encoding. E.g. serialize `Transaction` as hex-encoded string in Json in Bitcoin Core RPC protocol. This change provides adapter to make this easier. The adapter allows providing custom byte-to-string encoder for more exotic cases and provides a hex implementation which should be useful in majority of the cases. Should help with #765 Based on #1252 Required by #1234 ACKs for top commit: tcharding: ACK 1a2cf26 apoelstra: ACK 1a2cf26 Tree-SHA512: 96e10cf6ea0e7dfecfb58ee97453e0e7c8a2cfbb8af1e73a23c3afb67b985b394976361ac237528991fbb7344cc9f24644869199008245a91838309aff34bb97
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error variants
UnexpectedNetworkMagicandUnknownNetworkMagicwere not only duplicated but also completely unused. This removes both of them.