Rename TxOutRef to OutPoint and use it in TxIn.
#139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b17d2d2 to
92a2644
Compare
|
cc @TheBlueMatt concept ack? This is the correct term right? |
apoelstra
reviewed
Aug 20, 2018
src/blockdata/transaction.rs
Outdated
| /// The referenced transaction's txid | ||
| pub txid: Sha256dHash, | ||
| /// The index of the referenced output in its transaction's vout | ||
| pub index: usize | ||
| pub index: u32, |
There was a problem hiding this comment.
Can you call this vout instead of index?
TheBlueMatt
approved these changes
Aug 20, 2018
src/blockdata/transaction.rs
Outdated
| /// | ||
| /// let block = genesis_block(Network::Bitcoin); | ||
| /// let tx = &block.txdata[0]; | ||
| /// |
src/blockdata/transaction.rs
Outdated
| /// ```rust | ||
| /// use bitcoin::blockdata::constants::genesis_block; | ||
| /// use bitcoin::network::constants::Network; | ||
| /// |
92a2644 to
2798609
Compare
|
Done |
apoelstra
reviewed
Aug 20, 2018
| txid: Default::default(), | ||
| vout: u32::max_value(), | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you make this function be the Default::default implementation of the Outpoint type? You can also have the explicit method.
|
ACK aside from |
Previously this structure was unused, it's now being used by the `TxIn` structure to simplify the code a little bit and avoid confusions. Also the rust-lightning source code has an `OutPoint` similar to this one but with the `vout` index as an `u16` to avoid unsafe conversions. I've added to new methods to `OutPoint`: - `null`: Creates a new "null" `OutPoint`. - `is_null`: Checks if the given `OutPoint` is null. Signed-off-by: Jean Pierre Dudey <jeandudey@hotmail.com>
2798609 to
32631e4
Compare
|
Done |
apoelstra
approved these changes
Aug 20, 2018
|
Normally I'd consider this too much API churn for the benefit, but I really hated the old |
casey
pushed a commit
to casey/rust-bitcoin
that referenced
this pull request
Nov 28, 2023
Add v0.20.0 and v0.20.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.