8000 ci: Remove incorrect code comment and cargo clean by tcharding · Pull Request #1569 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

ci: Remove incorrect code comment and cargo clean #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2023
Merged

ci: Remove incorrect code comment and cargo clean #1569

merged 1 commit into from
Feb 18, 2023

Conversation

tcharding
Copy link
Member

Recently while trying to fix CI I (Tobin) added a call to cargo clean and a code comment justifying it. This was merged because while not incorrect it is redundant since calling cargo with different RUSTFLAGS triggers a rebuild.

@tcharding
ci: Remove incorrect code comment and cargo clean
70bff0d 
Recently while trying to fix CI I (Tobin) added a call to `cargo clean`
and a code comment justifying it. This was merged because while not
incorrect it is redundant since calling `cargo` with different
`RUSTFLAGS` triggers a rebuild.
@tcharding
Copy link
Member Author
tcharding commented Jan 20, 2023 •
edited
Loading

If this passes CI it means the recent ASAN issue was wholly caused by running cargo from the crate root - I'm still not sure exactly what was breaking though.

EDIT: It is rust-secp256k1 that is triggering the memory sanitizer error.

@apoelstra
Copy link
Member

@tcharding my suspicion is that the ASAN issue is a nondeterministic bug and your "fix" just rearranged code in a way that stopped triggering it.

As for the rust-secp MSAN thing it looks like Elichai has dug into it and provided details on rust-bitcoin/rust-secp256k1#573. Curious whether these issues are actually related or just a coincidence.

apoelstra
apoelstra approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 70bff0d

@tcharding
Copy link
Member Author

Oh I think it was the MSAN thing all along and we were running cargo commands from the crate root which would include bitcoin which depends on secp. Only running the sanitizer from hashes which doesn't depend on secp solved the problem by hiding it :)

@apoelstra
Copy link
Member

Oh, lol! I think you're right.

@tcharding
Copy link
Member Author

Friendly bump please.

Kixunil
Kixunil approved these changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator
@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 70bff0d

@apoelstra apoelstra merged commit 794ddde into rust-bitcoin:master Feb 18, 2023
@tcharding tcharding deleted the 01-21-revisit-ci branch February 22, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kixunil Kixunil Kixunil approved these changes

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tcharding @apoelstra @Kixunil
0