Remove hashes::hex::HexWriter
#1572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `HexWriter` is not used any more since we added the new hex code in internals for fast hex encoding. While we are removing the benches for `HexWriter` also remove the last remaining bench for writing using `Display` because this is not the correct place for that code - its trivial to re add later in the correct module.
This was referenced Jan 22, 2023
Closed
Kixunil
approved these changes
Jan 22, 2023
|
For the hex crate we should have this available but in improved form: generic over |
|
Am I understanding you correctly, you are happy to remove this now but I should raise an issue to re-implement it in the hex crate generic over |
|
Exactly. |
|
Done, thanks. |
apoelstra
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
HexWriteris not used any more since we added the new hex code in internals for fast hex encoding.While we are removing the benches for
HexWriteralso remove the last remaining bench for writing usingDisplaybecause this is not the correct place for that code - its trivial to re add later in the correct module.