8000 Add predict_weight test for witness address types by yancyribbens · Pull Request #1797 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add predict_weight test for witness address types #1797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2023
Merged

Add predict_weight test for witness address types #1797

merged 1 commit into from
Apr 14, 2023

Conversation

yancyribbens
Copy link
Contributor

Add a predict_weight test for address types with witness data

tcharding
tcharding previously approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member
@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ee15e1dc5f226c328788b07950735e0067868f1e

@tcharding
Copy link
Member

Thanks man!

@apoelstra
Copy link
Member

Needs some tweak for 1.48.

Kixunil
Kixunil reviewed Apr 14, 2023
View reviewed changes
Copy link
Collaborator
@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it'd be more valuable to use from_slice in the consts so that the numbers are obviously correct.

@Kixunil
Copy link
Collaborator
Kixunil commented Apr 14, 2023

Also we have a stale comment about Rust 1.46

@yancyribbens yancyribbens force-pushed the add-predict-weight-test-for-witness-size branch 4 times, most recently from 3e7c83e to 8f6317f Compare April 14, 2023 09:53
@yancyribbens
Copy link
Contributor Author

IMO it'd be more valuable to use from_slice in the consts so that the numbers are obviously correct.

I can further expand the test coverage when I have a chance to.

Kixunil
Kixunil approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator
@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8f6317f

apoelstra
apoelstra approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8f6317f

@apoelstra apoelstra merged commit 0af8d45 into rust-bitcoin:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kixunil Kixunil Kixunil approved these changes

@apoelstra apoelstra apoelstra approved these changes

@tcharding tcharding tcharding left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yancyribbens @tcharding @apoelstra @Kixunil
0