8000 Rename `TaprootSpendInfo::as_script_map` to `script_map` by tcharding · Pull Request #1897 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Rename TaprootSpendInfo::as_script_map to script_map #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2023
Merged

Rename TaprootSpendInfo::as_script_map to script_map #1897

merged 1 commit into from
Jun 4, 2023
+5 −1

Conversation

tcharding
Copy link
Member
@tcharding tcharding commented Jun 2, 2023 •
edited
Loading

The as_script_map is a getter not a conversion function (to/into/as), as such it should not include the prefix as_.

Deprecate as_script_map in favour of script_map.

@tcharding tcharding added API break This PR requires a version bump for the next release release notes mention labels Jun 2, 2023
@tcharding
Rename TaprootSpendInfo::as_script_map to script_map
ccb6e3e 
The `as_script_map` is a getter not a conversion function (to/into/as),
as such it should not include the prefix `as_`.

Deprecate `as_script_map` in favour of `script_map`.
@tcharding tcharding removed the API break This PR requires a version bump for the next release label Jun 2, 2023
Kixunil
Kixunil approved these changes Jun 2, 2023
View reviewed changes
Copy link
Collaborator
@Kixunil Kixunil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ccb6e3e

@Kixunil Kixunil added the trivial Obvious, easy and quick to review (few lines or doc-only...) label Jun 2, 2023
@yancyribbens
Copy link
Contributor

ACK ccb6e3e

apoelstra
apoelstra approved these changes Jun 4, 2023
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ccb6e3e

@apoelstra apoelstra merged commit 15f2cb6 into rust-bitcoin:master Jun 4, 2023
@tcharding tcharding deleted the 06-02-script-map branch June 5, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kixunil Kixunil Kixunil approved these changes

@apoelstra apoelstra apoelstra approved these changes

@Dalaiyaz21213M Dalaiyaz21213M Dalaiyaz21213M approved these changes

Assignees
No one assigned
Labels
trivial Obvious, easy and quick to review (few lines or doc-only...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tcharding @yancyribbens @Kixunil @apoelstra @Dalaiyaz21213M
0