Avoid heap usage when encoding to base58 #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgeisler
commented
Nov 9, 2018
src/util/base58.rs
Outdated
| @@ -134,14 +177,12 @@ pub fn from_check(data: &str) -> Result<Vec<u8>, Error> { | |||
| Ok(ret) | |||
| } | |||
|
|
|||
| fn encode_iter_utf8<I>(data: I) -> Vec<u8> | |||
| fn encode_iter_utf8<I, W>(data: I, writer: &mut W) -> Result<(), fmt::Error> | |||
There was a problem hiding this comment.
It is obvious to me that the function should be renamed since it'f no longer returning UTF-8 bytes but rather writing unicode chars to a writer. What would you think is a good name instead?
sgeisler
commented
Nov 10, 2018
sgeisler
commented
Dec 3, 2018
src/util/base58.rs
Outdated
| String::from_utf8(ret).unwrap() | ||
| let mut ret = String::new(); | ||
| encode_iter_utf8(data, &mut ret).expect("writing into string shouldn't fail"); | ||
| ret | ||
| } | ||
|
|
||
| /// Directly encode a slice as base58 into a `Formatter`. | ||
| fn encode_iter_to_fmt<I>(fmt: &mut fmt::Formatter, data: I) -> fmt::Result |
There was a problem hiding this comment.
I just noticed that this function becomes redundant.
|
Looks great, thanks! |
apoelstra
approved these changes
Dec 4, 2018
yancyribbens
pushed a commit
to yancyribbens/rust-bitcoin
that referenced
this pull request
Mar 23, 2024
…straints
overhaul interpreter ("satisfied constraints") API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always allocating a
Vecthis implementation will work on the stack only as long as the output stays below 100 characters.Closes #145