Infrastructure fixes #1935
Merged
Infrastructure fixes #1935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdc6ee9 to
1041ad5
Compare
|
It looks like the new Cargo-minimal.lock does not actually work. |
1041ad5 to
716dde2
Compare
|
Ok, I was misunderstanding how to update the lock files, now I read the instructions in |
apoelstra
previously approved these changes
Jul 14, 2023
716dde2 to
4c64173
Compare
We use two different methods for specifying local dependencies, `patch` and also `path`. There does not seem to be a reason why we use both, lets be uniform. Elect to use `patch` for all local crates.
In order to keep the embedded and schemacs test crates building when we update their local transient dependencies we need to use a `patch` section. - For `bitcoin/embedded` add `patch` section for `internals`, `hashes` already has an entry. - For `hashes/embedded` add `patch` section for `internals`. - For `hashes/extendend_tests/schemars` add `patch` section for `internals`. FTR for direct local dependencies we use a `path` field when specifying the dependency.
To help folk work out how to run the `hashes/embedded` test crate copy over the `script` directory and an updated version of the `README` from `embedded/bitcoin`.
When building the `embedded` test crate `clippy` emits two warnings of form: warning: unused v 8000 ariable: `foo` Use `_` instead of a named variable.
Not totally necessary but since I went to the trouble of working out the last working version add it to the docs so the next guy can grep for `cargo update` to find them.
4c64173 to
7b402e9
Compare
|
Rebased on master, no other changes. |
apoelstra
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do a bunch of infrastructure fixes that either are needed for adding additional crate deps (hex) or updating deps (internals, hashes), or just make the tests more maintainable.