psbt: Add IndexOutOfBounds error #2004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently have a bunch of functions that are infallible if the `index` argument is within-bounds however we return a `SignError`, this obfuscates the code. Add an `IndexOutOfBoundsErorr`. While we are at it make it an enum so users can differentiate between which vector the out of bounds access was attempted against.
427460b to
66d5800
Compare
sanket1729
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
utACK 66d5800. This is a clean improvement over existing code.
|
I think we could use this for some of the sighash methods as well. |
|
Yeah I had the same idea yesterday, but this error type is tied to PSBT. It could be changed but since its basically all boilerplate code I rekon its better to just add another version of this error to the |
|
Hmm, ok. Then this is fine for now. |
apoelstra
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a bunch of functions that are infallible if the
indexargument is within-bounds however we return aSignError, this obfuscates the code.Add an
IndexOutOfBoundsError. While we are at it make it an enum so users can differentiate between which vector the out of bounds access was attempted against.