8000 Extract travis testing into locally-runnable script by dongcarl · Pull Request #227 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Extract travis testing into locally-runnable script #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2019
Merged

Extract travis testing into locally-runnable script #227

merged 1 commit into from
Feb 11, 2019

Conversation

dongcarl
Copy link
Member
@dongcarl dongcarl commented Jan 24, 2019 •
edited
Loading

This allows people to locally run contrib/test.sh on their fast hardware before Travis gets to it.

@dongcarl dongcarl force-pushed the 2019-01-improve-local-testing branch from 7fca28b to 6f06a32 Compare January 24, 2019 16:40
@dongcarl dongcarl added the ci label Jan 24, 2019
@dongcarl dongcarl requested a review from TheBlueMatt January 24, 2019 17:38
TheBlueMatt
TheBlueMatt previously approved these changes Jan 24, 2019
View reviewed changes
Copy link
Member
@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to still be testing things, may be worth double-checking that failures result in travis failures.

@dongcarl
Copy link
Member Author

Seems to still be testing things, may be worth double-checking that failures result in travis failures.

The script has a sh -e shebang so it'll fail when any of the commands in the script fail.

Checked assumption that if script fails travis also fails: https://docs.travis-ci.com/user/job-lifecycle/#customizing-the-build-phase

@sgeisler
Copy link
Contributor

In some of the rust-bitcoin projects I have an untracked script that

  1. runs cargo check or abort
  2. saves the current rust toolchain version
  3. switches to 1.22
  4. runs cargo test
  5. switches back to the original rust version

If you add 1.5 that runs test.sh (testing&fuzzing on current rust version) I think that would be useful for some of us. I can also just open a second PR for that if you want, it just feels related.

@dongcarl
Copy link
Member Author

I didn't know about cargo check! But this script does 2-5 just fine if you do this:
env TOOLCHAIN=1.22.0 contrib/test.sh

sgeisler
sgeisler previously approved these changes Feb 4, 2019
View reviewed changes
Copy link
Contributor
@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ran it locally, works with my setup.

@dongcarl dongcarl dismissed stale reviews from sgeisler and TheBlueMatt via 50fef2d February 4, 2019 15:39
@dongcarl dongcarl force-pushed the 2019-01-improve-local-testing branch from 6f06a32 to 50fef2d Compare February 4, 2019 15:39
@dongcarl
Copy link
Member Author
dongcarl commented Feb 4, 2019

Rebased, please reACK: @sgeisler @TheBlueMatt

@sgeisler
Copy link
Contributor
sgeisler commented Feb 4, 2019

Slightly off topic: is there a tool/git command that you can use to compare two change sets (see if it was just a rebase or which changes happened)?

@dongcarl
Copy link
Member Author
dongcarl commented Feb 4, 2019

Slightly off topic: is there a tool/git command that you can use to compare two change sets (see if it was just a rebase or which changes happened)?

They thought of everything: https://git-scm.com/docs/git-range-diff

@apoelstra apoelstra self-requested a review February 11, 2019 21:22
apoelstra
apoelstra approved these changes Feb 11, 2019
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack

@dongcarl dongcarl merged commit f87e173 into rust-bitcoin:master Feb 11, 2019
yancyribbens pushed a commit to yancyribbens/rust-bitcoin that referenced this pull request Mar 23, 2024
@apoelstra
Merge pull request rust-bitcoin#227 from sanket1729/psbt_hash
34a73ec 
Add psbt preimage satisfaction logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@sgeisler sgeisler sgeisler approved these changes

@TheBlueMatt TheBlueMatt TheBlueMatt left review comments

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dongcarl @sgeisler @TheBlueMatt @apoelstra
0