Add a MerkleBlock construction #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenroose
reviewed
May 28, 2019
stevenroose
reviewed
May 28, 2019
stevenroose
reviewed
May 28, 2019
stevenroose
reviewed
May 28, 2019
d723741 to
6b59e56
Compare
|
Please rebase, and please also write doctests that are compatible with 1.22 instead of ignoring them if possible. |
|
@apoelstra rebased & pushed with a hack/fix for the failing doctests on Rust 1.22. |
|
I'm curious why you use the extra |
apoelstra
previously approved these changes
Jul 5, 2019
Just copy pasted it from the tests but using the FromHex trait looks better as an example. Also I will change the examples a bit because the |
This is a port of the bitcoin-core CPartialMerkleTree and CMerkleBlock classes. Here they are called PartialMerkleTree and MerkleBlock. These are useful for SPV clients that wish to verify that a transaction is present in a specific block in an authenticated way.
|
Fixed the last issues withe the doctests. |
apoelstra
approved these changes
Jul 5, 2019
stevenroose
approved these changes
Jul 10, 2019
8000
yancyribbens
pushed a commit
to yancyribbens/rust-bitcoin
that referenced
this pull request
Mar 23, 2024
cf05787 Remove fixed TODO (sanket1729) Pull request description: This TODO was actually from 255 where the bug was in cast_unlikely, even though the issue is labeled with or_i (my bad for not checking). There is no code for `cast_unlikely` as it is treated as or_i. Addressed in 239efd5 Fixes rust-bitcoin#268 ACKs for top commit: apoelstra: ACK cf05787 Tree-SHA512: c55236979dfaac3e104edd35eb191be20fe45b6e994a886603d9b9c5559f49723fdaa10f73eaee7e7d6f30170f948f609e0369cd65c3569585675d432661f74a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of the bitcoin-core
CPartialMerkleTreeandCMerkleBlockclasses.Here they are called PartialMerkleTree and MerkleBlock.
These are useful for SPV clients that wish to verify that a transaction is
present in a specific block in an authenticated way.
This is a better attempt than my previous PR #19.
Note regarding the doc examples, I used
ignoreattribute to avoid failures with the older 1.22.0 Rust on TravisCI. It could be related to the usage ofextern crate ...in the examples. The doc tests pass as of Rust 1.32.0.