8000 Add ServiceFlags type by stevenroose · Pull Request #345 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add ServiceFlags type #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 6, 2019
Merged

Add ServiceFlags type #345

merged 3 commits into from
Dec 6, 2019

Conversation

stevenroose
Copy link
Collaborator
@stevenroose stevenroose commented Nov 22, 2019 •
edited
Loading

@tamasblummer Could you review this?

@codecov-io
Copy link
codecov-io commented Nov 22, 2019 •
edited
Loading

Codecov Report

Merging #345 into master will increase coverage by 0.23%.
The diff coverage is 88.53%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #345      +/-   ##
=========================================
+ Coverage   81.66%   81.9%   +0.23%     
=========================================
  Files          38      38              
  Lines        7032    7168     +136     
=========================================
+ Hits         5743    5871     +128     
- Misses       1289    1297       +8
Impacted Files Coverage Δ
src/network/mod.rs 0% <ø> (ø) ⬆️
src/network/message.rs 61.23% <100%> (ø) ⬆️
src/network/stream_reader.rs 95.62% <100%> (ø) ⬆️
src/network/message_network.rs 25% <50%> (ø) ⬆️
src/network/address.rs 88% <75%> (+8%) ⬆️
src/network/constants.rs 88.04% <89.58%> (+4.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 885fc39...1edc436. Read the comment docs.

@apoelstra
Copy link
Member

Maybe we should implement the | and |= operators rather than using an add method?

@stevenroose
Copy link
Collaborator Author

@apoelstra I'm always a fan of having explicit methods. But I implemented ops::BitOr, ops::BitOrAssign, ops::BitXor and ops::BitXorAssign using the existing methods. I'm not sure about ops::BitAnd and ops::BitAndAssign. It's kind of what one would use for has but in a more verbose way, so I'd prefer to not implement it.

apoelstra
apoelstra approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@apoelstra apoelstra merged commit 8547182 into rust-bitcoin:master Dec 6, 2019
yancyribbens pushed a commit to yancyribbens/rust-bitcoin that referenced this pull request Mar 23, 2024
@sanket1729
Merge rust-bitcoin/rust-miniscript#448: DerivedDescriptor unfinished …
c7c39f1 
…business

2ad6555 Rename "derive" things that are not doing derivation (LLFourn)
6dc6aca Make DerivedDescriptorKey first-class citizen (LLFourn)

Pull request description:

  This PR further develops the idea introduced in rust-bitcoin#345. It has two commits both with relatively detailed commit messages that can be reviewed separately. In summary:

  1. Develop the `DerivedDescriptorKey` (a key that is guaranteed not to have wildcard in it) idea more by adding missing functionality and refining the API. In addition, I removed the error cases from `ConversionError` which seems to have been omitted from rust-bitcoin#345.
  2. Since the introduction of `DerivedDescriptorKey`, the overlapping usage of the term "derive" has become quite confusing. In addition to the usual definition of "derive" we have also used it to mean "replace a wildcard with a particular derivation index". I deprecated and renamed everything that uses the latter definition.

ACKs for top commit:
  apoelstra:
    ACK 2ad6555
  sanket1729:
    ACK 2ad6555. Thanks for the clean changes.

Tree-SHA512: 0198404a1bfecab2324a8785117248fc566cfbb53decbd234928e378f102bdc5c5de6d31b437b8f1b0ba90ef524a362a46150028f80a4b029589406233abd2fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

@tamasblummer tamasblummer tamasblummer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stevenroose @codecov-io @apoelstra @tamasblummer
0