Adding MSRV to the readme #347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
=======================================
Coverage 81.66% 81.66%
=======================================
Files 38 38
Lines 7032 7032
=======================================
Hits 5743 5743
Misses 1289 1289Continue to review full report at Codecov.
|
TheBlueMatt
approved these changes
Nov 23, 2019
apoelstra
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this can prevent future PRs like
#346
rust-bitcoin/rust-secp256k1#123
and others.
we could also add a
rust-toolchainfile, but then we also need to edit the CI to be explicit on the right toolchain that isn't what's inrust-toolchainhttps://github.com/rust-lang/rustup#override-precedence