8000 Improving `construct_uint` macro by dr-orlovsky · Pull Request #395 · rust-bitcoin/rust-bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improving construct_uint macro #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2020
Merged

Improving construct_uint macro #395

merged 2 commits into from
Jan 24, 2020

Conversation

dr-orlovsky
Copy link
Collaborator

Fixing all external macro dependencies.

While this is not critical at all, I had to do this job for a dependent project (using an exportable version of this macro), so just thought why not to backport it into the main.

elichai
elichai previously approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member
@elichai elichai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK

stevenroose
stevenroose requested changes Jan 21, 2020
View reviewed changes
Copy link
Collaborator
@stevenroose stevenroose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remark for ::std, otherwise LGTM.

@dr-orlovsky dr-orlovsky mentioned this pull request Jan 22, 2020
Closed
@dr-orlovsky
Copy link
Collaborator Author

Related changes in the dependency: rust-bitcoin/bitcoin_hashes#73

@codecov-io
Copy link

Codecov Report

Merging #395 into master will increase coverage by 0.27%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   85.15%   85.43%   +0.27%     
==========================================
  Files          40       40              
  Lines        7478     7745     +267     
==========================================
+ Hits         6368     6617     +249     
- Misses       1110     1128      +18
Impacted Files Coverage Δ
src/hash_types.rs 100% <100%> (ø) ⬆️
src/util/uint.rs 84.4% <90%> (+0.74%) ⬆️
src/blo 8000 ckdata/opcodes.rs 97.51% <0%> (-0.25%) ⬇️
src/util/bip143.rs 100% <0%> (ø) ⬆️
src/util/bip158.rs 93.15% <0%> (+0.05%) ⬆️
src/util/amount.rs 86.8% <0%> (+0.17%) ⬆️
src/util/bip32.rs 87.32% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5452260...9c0f4b1. Read the comment docs.

stevenroose
stevenroose approved these changes Jan 22, 2020
View reviewed changes
Copy link
Collaborator
@stevenroose stevenroose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

apoelstra
apoelstra approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member
@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@apoelstra apoelstra merged commit a2bfcb5 into rust-bitcoin:master Jan 24, 2020
@dr-orlovsky dr-orlovsky mentioned this pull request Sep 12, 2020
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenroose stevenroose stevenroose approved these changes

@apoelstra apoelstra apoelstra approved these changes

@elichai elichai elichai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dr-orlovsky @codecov-io @stevenroose @apoelstra @elichai
0