Re-export 'ndk' and 'ndk_sys' crates #194
Conversation
There was a problem hiding this comment.
Neat. I should really start looking into rust-mobile/ndk#478 so that we can use and at the same time also return those internal ndk types back to users wherever needed/useful.
| // Since we expose `ndk` types in our public API it's convenient if crates can | ||
| // defer to these re-exported APIs and avoid having to bump explicit | ||
| // dependencies when they pull in new releases of android-activity. |
There was a problem hiding this comment.
'dependencies' is a surprisingly long word I suppose :)
I use a vscode plugin for wrapping at various column widths and this is already wrapped:
There was a problem hiding this comment.
Right, it can't reflow dependencies even though crates can on the first line looks out of place.
I tried helix which reflows it to 128 columns for some reason... Either way, IIRC they recently switched to an algorithm that tries to keep a balanced length while maintaining a maximum, rather than breaking whenever the next word would have gone over the limit.
825afb5 to
4b11d64
Compare
0251e7c to
12223db
Compare
4b11d64 to
b570174
Compare
Since we expose `ndk` types in the public API it makes sense to re-export these APIs so users of android-activity can defer to these without needing to manually sync the versions for explicit dependencies.
12223db to
602ccf8
Compare
Since we expose
ndktypes in the public API it makes sense to re-export these APIs so users of android-activity can defer to these without needing to manually sync the versions for explicit dependencies.