Use ok_or_else() in server-side certificate resolution.
#94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace one use of the (anti-)pattern:
```
if x.is_none() {
return Err(...)
};
x = x.unwrap();
```
The new code replaces a dynamic check for avoiding a panic with a
static assurance that there is no panic, in particular avoiding using
`unwrap()`.
This is purely a stylistic change and shouldn't have any semantic
effect. There are probably other instances that should be changed too.
I changed this particular one just because I am interested in improving
the code in this area.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace one use of the (anti-)pattern:
The new code replaces a dynamic check for avoiding a panic with a
static assurance that there is no panic, in particular avoiding using
unwrap().This is purely a stylistic change and shouldn't have any semantic
effect. There are probably other instances that should be changed too.
I changed this particular one just because I am interested in improving
the code in this area.