client: make ClientSessionImpl Sync-compatible #97
Conversation
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
|
What kind of threading model are you trying to support? IMO it makes more sense for the session state to be |
|
I am actually not that familiar with the Sync trait. I am using tokio-rustls to get a tls stream used to create a client, then I may have several threads, the client creating one channel per thread (and using a Arc<Mutex<>> to guard the stream). I managed to workaround that by using tokio-core's "handle.spawn" instead of creating an std::thread. It looks like I wasn't the only one hit by that: stepancheg/rust-tls-api@b7b396f Note that before 548db19 it worked fine |
|
Yes, you're right that ClientSession/ServerSession should both be both Send and Sync. Sorry about that. I earlier thought that |
Otherwise rustls can be tough to use in some multi threaded environment.