8000 Upgrade env_logger to 0.10 by djc · Pull Request #1303 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade env_logger to 0.10 #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Upgrade env_logger to 0.10 #1303

wants to merge 1 commit into from

Conversation

djc
Copy link
Member
@djc djc commented May 22, 2023

Just a dev-dependency, so it no longer affects our MSRV (since #1302).

@djc djc requested a review from cpu May 22, 2023 13:39
@codecov
Copy link
codecov bot commented May 22, 2023

Codecov Report

Merging #1303 (c8db52b) into main (c8e9e0b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1303   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files          60       60           
  Lines       14351    14351           
=======================================
  Hits        13713    13713           
  Misses        638      638           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@djc
Copy link
Member Author
djc commented May 22, 2023

Ahhh, yes, so this has the issue that it's not just a library MSRV issue, but the Cargo.toml contents (which get parsed at some point earlier in the dependency resolution process) being invalid before Cargo 1.60 (due to the use of weak or namespaced features).

@djc djc closed this May 22, 2023
@ctz ctz mentioned this pull request Jun 12, 2023
@djc djc deleted the env_logger-0.10 branch June 15, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0