Fix connect-tests for 1000-sans.badssl.com #1324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regressed in ae4ca32. DNS names starting with and wholly numerals are in wide use. RFC1035 actually doesn't really reflect reality, and RFC1123 updates it to allow labels that start with numerals or are wholly numeric. The only restriction is that the last label cannot be wholly numeric. Also: - Limit the entire length of a DNS name. - Ensure a label that ends with hyphens respects the label length limit.
Codecov Report
@@ Coverage Diff @@
## main #1324 +/- ##
=======================================
Coverage 95.87% 95.87%
=======================================
Files 61 61
Lines 14556 14574 +18
=======================================
+ Hits 13955 13973 +18
Misses 601 601
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cpu
approved these changes
Jun 23, 2023
|
Should we also add a link to the relevant section of the RFC? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This regressed in ae4ca32. DNS names starting with and wholly numerals are in wide use.
RFC1035 actually doesn't really reflect reality, and RFC1123 updates it to allow labels that start with numerals or are wholly numeric. The only restriction is that the last label cannot be wholly numeric.
Also:
(Both of these were found by writing a fuzzer that compared behaviour between the old and new implementations.)