8000 Moved to a working host by xuganyu96 · Pull Request #1328 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Moved to a working host #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2023
Merged

Moved to a working host #1328

merged 1 commit into from
Jun 29, 2023

Conversation

xuganyu96
Copy link
Contributor

Both simpleclient and limitedclient have been moved to communicate with www.rust-lang.org instead of google.com due to Google's HTTP server not implementing close_notify properly

@codecov
Copy link
codecov bot commented Jun 28, 2023

Codecov Report

Merging #1328 (46e799e) into main (a591363) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1328   +/-   ##
=======================================
  Coverage   95.87%   95.87%           
=======================================
  Files          61       61           
  Lines       14574    14574           
=======================================
  Hits        13973    13973           
  Misses        601      601

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

djc
djc approved these changes Jun 28, 2023
View reviewed changes
Copy link
Member
@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cpu
Copy link
Member
cpu commented Jun 28, 2023

The changes to simpleclient.rs and limitedclient.rs seem fine, but I see that simple_0rtt_client.rs is also broken in its own unique way. It would be nice to fix all of the examples at once so we could add CI coverage.

The 0rtt demo is using mesalink.io as the target domain and that resolves NXDOMAIN presently, breaking the example. The MesaLock Linux homepage seems to be some kind of cryptocurrency nonsense now so I guess the original project is dead?

I think we should switch the 0rtt demo to using www.rust-lang.org as well. That host isn't configured to accept 0-rtt data, but I can't find a reliable server to use in its place and the demo is coded to fall-back to normal requests so at least using a valid domain name results in a real request.

Cloudflare's blog post introducing 0-rtt used a 0rtt.tls13.com demo server, making requests to https://0rtt.tls13.com/img.png and peeking at returned headers but the in-browser demo doesn't work for me and trying to use curl or simple_0rtt_client I can only provoke a 404 response, no 0-rtt.

@ctz
Copy link
Member
ctz commented Jun 29, 2023

Have added #1330 which addresses the simple_0rtt_client issues

@ctz ctz merged commit 8a7a74c into rustls:main Jun 29, 2023
@xuganyu96 xuganyu96 deleted the bug/http-server-self-termination branch February 7, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xuganyu96 @cpu @ctz @djc
0