client: with_single_cert -> with_client_auth_cert
#1345
Conversation
|
Like this change!
It's also closer to |
7168276 to
46523a8
Compare
Codecov Report
@@ Coverage Diff @@
## main #1345 +/- ##
==========================================
- Coverage 96.43% 96.39% -0.05%
==========================================
Files 61 61
Lines 14461 14468 +7
==========================================
Hits 13946 13946
- Misses 515 522 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Cool 👍 I updated the PR desc, rebased on |
|
I also like this change. Should we do this as a deprecation with alias in the current release range, or in the next, before removing it entirely? |
Sure, that sounds friendlier. I will adjust. |
46523a8 to
09ce4e2
Compare
This commit renames the `ClientConfig` builder's `with_single_cert` function to be called `with_client_auth_cert`. The old `with_single_cert` function is left as an alias for `with_client_auth_cert` and marked as deprecated to encourage users to switch to the new name. I believe this offers better symmetry with the `with_no_client_auth` function that's used to disable client authentication, and more clearly conveys the purpose of this function is for providing a client authentication certificate.
09ce4e2 to
8b267c6
Compare
Summary: `rusttls::ClientConfig::with_single_cert` is deprecated in favor of `with_client_auth_cert`. It's just a rename - no behavior change: rustls/rustls#1345 Reviewed By: wxue Differential Revision: D50798363 fbshipit-source-id: db72c872182442561fbb74cf809379b6ea0c88e3
client: with_single_cert -> with_client_auth_cert
This commit renames the
ClientConfigbuilder'swith_single_certfunction to be calledwith_client_auth_cert. The oldwith_single_certfunction is left as an alias forwith_client_auth_certand marked as deprecated to encourage users to switch to the new name.I believe this offers better symmetry with the
with_no_client_authfunction that's used to disable client authentication, and more clearly conveys the purpose of this function is for providing a client authentication certificate.