8000 Remove `default_fips_provider()` item without aws_lc_rs by ctz · Pull Request #2064 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
10000

Remove default_fips_provider() item without aws_lc_rs #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2024
Merged

Remove default_fips_provider() item without aws_lc_rs #2064

merged 1 commit into from
Aug 1, 2024

Conversation

ctz
Copy link
Member
@ctz ctz commented Aug 1, 2024 •
edited
Loading

fixes #2063

@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Aug 1, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3959868 4001611 41743 (1.05%) 3.84%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4490732 4512001 21269 (0.47%) 4.45%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 13391989 13352618 -39371 (-0.29%) 0.83%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 33018674 32946713 -71961 (-0.22%) 0.69%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2140985 2136574 -4411 (-0.21%) 0.77%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46382049 46452988 70939 (0.15%) 0.31%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8870724 8881111 10387 (0.12%) 1.26%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3922570 3918019 -4551 (-0.12%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 13782579 13797927 15348 (0.11%) 1.06%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32969789 32933648 -36141 (-0.11%) 0.71%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30677195 30706033 28838 (0.09%) 0.45%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 31167356 31191640 24284 (0.08%) 0.35%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8891222 8884721 -6501 (-0.07%) 1.01%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30716122 30737136 21014 (0.07%) 0.57%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3383164 3381200 -1964 (-0.06%) 0.22%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58265520 58237379 -28141 (-0.05%) 0.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3385543 3386586 1043 (0.03%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4279090 4277908 -1182 (-0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 33558794 33550134 -8660 (-0.03%) 0.59%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4018345 4019141 796 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 13798755 13801185 2430 (0.02%) 0.99%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 31150653 31156003 5350 (0.02%) 0.31%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1917019 1916694 -325 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4352574 4351960 -614 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2235288 2235012 -276 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41939178 41944043 4865 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43471910 43476632 4722 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 31159063 31155691 -3372 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43368597 43372973 4376 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 44050535 44046237 -4298 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4390345 4390759 414 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30719728 30716900 -2828 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2228305 2228118 -187 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80617361 80623998 6637 (0.01%) 0.23%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58332256 58327767 -4489 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46411883 46408442 -3441 (-0.01%) 0.35%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42390586 42387590 -2996 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92660776 92666280 5504 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41853972 41856369 2397 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 33547135 33548998 1863 (0.01%) 0.77%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32970206 32968415 -1791 (-0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2853702 2853854 152 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80507209 80511445 4236 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42322348 42320308 -2040 (-0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4550128 4549910 -218 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43368493 43370512 2019 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58246036 58248518 2482 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30693777 30692525 -1252 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 31179563 31178411 -1152 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4393847 4394001 154 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32968504 32969645 1141 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2957349 2957450 101 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41935784 41934481 -1303 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 33580661 33579804 -857 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 2017081 2017132 51 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42317841 42316772 -1069 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42384268 42383224 -1044 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43372271 43373201 930 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43963193 43964026 833 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41854352 41853577 -775 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13742795 13742554 -241 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92704429 92702872 -1557 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30712011 30711500 -511 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43960399 43961128 729 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35473665 35474248 583 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12186340 12186143 -197 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43964609 43963931 -678 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2134446 2134414 -32 (-0.00%) 0.84%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 31202796 31202348 -448 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 33581048 33580588 -460 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42334922 42335498 576 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 31182860 31183219 359 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11992165 11992298 133 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58329773 58329131 -642 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42401874 42401417 -457 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 33547923 33548278 355 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 33009670 33010018 348 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46458650 46458165 -485 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43469498 43469048 -450 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92692428 92691513 -915 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41952500 41952901 401 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46436154 46435719 -435 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46469899 46470239 340 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58210613 58210205 -408 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 33547469 33547252 -217 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58248975 58249342 367 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41871646 41871419 -227 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1919997 1920007 10 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3916685 3916665 -20 (-0.00%) 0.37%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13744698 13744768 70 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30736753 30736908 155 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46375492 46375263 -229 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 44045396 44045189 -207 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80615217 80614847 -370 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35475993 35475837 -156 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92661561 92661952 391 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4269542 4269560 18 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43472599 43472769 170 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92666198 92665844 -354 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46461583 46461750 167 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4707693 4707705 12 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58333682 58333534 -148 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92706651 92706850 199 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68667271 68667404 133 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12180217 12180238 21 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80522819 80522950 131 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 33009685 33009734 49 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2951300 2951297 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80613856 80613795 -61 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46434786 46434810 24 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 44042585 44042604 19 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80514888 80514914 26 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.51 ms 4.48 ms -0.04 ms (-0.84%) 5.72%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.24 ms 5.20 ms -0.04 ms (-0.69%) 5.02%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.48 ms 5.44 ms -0.03 ms (-0.63%) 4.29%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.35 ms 6.31 ms -0.04 ms (-0.60%) 3.55%
transfer_no_resume_ring_1.3_rsa_aes 6.83 ms 6.79 ms -0.04 ms (-0.59%) 3.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 483.59 µs 480.83 µs -2.77 µs (-0.57%) 3.69%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 482.82 µs 480.09 µs -2.73 µs (-0.57%) 3.57%
handshake_no_resume_ring_1.3_ecdsap256_chacha 507.17 µs 504.77 µs -2.40 µs (-0.47%) 2.99%
handshake_no_resume_ring_1.3_ecdsap256_aes 509.71 µs 507.36 µs -2.36 µs (-0.46%) 2.82%
transfer_no_resume_ring_1.2_rsa_aes 6.73 ms 6.70 ms -0.03 ms (-0.44%) 3.24%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.46 ms 5.44 ms -0.02 ms (-0.43%) 3.67%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.43 ms 9.40 ms -0.04 ms (-0.41%) 2.55%
handshake_no_resume_ring_1.2_rsa_aes 982.03 µs 978.72 µs -3.31 µs (-0.34%) 1.76%
transfer_no_resume_ring_1.3_rsa_chacha 13.47 ms 13.43 ms -0.05 ms (-0.33%) 1.47%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.98 ms 12.94 ms -0.04 ms (-0.32%) 1.59%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.98 ms 12.94 ms -0.04 ms (-0.30%) 1.79%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.95 ms 13.91 ms -0.04 ms (-0.29%) 1.87%
handshake_session_id_ring_1.2_rsa_aes 1.57 ms 1.57 ms -0.00 ms (-0.28%) 2.04%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.71 ms 13.67 ms -0.03 ms (-0.25%) 1.53%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.08 ms 16.04 ms -0.04 ms (-0.25%) 1.58%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.28 ms 2.27 ms -0.00 ms (-0.21%) 5.19%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.39 ms 1.39 ms -0.00 ms (-0.21%) 6.06%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.20 ms 1.20 ms -0.00 ms (-0.20%) 1.29%
handshake_no_resume_ring_1.3_rsa_aes 991.57 µs 989.63 µs -1.94 µs (-0.20%) 1.09%
handshake_no_resume_ring_1.3_rsa_chacha 992.90 µs 991.21 µs -1.69 µs (-0.17%) 1.06%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.43 ms 1.43 ms -0.00 ms (-0.15%) 6.25%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.44 ms 1.44 ms -0.00 ms (-0.15%) 5.82%
handshake_tickets_ring_1.2_rsa_aes 1.65 ms 1.65 ms -0.00 ms (-0.14%) 1.96%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.38 ms 6.39 ms 0.01 ms (0.13%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.79 ms 6.78 ms -0.01 ms (-0.11%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.45 ms 6.45 ms 0.01 ms (0.09%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.20 ms 1.20 ms -0.00 ms (-0.09%) 1.12%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.40 ms 5.40 ms 0.00 ms (0.08%) 1.35%
handshake_tickets_ring_1.3_rsa_aes 7.31 ms 7.32 ms 0.01 ms (0.08%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.75 ms 6.75 ms -0.00 ms (-0.06%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.12 ms 6.12 ms 0.00 ms (0.06%) 1.45%
handshake_session_id_ring_1.3_rsa_chacha 7.23 ms 7.22 ms -0.00 ms (-0.06%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms -0.00 ms (-0.05%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.44 ms 6.45 ms 0.00 ms (0.05%) 1.08%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.19 ms 6.19 ms 0.00 ms (0.05%) 1.42%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.47 ms 5.47 ms 0.00 ms (0.05%) 1.40%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.46 ms 5.47 ms 0.00 ms (0.05%) 1.35%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms -0.00 ms (-0.05%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.14 ms 6.14 ms -0.00 ms (-0.04%) 1.47%
handshake_session_id_ring_1.3_ecdsap256_aes 6.80 ms 6.80 ms 0.00 ms (0.03%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.86 ms 9.86 ms -0.00 ms (-0.03%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 7.26 ms 7.26 ms -0.00 ms (-0.02%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 6.83 ms 6.83 ms 0.00 ms (0.02%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 7.28 ms 7.28 ms -0.00 ms (-0.02%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.20 ms 6.20 ms -0.00 ms (-0.02%) 1.62%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.43 ms 5.43 ms 0.00 ms (0.01%) 1.42%
handshake_session_id_ring_1.3_ecdsap384_aes 9.87 ms 9.88 ms 0.00 ms (0.01%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.41 ms 6.41 ms -0.00 ms (-0.01%) 1.44%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.10 ms 2.10 ms -0.00 ms (-0.01%) 4.56%
handshake_tickets_ring_1.3_ecdsap384_aes 9.91 ms 9.91 ms 0.00 ms (0.01%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.83 ms 9.83 ms 0.00 ms (0.00%) 1.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link
codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.46%. Comparing base (1177a46) to head (6e51ae7).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2064   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files         100      100           
  Lines       23229    23229           
=======================================
  Hits        21944    21944           
  Misses       1285     1285

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctz ctz added this pull request to the merge queue Aug 1, 2024
Merged via the queue into main with commit afb92e1 Aug 1, 2024
46 checks passed
@ctz ctz deleted the jbp-fips-docs-with-docrs branch August 1, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cargo doc fails when docsrs is enabled but fips is disabled due to cfg(any))
2 participants
@ctz @djc
0