8000 Fix daily-tests failures by ctz · Pull Request #2065 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix daily-tests failures #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2024
Merged

Fix daily-tests failures #2065

merged 2 commits into from
Aug 1, 2024

Conversation

ctz
Copy link
Member
@ctz ctz commented Aug 1, 2024

Unfortunately feature unification turned on fips mode for every workspace item. Rather than chase around making that work, just avoid it by specifying the workspace item each time.

Fixing that uncovered a test that wanted to see the HandshakePayloadTooLarge error which didn't carry-over in the recent refactor. Restore that.

See passing run: https://github.com/rustls/rustls/actions/runs/10197371458

ctz added 2 commits August 1, 2024 11:07
@ctz
Fix daily-tests due to unwanted feature unification
3b6fe88
@ctz
Reinstate checking for HandshakePayloadTooLarge
361a3b5 
There was no separate test for this, so it was dropped
in the recent refactor.  However connect-tests `too_many_sans`
does actually exercise this.

Restore the behaviour, and add a local test.
@ctz ctz changed the title Fix daily-tests features Fix daily-tests failures Aug 1, 2024
@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Aug 1, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4351980 4360757 ⚠️ 8777 (0.20%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4463210 4511369 48159 (1.08%) 3.47%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 4020627 3982598 -38029 (-0.95%) 3.84%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8851731 8887816 36085 (0.41%) 1.03%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 13771659 13806997 35338 (0.26%) 1.06%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2138666 2134242 -4424 (-0.21%) 0.81%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4018332 4026244 7912 (0.20%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4550513 4557666 7153 (0.16%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3381046 3386051 5005 (0.15%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30668303 30711273 42970 (0.14%) 0.41%
handshake_session_id_ring_1.2_rsa_aes_client 4278084 4283719 5635 (0.13%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 33015319 32974703 -40616 (-0.12%) 0.58%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3921148 3916788 -4360 (-0.11%) 0.32%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 33011057 32976780 -34277 (-0.10%) 0.70%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30718339 30743982 25643 (0.08%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58282069 58234925 -47144 (-0.08%) 0.22%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30735895 30760692 24797 (0.08%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 31202564 31226913 24349 (0.08%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30712170 30735254 23084 (0.08%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 31182990 31206377 23387 (0.07%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42382442 42412650 30208 (0.07%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30697124 30718750 21626 (0.07%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41934925 41964000 29075 (0.07%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 31180737 31201454 20717 (0.07%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42319462 42346547 27085 (0.06%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8879196 8884480 5284 (0.06%) 0.76%
handshake_tickets_ring_1.3_rsa_chacha_client 42334616 42359497 24881 (0.06%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41934714 41959034 24320 (0.06%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41854121 41877835 23714 (0.06%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41952141 41975910 23769 (0.06%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42317956 42341832 23876 (0.06%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42383796 42407591 23795 (0.06%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42401094 42424486 23392 (0.06%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41871801 41894857 23056 (0.06%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 31163367 31179988 16621 (0.05%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41857722 41879853 22131 (0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3380957 3382685 1728 (0.05%) 0.22%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 31185141 31169226 -15915 (-0.05%) 0.35%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 13759536 13766535 6999 (0.05%) 0.99%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2234860 2235734 874 (0.04%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46435447 46418247 -17200 (-0.04%) 0.33%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30745730 30755804 10074 (0.03%) 0.41%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 2016778 2017405 627 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 33561648 33570655 9007 (0.03%) 0.55%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 31162953 31154802 -8151 (-0.03%) 0.27%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 33526526 33535099 8573 (0.03%) 0.74%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80665779 80645435 -20344 (-0.03%) 0.23%
handshake_session_id_ring_1.2_rsa_aes_server 4270150 4271222 1072 (0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46428779 46417264 -11515 (-0.02%) 0.31%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 13387632 13384447 -3185 (-0.02%) 0.57%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46436074 46428352 -7722 (-0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46461899 46454248 -7651 (-0.02%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46469874 46462493 -7381 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1916638 1916941 303 (0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46458509 46451180 -7329 (-0.02%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46375525 46368241 -7284 (-0.02%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2853641 2854085 444 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1919924 1920221 297 (0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46434221 46427352 -6869 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2951332 2951670 338 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2227920 2228172 252 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3918270 3918647 377 (0.01%) 0.31%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80615081 80607814 -7267 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80522957 80515753 -7204 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80613605 80606479 -7126 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92708804 92700642 -8162 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80515434 80508429 -7005 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2136513 2136691 178 (0.01%) 0.78%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80514620 80507997 -6623 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4390299 4390636 337 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 33581122 33578844 -2278 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 44042258 44039315 -2943 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43469295 43466562 -2733 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 44044289 44042144 -2145 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43467561 43469671 2110 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 44041660 44043699 2039 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58248223 58245576 -2647 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43961401 43959548 -1853 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 33580924 33579529 -1395 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92667492 92663902 -3590 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92695691 92698871 3180 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12185941 12186359 418 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13742414 13742875 461 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12180054 12180444 390 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11991968 11992340 372 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92708079 92705392 -2687 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 33009518 33008601 -917 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58210508 58208904 -1604 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4393781 4393893 112 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68667410 68665674 -1736 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58249222 58247779 -1443 (-0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4707893 4708002 109 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2957364 2957432 68 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43471948 43471115 -833 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35475477 35476156 679 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58329688 58328605 -1083 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92661887 92660365 -1522 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58333152 58332261 -891 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32967508 32967991 483 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43373159 43372528 -631 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 33008710 33009085 375 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 33547510 33547878 368 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58330259 58330897 638 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92665796 92664859 -937 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 33546700 33546392 -308 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43962555 43962244 -311 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43369625 43369893 268 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32968346 32968149 -197 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13744556 13744486 -70 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43372896 43372679 -217 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43962623 43962832 209 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35473701 35473816 115 (0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_ring_1.2_rsa_aes 1.58 ms 1.60 ms ⚠️ 0.02 ms (1.37%) 1.21%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_ring_1.2_rsa_aes 1.66 ms 1.68 ms 0.03 ms (1.80%) 1.84%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.43 ms 1.41 ms -0.02 ms (-1.62%) 3.72%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.39 ms 1.37 ms -0.02 ms (-1.57%) 3.74%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.44 ms 1.42 ms -0.02 ms (-1.45%) 3.08%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.48 ms 5.42 ms -0.06 ms (-1.02%) 3.06%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.48 ms 5.42 ms -0.05 ms (-0.99%) 3.97%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.51 ms 4.48 ms -0.04 ms (-0.83%) 5.18%
handshake_tickets_ring_1.3_ecdsap256_aes 6.84 ms 6.89 ms 0.05 ms (0.73%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.23 ms 5.20 ms -0.04 ms (-0.70%) 4.02%
handshake_tickets_ring_1.3_rsa_aes 7.32 ms 7.37 ms 0.05 ms (0.67%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.79 ms 6.83 ms 0.04 ms (0.62%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.79 ms 6.83 ms 0.04 ms (0.60%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.75 ms 6.79 ms 0.04 ms (0.58%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 7.27 ms 7.31 ms 0.04 ms (0.58%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 7.28 ms 7.32 ms 0.04 ms (0.54%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 7.23 ms 7.27 ms 0.04 ms (0.49%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.34 ms 6.31 ms -0.03 ms (-0.47%) 3.34%
handshake_tickets_ring_1.3_ecdsap384_aes 9.92 ms 9.96 ms 0.05 ms (0.46%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.88 ms 9.92 ms 0.04 ms (0.44%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.87 ms 9.91 ms 0.04 ms (0.42%) 1.00%
transfer_no_resume_ring_1.3_rsa_aes 6.83 ms 6.80 ms -0.03 ms (-0.41%) 3.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.28 ms 2.27 ms -0.01 ms (-0.41%) 3.04%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.83 ms 9.87 ms 0.04 ms (0.40%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.20 ms 1.20 ms -0.00 ms (-0.37%) 1.28%
transfer_no_resume_ring_1.2_rsa_aes 6.74 ms 6.71 ms -0.02 ms (-0.36%) 2.90%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.94 ms 13.90 ms -0.05 ms (-0.35%) 1.58%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.45 ms 6.43 ms -0.02 ms (-0.30%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 483.65 µs 482.27 µs -1.39 µs (-0.29%) 2.93%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.38 ms 6.36 ms -0.02 ms (-0.28%) 1.02%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.43 ms 9.40 ms -0.03 ms (-0.28%) 2.41%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.41 ms 6.39 ms -0.02 ms (-0.27%) 1.16%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.11 ms 2.10 ms -0.01 ms (-0.26%) 2.28%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.40 ms 5.41 ms 0.01 ms (0.26%) 1.34%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.70 ms 13.67 ms -0.04 ms (-0.26%) 1.46%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.20 ms 1.20 ms -0.00 ms (-0.26%) 1.30%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.98 ms 12.95 ms -0.03 ms (-0.21%) 1.55%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.47 ms 5.48 ms 0.01 ms (0.21%) 1.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.97 ms 12.95 ms -0.03 ms (-0.20%) 1.59%
handshake_no_resume_ring_1.3_ecdsap256_aes 510.37 µs 509.41 µs -0.95 µs (-0.19%) 2.43%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.08 ms 16.05 ms -0.03 ms (-0.19%) 1.27%
transfer_no_resume_ring_1.3_rsa_chacha 13.47 ms 13.45 ms -0.02 ms (-0.18%) 1.40%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.19 ms 6.20 ms 0.01 ms (0.15%) 1.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 482.56 µs 481.84 µs -0.72 µs (-0.15%) 2.63%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.45 ms 6.44 ms -0.01 ms (-0.14%) 1.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha 507.31 µs 506.61 µs -0.71 µs (-0.14%) 1.59%
handshake_no_resume_ring_1.3_rsa_aes 992.35 µs 993.18 µs 0.84 µs (0.08%) 1.08%
handshake_no_resume_ring_1.3_rsa_chacha 993.45 µs 992.64 µs -0.81 µs (-0.08%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.43 ms 5.43 ms 0.00 ms (0.07%) 1.42%
handshake_no_resume_ring_1.2_rsa_aes 981.30 µs 980.83 µs -0.47 µs (-0.05%) 1.25%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.20 ms 6.20 ms -0.00 ms (-0.03%) 1.10%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.12 ms 6.12 ms 0.00 ms (0.03%) 1.09%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms 0.00 ms (0.02%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms -0.00 ms (-0.01%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.48 ms 5.48 ms 0.00 ms (0.00%) 1.28%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.14 ms 6.14 ms 0.00 ms (0.00%) 1.38%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link
codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.47%. Comparing base (1177a46) to head (361a3b5).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2065   +/-   ##
=======================================
  Coverage   94.46%   94.47%           
=======================================
  Files         100      100           
  Lines       23229    23248   +19     
=======================================
+ Hits        21944    21963   +19     
  Misses       1285     1285

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cpu
cpu approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member
@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ctz ctz added this pull request to the merge queue Aug 1, 2024
Merged via the queue into main with commit 858b19d Aug 1, 2024
46 checks passed
@ctz ctz deleted the jbp-fix-daily-tests-features branch August 1, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu
0