8000 Add end entity and client public keys in PEM format for testing by holodorum · Pull Request #2078 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add end entity and client public keys in PEM format for testing #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2024
Merged

Add end entity and client public keys in PEM format for testing #2078

merged 2 commits into from
Aug 14, 2024

Conversation

holodorum
Copy link
Contributor

This PR adds public keys in PEM format for the end entity and client, useful to test the implementation of Raw Public Keys in #2062

@holodorum holodorum mentioned this pull request Aug 9, 2024
Merged
@codecov Codecov
Copy link
codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.52%. Comparing base (35b5dcd) to head (8710766).
Report is 138 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2078      +/-   ##
==========================================
+ Coverage   94.18%   94.52%   +0.33%     
==========================================
  Files          97      102       +5     
  Lines       21640    23465    +1825     
==========================================
+ Hits        20382    22180    +1798     
- Misses       1258     1285      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ctz
ctz approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member
@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(could squash these two commits; i could take it or leave it.)

@rustls-benchmarking Rustls Benchmarking
Copy link

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5158527 4388693 ✅ -769834 (-14.92%) 3.47%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34787043 33179054 ✅ -1607989 (-4.62%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34786069 33179100 ✅ -1606969 (-4.62%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34767376 33203851 ✅ -1563525 (-4.50%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34767305 33204670 ✅ -1562635 (-4.49%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34741894 33189305 ✅ -1552589 (-4.47%) 0.82%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34747807 33197602 ✅ -1550205 (-4.46%) 0.65%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4442041 4317792 ✅ -124249 (-2.80%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4390159 4288192 ✅ -101967 (-2.32%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4393528 4291564 ✅ -101964 (-2.32%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8865859 8716088 ✅ -149771 (-1.69%) 1.31%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8870430 8726615 ✅ -143815 (-1.62%) 0.79%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 31193028 30839732 ✅ -353296 (-1.13%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 31169848 30821340 ✅ -348508 (-1.12%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 31168636 30844622 ✅ -324014 (-1.04%) 0.32%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 31146340 30863388 ✅ -282952 (-0.91%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 31146327 30864481 ✅ -281846 (-0.90%) 0.60%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 31121522 30843579 ✅ -277943 (-0.89%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4025469 3990538 ✅ -34931 (-0.87%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42344840 41999857 ✅ -344983 (-0.81%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42340170 41995333 ✅ -344837 (-0.81%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42357934 42013388 ✅ -344546 (-0.81%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42405030 42063628 ✅ -341402 (-0.81%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42423660 42082886 ✅ -340774 (-0.80%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42405191 42066026 ✅ -339165 (-0.80%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4558331 4525346 ✅ -32985 (-0.72%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4285291 4255216 ✅ -30075 (-0.70%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 44039603 43731228 ✅ -308375 (-0.70%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 44035522 43729132 ✅ -306390 (-0.70%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 44033675 43728463 ✅ -305212 (-0.69%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43958797 43656140 ✅ -302657 (-0.69%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43956032 43654751 ✅ -301281 (-0.69%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43958824 43658253 ✅ -300571 (-0.68%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4703788 4680853 ✅ -22935 (-0.49%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4266264 4246324 ✅ -19940 (-0.47%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30759278 30658635 ✅ -100643 (-0.33%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30733973 30633700 ✅ -100273 (-0.33%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30716241 30618509 ✅ -97732 (-0.32%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30741692 30644287 ✅ -97405 (-0.32%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1919664 1915153 ✅ -4511 (-0.23%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1916415 1911980 ✅ -4435 (-0.23%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 4015290 3944520 -70770 (-1.76%) 3.82%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 13794302 13865388 71086 (0.52%) 1.07%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 13377917 13431353 53436 (0.40%) 0.59%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30732529 30640016 -92513 (-0.30%) 0.44%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30731073 30639308 -91765 (-0.30%) 0.45%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41961162 41877764 -83398 (-0.20%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32958581 32893874 -64707 (-0.20%) 0.76%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41876240 41794575 -81665 (-0.20%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41885377 41803909 -81468 (-0.19%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41894150 41813096 -81054 (-0.19%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41956411 41876047 -80364 (-0.19%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41973820 41894607 -79213 (-0.19%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32961639 32900679 -60960 (-0.18%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32960980 32900588 -60392 (-0.18%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 33001028 32941244 -59784 (-0.18%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 33001507 32942453 -59054 (-0.18%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3921345 3914401 -6944 (-0.18%) 0.43%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2136097 2132911 -3186 (-0.15%) 0.74%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2138560 2135488 -3072 (-0.14%) 0.80%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58210622 58273833 63211 (0.11%) 0.23%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46451858 46405852 -46006 (-0.10%) 0.41%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3918672 3915863 -2809 (-0.07%) 0.25%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2235291 2233727 -1564 (-0.07%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3383186 3380853 -2333 (-0.07%) 0.22%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32954288 32932123 -22165 (-0.07%) 0.64%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 2017749 2016465 -1284 (-0.06%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3385757 3383825 -1932 (-0.06%) 0.23%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2227997 2226809 -1188 (-0.05%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43463380 43445834 -17546 (-0.04%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80600016 80631534 31518 (0.04%) 0.23%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43364992 43348271 -16721 (-0.04%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2957616 2956489 -1127 (-0.04%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43362297 43346767 -15530 (-0.04%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43463933 43448695 -15238 (-0.04%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43369924 43354779 -15145 (-0.03%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43460177 43445491 -14686 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 13807546 13803390 -4156 (-0.03%) 0.92%
handshake_no_resume_ring_1.2_rsa_aes_server 11991915 11988428 -3487 (-0.03%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2951553 2950709 -844 (-0.03%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46462711 46450563 -12148 (-0.03%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46454874 46442749 -12125 (-0.03%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46446554 46434661 -11893 (-0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46402793 46390945 -11848 (-0.03%) 0.60%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58247985 58262724 14739 (0.03%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46368192 46356852 -11340 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12185844 12182987 -2857 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58245539 58258597 13058 (0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13741984 13738967 -3017 (-0.02%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58331897 58319230 -12667 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13744305 13741335 -2970 (-0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58328162 58315719 -12443 (-0.02%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58209025 58197831 -11194 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92728678 92710952 -17726 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12179860 12177660 -2200 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92705195 92720238 15043 (0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58326250 58317754 -8496 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92660816 92647533 -13283 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92702998 92716221 13223 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46427644 46433844 6200 (0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92664107 92652190 -11917 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80504322 80512215 7893 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46428948 46432985 4037 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92663030 92655355 -7675 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80606531 80613061 6530 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68665242 68660175 -5067 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80607706 80612584 4878 (0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80516027 80519555 3528 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80507497 80510888 3391 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35473997 35473000 -997 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2853736 2853793 57 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35475740 35475355 -385 (-0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_ring_1.3_rsa_chacha 1.01 ms 0.99 ms ✅ -0.02 ms (-1.75%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.58 ms 1.56 ms ✅ -0.03 ms (-1.64%) 1.13%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.21 ms 6.11 ms ✅ -0.10 ms (-1.59%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.50 ms 5.41 ms ✅ -0.09 ms (-1.58%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 1.01 ms 0.99 ms ✅ -0.02 ms (-1.54%) 1.19%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.49 ms 5.41 ms ✅ -0.08 ms (-1.42%) 1.04%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.21 ms 6.12 ms ✅ -0.08 ms (-1.34%) 1.01%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.20 ms 1.18 ms ✅ -0.01 ms (-1.24%) 1.19%
handshake_tickets_ring_1.3_rsa_chacha 7.30 ms 7.22 ms ✅ -0.09 ms (-1.21%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.45 ms 6.37 ms ✅ -0.08 ms (-1.20%) 1.01%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.81 ms 6.73 ms ✅ -0.08 ms (-1.13%) 1.00%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.28 ms 2.24 ms -0.04 ms (-1.83%) 1.85%
handshake_tickets_ring_1.2_rsa_aes 1.67 ms 1.64 ms -0.02 ms (-1.33%) 1.90%
handshake_no_resume_ring_1.3_ecdsap256_aes 515.36 µs 509.08 µs -6.28 µs (-1.22%) 1.42%
handshake_session_id_ring_1.3_rsa_chacha 7.27 ms 7.19 ms -0.07 ms (-1.01%) 1.05%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.37 ms 0.01 ms (1.00%) 6.11%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.41 ms 1.43 ms 0.01 ms (0.99%) 5.98%
handshake_tickets_ring_1.3_rsa_aes 7.34 ms 7.27 ms -0.07 ms (-0.98%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 487.54 µs 482.85 µs -4.69 µs (-0.96%) 2.61%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.44 ms 6.38 ms -0.06 ms (-0.96%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.77 ms 6.71 ms -0.06 ms (-0.94%) 1.18%
handshake_no_resume_ring_1.3_ecdsap256_chacha 511.52 µs 506.72 µs -4.80 µs (-0.94%) 1.62%
handshake_tickets_ring_1.3_ecdsap256_aes 6.85 ms 6.78 ms -0.06 ms (-0.92%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 485.63 µs 481.36 µs -4.27 µs (-0.88%) 2.82%
handshake_session_id_ring_1.3_rsa_aes 7.31 ms 7.24 ms -0.06 ms (-0.87%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.41 ms 1.42 ms 0.01 ms (0.81%) 6.63%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.90 ms 9.82 ms -0.08 ms (-0.77%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.80 ms 6.75 ms -0.05 ms (-0.73%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.86 ms 9.79 ms -0.07 ms (-0.67%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.93 ms 9.87 ms -0.06 ms (-0.65%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.89 ms 9.83 ms -0.06 ms (-0.57%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.33 ms 6.36 ms 0.03 ms (0.54%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 984.79 µs 980.21 µs -4.59 µs (-0.47%) 1.01%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.20 ms 1.20 ms -0.01 ms (-0.42%) 1.31%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.28 ms 5.26 ms -0.01 ms (-0.26%) 4.04%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.38 ms 5.39 ms 0.01 ms (0.25%) 1.24%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.09 ms 6.11 ms 0.01 ms (0.23%) 1.19%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.49 ms 5.50 ms 0.01 ms (0.22%) 3.68%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.32 ms 6.33 ms 0.01 ms (0.22%) 1.00%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.08 ms 2.08 ms 0.00 ms (0.21%) 2.01%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.38 ms 5.37 ms -0.01 ms (-0.18%) 1.28%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.48 ms 5.49 ms 0.01 ms (0.17%) 3.67%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.38 ms 6.37 ms -0.01 ms (-0.16%) 3.03%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.55 ms 4.55 ms -0.01 ms (-0.16%) 4.76%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.08 ms 6.07 ms -0.01 ms (-0.15%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.61 ms 3.60 ms -0.00 ms (-0.13%) 1.00%
transfer_no_resume_ring_1.3_rsa_aes 6.87 ms 6.86 ms -0.01 ms (-0.12%) 2.80%
transfer_no_resume_ring_1.3_rsa_chacha 13.52 ms 13.50 ms -0.02 ms (-0.11%) 1.40%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.02 ms 13.01 ms -0.01 ms (-0.09%) 1.48%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.60 ms -0.00 ms (-0.09%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.95 ms 13.96 ms 0.01 ms (0.09%) 1.61%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.73 ms 13.72 ms -0.01 ms (-0.07%) 1.34%
transfer_no_resume_ring_1.2_rsa_aes 6.78 ms 6.77 ms -0.00 ms (-0.06%) 2.13%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.01 ms 13.02 ms 0.00 ms (0.04%) 1.36%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.11 ms 16.11 ms -0.01 ms (-0.03%) 1.21%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.47 ms 9.47 ms 0.00 ms (0.01%) 2.11%

Additional information

Historical results

Checkout details:

@ctz
Copy link
Member
ctz commented Aug 9, 2024

(I think those benchmark results are a result of this branch being before the ticketer changes.)

@holodorum @aochagavia
Add public keys in PEM format for end entity and client
95e7043 
Co-authored-by: Adolfo Ochagavía <github@adolfo.ochagavia.nl>
@holodorum
Copy link
Contributor Author

(could squash these two commits; i could take it or leave it.)

Squashed the two commits

(I think those benchmark results are a result of this branch being before the ticketer changes.)

I think you're right, I've synced the fork and rebased the branch.

@ctz
Copy link
Member
ctz commented Aug 14, 2024

I think this is low enough risk to merge with just my review.

@ctz ctz added this pull request to the merge queue Aug 14, 2024
Merged via the queue into rustls:main with commit 77f58db Aug 14, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holodorum @ctz
0