polyfill: allow dead code w/o built-in providers, no-std #2091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu
commented
Aug 26, 2024
|
Unrelated to this specific clippy finding I think our powerset job has been getting pretttttty chonky lately :-( Back when we added this step to the daily tests we only had ~5 features and the runtime was pretty manageable. We're up to ~9+ now and the power law is starting to punish us. The last successful run was 3 weeks ago and it took 15m to run through ~476 iterations. We added the Perhaps worth thinking on how to trim that down? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2091 +/- ##
=======================================
Coverage 94.78% 94.78%
=======================================
Files 102 102
Lines 23497 23497
=======================================
Hits 22271 22271
Misses 1226 1226 ☔ View full report in Codecov by Sentry. |
Only the `crypto/aws_lc_rs` and `crypto/ring` modules with std enabled use this polyfill. Since it's a small polyfill function we allow it to be dead code and avoid more complicated `cfg_attr` expressions.
ctz
approved these changes
Aug 27, 2024
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
There are some options to tell cargo-hack to reduce the feature power set. eg, we could add: grouping feature dependencies:
(I haven't tried any of these; just going from the docs.) |
I can fiddle with some of this in a follow-up 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dead code warning from
clippyfor--no-default-featuresbuilds has been breaking the daily powerset job (exemplar) since 1c33f4b landed.Since it's a small polyfill function we allow it to be dead code and avoid more complicated
cfg_attrexpressions. Here's a passing run with the change applied.