8000 Fix daily connect-tests by cpu · Pull Request #2127 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix daily connect-tests #2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 19, 2024
Merged

Fix daily connect-tests #2127

merged 2 commits into from
Sep 19, 2024

Conversation

cpu
Copy link
Member
@cpu cpu commented Sep 19, 2024 •
edited
Loading

Our daily connect tests CI job has been failing. This branch lands two fixes to restore it to green:

  1. A type alias added in Send flights of handshake messages in single message #2120 needs a cfg gate to only include it when the tls12 feature is active to avoid a dead code warning when that feature isn't enabled.

  2. The crypto.cloudflare.com domain's HTTPS record seems to no longer include an ech parameter, breaking the deserialization test. The domain this redirects to in a browser, research.cloudflare.com, does have an ech parameter in its HTTPS record, so let's use that.

❯ dig +short crypto.cloudflare.com HTTPS
1 . alpn="h2" ipv4hint=162.159.135.79,162.159.136.79 ipv6hint=2606:4700:7::a29f:874f,2606:4700:7::a29f:884f

❯ dig +short research.cloudflare.com HTTPS
1 . alpn="http/1.1,h2" ipv4hint=162.159.137.85,162.159.138.85 ech=AEX+DQBBlQAgACBDw7OiRdqE2AU6C2icJ25ynRmMzmp9V3c6ZXiXwVprdQAEAAEAAQASY2xvdWRmbGFyZS1lY2guY29tAAA= ipv6hint=2606:4700:7::a29f:8955,2606:4700:7::a29f:8a55

cpu added 2 commits September 19, 2024 16:58
@cpu
common_state: feature gate TLS 1.2 HS flight alias
3569af2 
The `HandshakeFlightTls12` type alias is only used when the tls12
feature is enabled. This commit adds a `cfg` gate to avoid a dead code
warning on builds without the feature enabled.
@cpu
connect-tests: update cloudflare ECH domain
a4f4203 
For some reason the `crypto.cloudflare.com` DNS zone's HTTPS record no
longer contains an `ech` config, breaking our ECH record deserialization
connect-test.

The domain that `crypto.cloudflare.com` redirects to in a browser,
`research.cloudflare.com`, does include an `ech` value in the HTTPS
record, so let's use that instead.
@cpu cpu self-assigned this Sep 19, 2024
@rustls-benchmarking Rustls Benchmarking
Copy link

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5155077 5198338 43261 (0.84%) 4.29%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 13782797 13845520 62723 (0.46%) 0.86%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 13425509 13388188 -37321 (-0.28%) 0.83%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34768504 34680489 -88015 (-0.25%) 0.55%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32922759 32985738 62979 (0.19%) 0.52%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8860717 8876139 15422 (0.17%) 0.98%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32903964 32855345 -48619 (-0.15%) 0.60%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30687651 30721479 33828 (0.11%) 0.52%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80656254 80572264 -83990 (-0.10%) 0.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8870229 8862638 -7591 (-0.09%) 1.25%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3375815 3373041 -2774 (-0.08%) 0.26%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3988373 3985230 -3143 (-0.08%) 3.25%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 31103200 31125885 22685 (0.07%) 0.56%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3378596 3376570 -2026 (-0.06%) 0.23%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46365823 46391353 25530 (0.06%) 0.33%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46445866 46470205 24339 (0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 31091340 31106048 14708 (0.05%) 0.35%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58257286 58242326 -14960 (-0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92717560 92696042 -21518 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2126245 2126689 444 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34683618 34690236 6618 (0.02%) 0.41%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30681658 30686914 5256 (0.02%) 0.42%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4448892 4449634 742 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 13800774 13802826 2052 (0.01%) 0.82%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42366921 42372837 5916 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 31081661 31085746 4085 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4035966 4036455 489 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3909459 3909932 473 (0.01%) 0.41%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43322050 43316842 -5208 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30662475 30666118 3643 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41836107 41831667 -4440 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2127404 2127627 223 (0.01%) 0.82%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 2228296 2228526 230 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2951977 2952281 304 (0.01%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4563032 4562569 -463 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43999494 44003780 4286 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58329440 58334737 5297 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1903823 1903986 163 (0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30701457 30704065 2608 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 2010233 2010400 167 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46436347 46440185 3838 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41915893 41919269 3376 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92661729 92668545 6816 (0.01%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4289718 4289456 -262 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34720395 34722409 2014 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80505033 80509464 4431 (0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2852501 2852641 140 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34732895 34734576 1681 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1906187 1906096 -91 (-0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4707985 4708203 218 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3910954 3910781 -173 (-0.00%) 0.44%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42296470 42294634 -1836 (-0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4270750 4270567 -183 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 2221446 2221536 90 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4377235 4377062 -173 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11980610 11981068 458 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 31118932 31120113 1181 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58245217 58247364 2147 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43903358 43904729 1371 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2946384 2946474 90 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41915032 41916293 1261 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12172143 12171798 -345 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30682104 30682963 859 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92703289 92705803 2514 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43907711 43906667 -1044 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4373933 4373834 -99 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34724684 34725394 710 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43998311 43999186 875 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42364463 42363734 -729 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41827617 41826983 -634 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12178037 12177854 -183 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32907397 32906969 -428 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43316712 43316203 -509 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43426166 43426650 484 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35470500 35470885 385 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13734283 13734424 141 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42292161 42291731 -430 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43423318 43423756 438 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30720033 30720328 295 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46447640 46448084 444 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43313404 43312997 -407 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46427554 46427986 432 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32907856 32907551 -305 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80609794 80610514 720 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43996893 43997264 371 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 31105618 31105840 222 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41933474 41933211 -263 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46348346 46348062 -284 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32960397 32960590 193 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58331555 58331878 323 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34729479 34729648 169 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92705170 92705514 344 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58247412 58247198 -214 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68658498 68658259 -239 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92664603 92664319 -284 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32959821 32959721 -100 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 31142542 31142635 93 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80516455 80516677 222 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35468853 35468943 90 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43907161 43907051 -110 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58207647 58207789 142 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92660459 92660236 -223 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80608142 80607958 -184 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80508328 80508188 -140 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13736426 13736447 21 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46429656 46429724 68 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46439546 46439597 51 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41844651 41844688 37 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42382469 42382433 -36 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42309611 42309579 -32 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43427424 43427455 31 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58328333 58328300 -33 (-0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.45 ms 5.40 ms -0.05 ms (-0.94%) 5.26%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.51 ms 4.47 ms -0.04 ms (-0.87%) 5.50%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.45 ms 5.41 ms -0.04 ms (-0.77%) 5.40%
transfer_no_resume_ring_1.2_rsa_aes 6.74 ms 6.69 ms -0.05 ms (-0.75%) 3.46%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.33 ms 6.29 ms -0.04 ms (-0.71%) 4.55%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 485.45 µs 482.06 µs -3.39 µs (-0.70%) 3.02%
transfer_no_resume_ring_1.3_rsa_aes 6.81 ms 6.77 ms -0.05 ms (-0.70%) 3.88%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.23 ms 5.20 ms -0.03 ms (-0.63%) 4.63%
handshake_no_resume_ring_1.3_ecdsap256_aes 510.28 µs 507.42 µs -2.86 µs (-0.56%) 1.86%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 481.09 µs 478.48 µs -2.60 µs (-0.54%) 3.73%
handshake_no_resume_ring_1.3_ecdsap256_chacha 504.98 µs 502.39 µs -2.59 µs (-0.51%) 2.63%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.44 ms 9.39 ms -0.05 ms (-0.50%) 2.82%
transfer_no_resume_ring_1.3_rsa_chacha 13.48 ms 13.43 ms -0.05 ms (-0.39%) 1.96%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.72 ms 6.69 ms -0.02 ms (-0.37%) 1.44%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.76 ms 6.74 ms -0.02 ms (-0.37%) 1.22%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.98 ms 12.93 ms -0.05 ms (-0.36%) 2.26%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.99 ms 12.94 ms -0.05 ms (-0.35%) 1.86%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.70 ms 13.66 ms -0.04 ms (-0.33%) 1.89%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.36 ms -0.00 ms (-0.32%) 2.33%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.91 ms 13.87 ms -0.04 ms (-0.32%) 2.19%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.09 ms 16.04 ms -0.05 ms (-0.31%) 1.80%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.42 ms 1.41 ms -0.00 ms (-0.31%) 2.10%
handshake_no_resume_ring_1.3_rsa_chacha 991.22 µs 988.12 µs -3.10 µs (-0.31%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.76 ms 6.74 ms -0.02 ms (-0.30%) 1.79%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.20 ms 1.20 ms -0.00 ms (-0.29%) 1.17%
handshake_no_resume_ring_1.2_rsa_aes 980.33 µs 977.51 µs -2.81 µs (-0.29%) 1.30%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.41 ms 1.40 ms -0.00 ms (-0.28%) 3.08%
handshake_tickets_ring_1.3_ecdsap256_aes 6.81 ms 6.79 ms -0.02 ms (-0.28%) 1.24%
handshake_no_resume_ring_1.3_rsa_aes 989.55 µs 986.90 µs -2.65 µs (-0.27%) 1.08%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.20 ms 1.20 ms -0.00 ms (-0.27%) 1.40%
handshake_tickets_ring_1.3_rsa_chacha 7.23 ms 7.22 ms -0.01 ms (-0.19%) 1.29%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.60 ms -0.01 ms (-0.18%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 7.19 ms 7.18 ms -0.01 ms (-0.18%) 1.06%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.80 ms 9.79 ms -0.02 ms (-0.17%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.52 ms 5.53 ms 0.01 ms (0.14%) 1.87%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.84 ms 9.83 ms -0.01 ms (-0.14%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.66 ms 1.67 ms 0.00 ms (0.14%) 1.05%
handshake_tickets_ring_1.3_ecdsap384_aes 9.89 ms 9.88 ms -0.01 ms (-0.13%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 7.29 ms 7.28 ms -0.01 ms (-0.13%) 1.22%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms -0.00 ms (-0.13%) 1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.29 ms 2.29 ms 0.00 ms (0.12%) 1.80%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.24 ms 6.25 ms 0.01 ms (0.10%) 1.66%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.42 ms 5.43 ms 0.01 ms (0.10%) 2.10%
handshake_session_id_ring_1.3_ecdsap384_aes 9.84 ms 9.83 ms -0.01 ms (-0.08%) 1.08%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.36 ms 6.35 ms -0.01 ms (-0.08%) 1.80%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.08 ms 2.08 ms -0.00 ms (-0.07%) 2.47%
handshake_session_id_ring_1.3_rsa_aes 7.24 ms 7.24 ms -0.00 ms (-0.06%) 1.35%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.53 ms 5.53 ms -0.00 ms (-0.05%) 2.29%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.47 ms 6.47 ms 0.00 ms (0.04%) 1.85%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.48 ms 6.48 ms 0.00 ms (0.02%) 1.69%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.37 ms 6.37 ms -0.00 ms (-0.02%) 1.86%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.24 ms 6.24 ms 0.00 ms (0.02%) 1.80%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.40 ms 5.41 ms 0.00 ms (0.02%) 2.16%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.12 ms 6.12 ms -0.00 ms (-0.02%) 1.66%
handshake_session_id_ring_1.2_rsa_aes 1.58 ms 1.58 ms -0.00 ms (-0.00%) 1.39%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.14 ms 6.14 ms 0.00 ms (0.00%) 2.11%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link
codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.64%. Comparing base (bfb7665) to head (a4f4203).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2127   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files         102      102           
  Lines       23415    23415           
=======================================
  Hits        22160    22160           
  Misses       1255     1255

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cpu cpu added this pull request to the merge queue Sep 19, 2024
Merged via the queue into rustls:main with commit fa4242c Sep 19, 2024
32 checks passed
@cpu cpu deleted the cpu-daily-test-fixes branch September 19, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctz ctz ctz approved these changes

Assignees

@cpu cpu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpu @ctz
0