8000 Small refactors by liujustin604 · Pull Request #2130 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Small refactors #2130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 21, 2024
Merged

Small refactors #2130

merged 2 commits into from
Sep 21, 2024

Conversation

liujustin604
Copy link
Contributor

Use if let Some(x) instead of checking is_some() and then unwrapping inside the if statement

djc
djc approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member
@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these are nice improvements!

@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Sep 21, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10485933 10433225 -52708 (-0.50%) 0.71%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8599328 8582570 -16758 (-0.19%) 0.98%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10803462 10787093 -16369 (-0.15%) 1.01%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10811936 10822712 10776 (0.10%) 0.82%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3092987 3095558 2571 (0.08%) 0.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8586607 8593327 6720 (0.08%) 1.25%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3631583 3634026 2443 (0.07%) 0.41%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3633000 3635050 2050 (0.06%) 0.45%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58331911 58333475 1564 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3097049 3096969 -80 (-0.00%) 0.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1282693 1282671 -22 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1284942 1284964 22 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1668638 1668610 -28 (-0.00%) 0.82%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32057922 32058374 452 (0.00%) 0.66%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717596 1717574 -22 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58253610 58252961 -649 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30725095 30725426 331 (0.00%) 0.37%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32114364 32114090 -274 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30747672 30747498 -174 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30758867 30758716 -151 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34127229 34127070 -159 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34121135 34121281 146 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1933712 1933719 7 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30759255 30759153 -102 (-0.00%) 0.56%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2168933 2168926 -7 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2171950 2171943 -7 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34124190 34124094 -96 (-0.00%) 0.56%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30323187 30323104 -83 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30359209 30359141 -68 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30344695 30344761 66 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30781736 30781798 62 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34126908 34126965 57 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34118343 34118393 50 (0.00%) 0.41%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7614615 7614605 -10 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 8000 32114173 32114214 41 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32110845 32110879 34 (0.00%) 0.53%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30308760 30308738 -22 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30724619 30724641 22 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35187001 35186976 -25 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30344723 30344741 18 (0.00%) 0.52%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32060971 32060985 14 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30308677 30308690 13 (0.00%) 0.43%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34121024 34121011 -13 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46488075 46488063 -12 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32061167 32061160 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46396506 46396515 9 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46477878 46477883 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92665991 92666000 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92715478 92715485 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68671580 68671585 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80668293 80668288 -5 (-0.00%) 0.24%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58243346 58243343 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80644634 80644630 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92714403 92714399 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46440353 46440355 2 (0.00%) 0.35%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92666743 92666745 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46486530 46486529 -1 (-0.00%) 0.22%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58252762 58252761 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58334576 58334577 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58340327 58340328 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80544649 80544650 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80546356 80546355 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80561376 80561377 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80669829 80669830 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92704785 92704786 1 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41795034 41795034 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46492903 46492903 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43293203 43293203 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43853649 43853649 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46462878 46462878 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4535361 4535361 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7612472 7612472 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92672497 92672497 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46476802 46476802 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43947159 43947159 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42182848 42182848 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43182783 43182783 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4239160 4239160 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3879393 3879393 0 (0.00%) 3.41%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41794493 41794493 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3907851 3907851 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4254329 4254329 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43950499 43950499 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11476628 11476628 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43182653 43182653 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42168986 42168986 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43293333 43293333 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11482583 11482583 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41705783 41705783 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42168480 42168480 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41808752 41808752 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42242274 42242274 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4999114 4999114 0 (0.00%) 4.29%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35185110 35185110 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42242696 42242696 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2663086 2663086 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2657243 2657243 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41720042 41720042 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43179820 43179820 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11291853 11291853 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58223755 58223755 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1667234 1667234 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43950346 43950346 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43856989 43856989 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4679097 4679097 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563606 2563606 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4270372 4270372 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43290370 43290370 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41706324 41706324 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1926998 1926998 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42256642 42256642 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43856836 43856836 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.50 ms 5.45 ms -0.04 ms (-0.79%) 5.45%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.27 ms 5.23 ms -0.04 ms (-0.75%) 4.63% 8000
transfer_no_resume_ring_1.3_ecdsap256_aes 6.40 ms 6.36 ms -0.05 ms (-0.74%) 4.55%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.55 ms 4.52 ms -0.03 ms (-0.73%) 5.50%
transfer_no_resume_ring_1.3_rsa_aes 6.90 ms 6.85 ms -0.05 ms (-0.73%) 3.88%
transfer_no_resume_ring_1.2_rsa_aes 6.81 ms 6.77 ms -0.05 ms (-0.67%) 3.46%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.51 ms 5.48 ms -0.03 ms (-0.58%) 5.26%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.39 ms 1.39 ms -0.01 ms (-0.49%) 2.11%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.51 ms 9.46 ms -0.05 ms (-0.48%) 2.82%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.38 ms 1.38 ms -0.01 ms (-0.40%) 3.08%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.75 ms 13.70 ms -0.05 ms (-0.39%) 1.90%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 459.37 µs 457.56 µs -1.81 µs (-0.39%) 3.73%
transfer_no_resume_ring_1.3_rsa_chacha 13.54 ms 13.49 ms -0.05 ms (-0.37%) 2.07%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.03 ms 12.98 ms -0.05 ms (-0.35%) 2.26%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.05 ms 13.00 ms -0.04 ms (-0.34%) 1.86%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.97 ms 13.92 ms -0.05 ms (-0.34%) 2.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 459.99 µs 458.51 µs -1.48 µs (-0.32%) 2.77%
handshake_no_resume_ring_1.3_ecdsap256_chacha 500.52 µs 499.03 µs -1.48 µs (-0.30%) 2.63%
handshake_no_resume_ring_1.2_rsa_aes 978.16 µs 975.34 µs -2.81 µs (-0.29%) 1.26%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.15 ms 16.10 ms -0.04 ms (-0.27%) 1.80%
handshake_no_resume_ring_1.3_rsa_chacha 983.83 µs 981.35 µs -2.49 µs (-0.25%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_aes 503.74 µs 502.49 µs -1.24 µs (-0.25%) 1.95%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.35 ms 1.35 ms -0.00 ms (-0.23%) 2.33%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.17 ms -0.00 ms (-0.22%) 1.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.17 ms -0.00 ms (-0.22%) 1.40%
handshake_no_resume_ring_1.3_rsa_aes 984.73 µs 982.87 µs -1.86 µs (-0.19%) 1.08%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.07 ms 2.07 ms -0.00 ms (-0.18%) 1.74%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.90 ms 1.90 ms -0.00 ms (-0.17%) 2.43%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.46 ms 6.46 ms -0.01 ms (-0.15%) 1.44%
handshake_tickets_ring_1.3_ecdsap256_aes 6.65 ms 6.64 ms -0.01 ms (-0.11%) 1.24%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.62 ms 5.63 ms 0.01 ms (0.10%) 1.62%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.59 ms 4.60 ms 0.00 ms (0.10%) 2.07%
handshake_session_id_ring_1.3_ecdsap256_aes 6.51 ms 6.51 ms -0.01 ms (-0.09%) 1.69%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.63 ms 5.64 ms 0.00 ms (0.08%) 1.53%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.28 ms 5.28 ms 0.00 ms (0.07%) 1.62%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.92 ms 4.92 ms -0.00 ms (-0.07%) 2.21%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.68 ms 9.68 ms 0.01 ms (0.07%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.94 ms 6.95 ms 0.00 ms (0.07%) 1.06%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.60 ms -0.00 ms (-0.06%) 1.33%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.92 ms 4.92 ms 0.00 ms (0.06%) 1.76%
handshake_tickets_ring_1.3_ecdsap384_aes 9.73 ms 9.74 ms 0.01 ms (0.06%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms -0.00 ms (-0.06%) 1.39%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.30 ms 5.31 ms 0.00 ms (0.05%) 1.86%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.59 ms 6.59 ms -0.00 ms (-0.05%) 1.22%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.54 ms 5.54 ms -0.00 ms (-0.05%) 1.83%
handshake_session_id_ring_1.3_rsa_aes 7.00 ms 7.00 ms 0.00 ms (0.05%) 1.35%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.57 ms 4.58 ms 0.00 ms (0.04%) 1.99%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.87 ms 5.87 ms -0.00 ms (-0.04%) 1.69%
handshake_tickets_ring_1.3_rsa_aes 7.13 ms 7.13 ms 0.00 ms (0.04%) 1.22%
handshake_session_id_ring_1.3_ecdsap384_aes 9.60 ms 9.60 ms 0.00 ms (0.03%) 1.08%
handshake_tickets_ring_1.3_rsa_chacha 7.07 ms 7.07 ms 0.00 ms (0.02%) 1.42%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms 0.00 ms (0.02%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms 0.00 ms (0.01%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.51 ms 5.52 ms 0.00 ms (0.01%) 1.80%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.86 ms 5.86 ms 0.00 ms (0.01%) 1.84%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.55 ms 9.55 ms 0.00 ms (0.01%) 1.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link
codecov bot commented Sep 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.63%. Comparing base (a92dd8f) to head (11c8b3e).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2130      +/-   ##
==========================================
- Coverage   94.64%   94.63%   -0.01%     
==========================================
  Files         102      102              
  Lines       23415    23412       -3     
==========================================
- Hits        22160    22157       -3     
  Misses       1255     1255

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djc
Copy link
Member
djc commented Sep 21, 2024

Just some small formatting fixes to apply.

cpu
cpu approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member
@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod needing rustfmt

Thanks!

@cpu cpu merged commit 1aebb54 into rustls:main Sep 21, 2024
31 checks passed
@cpu
Copy link
Member
cpu commented Sep 21, 2024

Admin merged so I could squash the commits.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liujustin604 @djc @cpu
0