8000 Take aws-lc-rs 1.10 by ctz · Pull Request #2147 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Take aws-lc-rs 1.10 #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2024
Merged

Take aws-lc-rs 1.10 #2147

merged 2 commits into from
Oct 4, 2024

Conversation

ctz
Copy link
Member
@ctz ctz commented Oct 4, 2024

No description provided.

@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Oct 4, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10395345 10447617 52272 (0.50%) 0.84%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10794606 10837408 42802 (0.40%) 0.82%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10815290 10833332 18042 (0.17%) 1.15%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3620692 3624983 4291 (0.12%) 0.33%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3086461 3083242 -3219 (-0.10%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3081632 3084795 3163 (0.10%) 0.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2176731 2178396 1665 (0.08%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2173719 2175377 1658 (0.08%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8600679 8595099 -5580 (-0.06%) 1.14%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3623475 3621161 -2314 (-0.06%) 0.42%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1283632 1283969 337 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1281293 1281616 323 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8587389 8587010 -379 (-0.00%) 0.50%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717594 1717523 -71 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925907 1925844 -63 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932621 1932565 -56 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58354514 58352846 -1668 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46451189 46452472 1283 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46484569 46485850 1281 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1666024 1665988 -36 (-0.00%) 1.03%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1667388 1667416 28 (0.00%) 1.01%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30748649 30748159 -490 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30782671 30782255 -416 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30760118 30759737 -381 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30726085 30725731 -354 (-0.00%) 0.33%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30311854 30311511 -343 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30362443 30362112 -331 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30348383 30348056 -327 (-0.00%) 0.29%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30760294 30759966 -328 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30726017 30725695 -322 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34141919 34141584 -335 (-0.00%) 0.21%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34138886 34138558 -328 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34138687 34138377 -310 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30326320 30326049 -271 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32130225 32129945 -280 (-0.00%) 0.45%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32080310 32080047 -263 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32133306 32133045 -261 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32077267 32077056 -211 (-0.00%) 0.22%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30347866 30347718 -148 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34144679 34144517 -162 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34136017 34135858 -159 (-0.00%) 0.22%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34144913 34144765 -148 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30312334 30312220 -114 (-0.00%) 0.25%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32133341 32133289 -52 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7619299 7619309 10 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32080280 32080255 -25 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35184939 35184964 25 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46464453 46464442 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46476497 46476508 11 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46479168 46479178 10 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58356602 58356613 11 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46489372 46489365 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80667613 80667623 10 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92688762 92688773 11 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80646206 80646211 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92718956 92718961 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58260231 58260234 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58345704 58345701 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92686929 92686933 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80546260 80546263 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92722957 92722954 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68687122 68687124 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80547649 80547651 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92677868 92677870 2 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46395838 46395837 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46492222 46492221 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58255275 58255276 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58257512 58257513 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80560698 80560697 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80671125 80671126 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92716725 92716724 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58239129 58239129 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42258634 42258634 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4236339 4236339 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41708906 41708906 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41723142 41723142 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563586 2563586 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4216069 4216069 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43964094 43964094 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42244157 42244157 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41811852 41811852 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41798122 41798122 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3873595 3873595 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3878043 3878043 0 (0.00%) 2.24%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43874661 43874661 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43311749 43311749 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5001844 5001844 0 (0.00%) 1.65%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43311726 43311726 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4497243 4497243 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4237990 4237990 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2662010 2662010 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42170363 42170363 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41797616 41797616 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43967451 43967451 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7617132 7617132 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43199003 43199003 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11475373 11475373 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43201896 43201896 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11291757 11291757 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4681887 4681887 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42170889 42170889 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2656167 2656167 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35183056 35183056 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43201919 43201919 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43874662 43874662 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43871304 43871304 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11481352 11481352 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42184840 42184840 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41709412 41709412 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43308833 43308833 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43967452 43967452 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42244599 42244599 0 (0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.40 ms 1.09 ms ✅ -0.31 ms (-22.20%) 4.15%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.43 ms 1.12 ms ✅ -0.31 ms (-21.74%) 4.08%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.42 ms 1.12 ms ✅ -0.30 ms (-21.05%) 4.67%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.95 ms 1.63 ms ✅ -0.32 ms (-16.31%) 4.81%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.11 ms 1.81 ms ✅ -0.30 ms (-14.26%) 4.17%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.46 ms 5.10 ms ✅ -0.36 ms (-6.62%) 5.01%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.49 ms 5.12 ms ✅ -0.36 ms (-6.60%) 3.85%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.57 ms 5.27 ms ✅ -0.30 ms (-5.43%) 2.53%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.55 ms 5.26 ms ✅ -0.29 ms (-5.25%) 2.27%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.89 ms 5.60 ms ✅ -0.29 ms (-4.91%) 2.83%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.90 ms 5.62 ms ✅ -0.28 ms (-4.80%) 2.29%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.93 ms 13.60 ms ✅ -0.33 ms (-2.37%) 1.74%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.49 ms 4.44 ms -0.05 ms (-1.09%) 3.91%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.60 ms 6.66 ms 0.06 ms (0.95%) 1.02%
handshake_tickets_ring_1.3_rsa_chacha 7.08 ms 7.15 ms 0.07 ms (0.95%) 1.23%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.20 ms 5.16 ms -0.05 ms (-0.88%) 2.77%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.49 ms 6.55 ms 0.06 ms (0.85%) 1.16%
handshake_tickets_ring_1.3_ecdsap256_aes 6.65 ms 6.71 ms 0.06 ms (0.85%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.98 ms 7.03 ms 0.06 ms (0.79%) 1.40%
transfer_no_resume_ring_1.3_rsa_aes 6.84 ms 6.78 ms -0.05 ms (-0.79%) 3.10%
handshake_session_id_ring_1.3_ecdsap256_aes 6.53 ms 6.58 ms 0.05 ms (0.78%) 1.15%
handshake_tickets_ring_1.3_rsa_aes 7.14 ms 7.19 ms 0.05 ms (0.73%) 1.16%
handshake_session_id_ring_1.3_rsa_aes 7.03 ms 7.08 ms 0.05 ms (0.72%) 1.29%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.68 ms 9.74 ms 0.06 ms (0.67%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.57 ms 9.63 ms 0.06 ms (0.62%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.73 ms 9.79 ms 0.05 ms (0.55%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.61 ms 9.66 ms 0.05 ms (0.48%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 461.76 µs 459.58 µs -2.17 µs (-0.47%) 2.98%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.17 ms 1.18 ms 0.01 ms (0.46%) 1.62%
handshake_tickets_ring_1.2_rsa_aes 1.59 ms 1.60 ms 0.01 ms (0.36%) 2.36%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.62 ms 5.64 ms 0.02 ms (0.36%) 2.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.17 ms 1.18 ms 0.00 ms (0.36%) 1.80%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.95 ms 12.91 ms -0.04 ms (-0.28%) 1.21%
transfer_no_resume_ring_1.3_rsa_chacha 13.47 ms 13.44 ms -0.04 ms (-0.27%) 1.52%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.57 ms 4.59 ms 0.01 ms (0.26%) 2.32%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.97 ms 12.94 ms -0.03 ms (-0.24%) 1.27%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.91 ms 4.92 ms 0.01 ms (0.23%) 2.78%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.62 ms 5.64 ms 0.01 ms (0.23%) 2.11%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.29 ms 5.31 ms 0.01 ms (0.23%) 1.94%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 459.26 µs 458.24 µs -1.03 µs (-0.22%) 3.08%
handshake_session_id_ring_1.2_rsa_aes 1.51 ms 1.52 ms 0.00 ms (0.21%) 2.13%
transfer_no_resume_ring_1.2_rsa_aes 6.76 ms 6.74 ms -0.01 ms (-0.21%) 2.30%
handshake_no_resume_ring_1.3_ecdsap256_aes 504.58 µs 503.56 µs -1.02 µs (-0.20%) 2.74%
handshake_no_resume_ring_1.3_ecdsap256_chacha 501.14 µs 500.23 µs -0.91 µs (-0.18%) 2.40%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.67 ms 13.64 ms -0.02 ms (-0.18%) 1.24%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.07 ms 16.05 ms -0.03 ms (-0.18%) 1.06%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.34 ms 6.33 ms -0.01 ms (-0.14%) 2.59%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.44 ms 9.42 ms -0.01 ms (-0.13%) 1.88%
handshake_no_resume_ring_1.3_rsa_aes 995.19 µs 994.11 µs -1.09 µs (-0.11%) 1.11%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms -0.00 ms (-0.10%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 991.41 µs 990.47 µs -0.94 µs (-0.09%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.28 ms 5.28 ms 0.00 ms (0.06%) 1.64%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.92 ms 4.92 ms -0.00 ms (-0.05%) 2.49%
handshake_no_resume_ring_1.3_rsa_chacha 995.60 µs 995.14 µs -0.47 µs (-0.05%) 1.10%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.57 ms 4.57 ms -0.00 ms (-0.01%) 2.29%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms -0.00 ms (-0.01%) 1.00%

Additional information

Historical results

Checkout details:

8000
@ctz
Copy link
Member Author
ctz commented Oct 4, 2024

⚠️ There are significant wall-time differences

Sweet. This is the faster RSA impl using AVX512.

@codecov Codecov
Copy link
codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (0560938) to head (31f0c59).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2147   +/-   ##
=======================================
  Coverage   94.66%   94.66%           
=======================================
  Files         102      102           
  Lines       23434    23435    +1     
=======================================
+ Hits        22183    22184    +1     
  Misses       1251     1251

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

djc
djc approved these changes Oct 4, 2024
View reviewed changes
Cargo.lock Outdated
@@ -1435,7 +1435,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "4979f22fdb869068da03c9f7528f8297c6fd2606bc3a4affe42e6a823fdb8da4"
dependencies = [
"cfg-if",
"windows-targets 0.52.6",
"windows-targets 0.48.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what caused this...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, very odd. Seems deterministic for cargo update -p aws-lc-rs. If I do an unconstrained cargo update it doesn't happen. It seems to be a result of accidentally keeping back aws-lc-fips-sys -- folded into this commit.

@ctz ctz force-pushed the jbp-aws-lc-rs-1.10 branch from 5caaeb0 to 31f0c59 Compare October 4, 2024 08:27
@ctz ctz enabled auto-merge October 4, 2024 08:30
@ctz ctz added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit 262ae99 Oct 4, 2024
60 checks passed
@ctz ctz deleted the jbp-aws-lc-rs-1.10 branch October 4, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctz @djc
0