8000 Prepare 0.23.14 by ctz · Pull Request #2149 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Prepare 0.23.14 #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2024
Merged

Prepare 0.23.14 #2149

merged 1 commit into from
Oct 4, 2024

Conversation

ctz
Copy link
Member
@ctz ctz commented Oct 4, 2024

The main reason for this release is cutting a release that contains the minor perf improvements, for publishing benchmarks against aws-lc-rs 1.10. nb. this release does not require 1.10; there is not currently a need for that.

Draft release notes:

  • Breaking change for no_std users: The return type of CryptoProvider::install_default() would change depending on the std crate feature. This was unintended and is corrected in this release. But that does mean this semver-compatible release contains a breaking API change, albeit only for users who omit the std crate feature. Our apologies in advance.
  • Performance improvements especially for servers doing a full TLS1.3 handshake, and clients doing a resumed TLS1.2 handshake.
  • Improvements to example code: demonstrate usage of TLS1.3 early data (thanks to @tahmid-23) & using clap for CLI.

@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Oct 4, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8616166 8576918 -39248 (-0.46%) 0.56%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8593616 8621808 28192 (0.33%) 1.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10470820 10438376 -32444 (-0.31%) 0.84%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1671762 1667388 -4374 (-0.26%) 1.03%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10783865 10802952 19087 (0.18%) 1.15%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10816622 10803368 -13254 (-0.12%) 1.03%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3629169 3624932 -4237 (-0.12%) 0.44%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3627793 3625806 -1987 (-0.05%) 0.43%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3085365 3086837 1472 (0.05%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2175485 2175237 -248 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3084463 3084806 343 (0.01%) 0.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1281706 1281616 -90 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1283969 1283883 -86 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932572 1932603 31 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58258155 58257516 -639 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32080231 32079915 -316 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925851 1925866 15 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34138703 34138966 263 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30725866 30725712 -154 (-0.00%) 0.33%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30348300 30348189 -111 (-0.00%) 0.29%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34144507 34144389 -118 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2178389 2178396 7 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30312057 30311965 -92 (-0.00%) 0.25%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30347724 30347638 -86 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30725592 30725677 85 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34144628 34144535 -93 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30311624 30311544 -80 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30782284 30782359 75 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32132923 32132852 -71 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30362127 30362065 -62 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32133032 32132978 -54 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30326082 30326038 -44 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30759766 30759737 -29 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34135773 34135743 -30 (-0.00%) 0.22%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34138325 34138354 29 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32080127 32080101 -26 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32130102 32130125 23 (0.00%) 0.45%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30759923 30759906 -17 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32076991 32076975 -16 (-0.00%) 0.22%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35183056 35183041 -15 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7617132 7617129 -3 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30748288 30748280 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46492224 46492213 -11 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58255284 58255275 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46485850 46485857 7 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46395839 46395833 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46476508 46476502 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58345701 58345708 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68687126 68687119 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80646206 80646213 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92677861 92677869 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92686936 92686928 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58352846 58352851 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80546264 80546258 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58239129 58239133 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92716723 92716718 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92718955 92718960 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58260234 58260231 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46452472 46452470 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80560694 80560691 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80671131 80671128 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46464443 46464444 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46479169 46479168 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46489371 46489372 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58356603 58356604 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80547651 80547650 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92722951 92722950 -1 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43201919 43201919 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41811852 41811852 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42244157 42244157 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43967451 43967451 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41709412 41709412 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43871304 43871304 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1670352 1670352 0 (0.00%) 1.03%
handshake_tickets_ring_1.2_rsa_aes_client 4497243 4497243 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4237990 4237990 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43199003 43199003 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43311749 43311749 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11475373 11475373 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42170363 42170363 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2656167 2656167 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43874662 43874662 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5001844 5001844 0 (0.00%) 1.65%
transfer_no_resume_ring_1.3_rsa_chacha_client 92688771 92688771 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35184964 35184964 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41798122 41798122 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43967452 43967452 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43308833 43308833 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42184840 42184840 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717523 1717523 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43964094 43964094 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34141618 34141618 0 (0.00%) 0.21%
handshake_tickets_ring_1.2_rsa_aes_server 4681887 4681887 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43311726 43311726 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11291757 11291757 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42170889 42170889 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4216069 4216069 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80667613 80667613 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11481352 11481352 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2662010 2662010 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41723142 41723142 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41708906 41708906 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3878043 3878043 0 (0.00%) 2.24%
handshake_session_id_ring_1.2_rsa_aes_client 4236339 4236339 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563586 2563586 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3873595 3873595 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43874661 43874661 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41797616 41797616 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42258634 42258634 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43201896 43201896 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7619309 7619309 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42244599 42244599 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.51 ms 4.53 ms 0.02 ms (0.53%) 5.65%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.18 ms 5.21 ms 0.03 ms (0.50%) 5.23%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.93 ms 4.95 ms 0.02 ms (0.46%) 2.57%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 461.26 µs 463.19 µs 1.93 µs (0.42%) 3.08%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.23 ms 5.25 ms 0.02 ms (0.38%) 4.52%
transfer_no_resume_ring_1.3_rsa_aes 6.86 ms 6.89 ms 0.02 ms (0.36%) 3.84%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.60 ms 0.01 ms (0.32%) 2.41%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.64 ms 5.66 ms 0.02 ms (0.31%) 2.11%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.40 ms 6.42 ms 0.02 ms (0.31%) 2.59%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.20 ms 5.22 ms 0.02 ms (0.30%) 4.76%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.62 ms 5.64 ms 0.02 ms (0.30%) 3.04%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.58 ms 4.59 ms 0.01 ms (0.28%) 2.31%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.49 ms 9.52 ms 0.03 ms (0.27%) 1.88%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.29 ms 5.31 ms 0.01 ms (0.26%) 1.85%
handshake_no_resume_ring_1.3_ecdsap256_chacha 503.52 µs 504.84 µs 1.32 µs (0.26%) 2.40%
transfer_no_resume_ring_1.2_rsa_aes 6.82 ms 6.84 ms 0.02 ms (0.25%) 2.30%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms 0.00 ms (0.25%) 2.14%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.28 ms 5.29 ms 0.01 ms (0.25%) 2.31%
handshake_no_resume_ring_1.3_ecdsap256_aes 507.31 µs 508.43 µs 1.13 µs (0.22%) 2.78%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.63 ms 1.63 ms -0.00 ms (-0.22%) 5.15%
transfer_no_resume_ring_1.3_rsa_chacha 13.51 ms 13.54 ms 0.03 ms (0.19%) 1.52%
handshake_session_id_ring_1.3_rsa_chacha 7.03 ms 7.04 ms 0.01 ms (0.19%) 1.45%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.13 ms 1.13 ms 0.00 ms (0.19%) 8.60%
handshake_session_id_ring_1.3_ecdsap256_aes 6.58 ms 6.59 ms 0.01 ms (0.19%) 1.63%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.71 ms 13.73 ms 0.03 ms (0.18%) 1.60%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.60 ms 4.61 ms 0.01 ms (0.17%) 2.33%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.67 ms 13.70 ms 0.02 ms (0.16%) 1.84%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 464.35 µs 465.10 µs 0.76 µs (0.16%) 3.01%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.32 ms 5.32 ms 0.01 ms (0.16%) 1.98%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.02 ms 13.04 ms 0.02 ms (0.16%) 1.56%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.99 ms 13.01 ms 0.02 ms (0.16%) 1.72%
handshake_tickets_ring_1.3_ecdsap256_aes 6.70 ms 6.71 ms 0.01 ms (0.16%) 1.01%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.13 ms 1.13 ms 0.00 ms (0.15%) 9.26%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.28 ms 5.29 ms 0.01 ms (0.15%) 2.80%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.11 ms 16.13 ms 0.02 ms (0.15%) 1.30%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.09 ms 1.09 ms 0.00 ms (0.14%) 4.56%
handshake_session_id_ring_1.3_rsa_aes 7.07 ms 7.08 ms 0.01 ms (0.14%) 1.46%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.93 ms 4.94 ms 0.01 ms (0.13%) 2.85%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.66 ms 6.67 ms 0.01 ms (0.12%) 1.18%
handshake_no_resume_ring_1.3_rsa_chacha 997.91 µs 999.01 µs 1.10 µs (0.11%) 1.10%
handshake_no_resume_ring_1.2_rsa_aes 993.21 µs 994.24 µs 1.03 µs (0.10%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.65 ms 9.66 ms 0.01 ms (0.10%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 997.82 µs 998.80 µs 0.99 µs (0.10%) 1.11%
handshake_tickets_ring_1.3_rsa_aes 7.19 ms 7.20 ms 0.01 ms (0.09%) 1.41%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms 0.00 ms (0.09%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms 0.00 ms (0.08%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms 0.00 ms (0.08%) 1.62%
handshake_tickets_ring_1.3_rsa_chacha 7.15 ms 7.16 ms 0.00 ms (0.07%) 1.35%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.61 ms 5.61 ms 0.00 ms (0.06%) 2.84%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.55 ms 6.55 ms 0.00 ms (0.06%) 1.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.18 ms -0.00 ms (-0.05%) 1.80%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.62 ms 9.63 ms 0.01 ms (0.05%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.78 ms 9.78 ms 0.00 ms (0.05%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.74 ms 9.74 ms 0.00 ms (0.03%) 1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.81 ms 1.81 ms -0.00 ms (-0.02%) 5.06%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.65 ms 5.65 ms 0.00 ms (0.01%) 2.30%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link
codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (262ae99) to head (c84e558).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2149   +/-   ##
=======================================
  Coverage   94.66%   94.66%           
=======================================
  Files         102      102           
  Lines       23435    23435           
=======================================
  Hits        22184    22184           
  Misses       1251     1251

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cpu
cpu approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member
@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting :-)

@ctz ctz added this pull request to the merge queue Oct 4, 2024
Merged via the queue into main with commit cf736e3 Oct 4, 2024
62 checks passed
@ctz ctz deleted the jbp-prepare-0.23.14 branch October 4, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu
0