8000 Migrate to pki-types PEM decoder by ctz · Pull Request #2140 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Migrate to pki-types PEM decoder #2140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 1, 2024
Merged

Migrate to pki-types PEM decoder #2140

merged 5 commits into from
Oct 1, 2024

Conversation

ctz
Copy link
Member
@ctz ctz commented Sep 30, 2024

This reworks all the test and example code we have to use the new pki-types PEM decoding.

Generally this went smoothly, and I'm very pleased that quite a lot of boilerplate fell away. We might want to impl std::error::Error on pem::Error?

@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Sep 30, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2170718 2176743 ⚠️ 6025 (0.28%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2167798 2173720 ⚠️ 5922 (0.27%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10489294 10453666 -35628 (-0.34%) 0.71%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1665961 1670295 4334 (0.26%) 0.29%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10801945 10828699 26754 (0.25%) 1.02%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8598462 8617877 19415 (0.23%) 1.04%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3635343 3629253 -6090 (-0.17%) 0.46%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3092117 3087117 -5000 (-0.16%) 0.22%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3090095 3085227 -4868 (-0.16%) 0.25%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8579823 8573105 -6718 (-0.08%) 0.77%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7613306 7619228 5922 (0.08%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7611153 7617072 5919 (0.08%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3629421 3627763 -1658 (-0.05%) 0.43%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58247550 58255280 7730 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58346583 58352846 6263 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1283535 1283649 114 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92678998 92686937 7939 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92708992 92716725 7733 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35182541 35185008 2467 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35180633 35183085 2452 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717605 1717711 106 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46462190 46464442 2252 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1281305 1281363 58 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46487393 46489371 1978 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46477194 46479169 1975 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58347533 58345700 -1833 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80543967 80546259 2292 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80643956 80646213 2257 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80545675 80547652 1977 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80669149 80671126 1977 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92679701 92677869 -1832 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32076339 32076729 390 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32129655 32130015 360 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30350506 30350761 255 (0.00%) 0.59%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46476121 46476506 385 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30785145 30784897 -248 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30762470 30762696 226 (0.00%) 0.25%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32129400 32129628 228 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30728195 30728404 209 (0.00%) 0.40%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30728304 30728477 173 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58257221 58257516 295 (0.00%) 0.22%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30314903 30314752 -151 (-0.00%) 0.53%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34142095 34141925 -170 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34136330 34136187 -143 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30364629 30364749 120 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1671675 1671681 6 (0.00%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32126553 32126442 -111 (-0.00%) 0.50%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34142225 34142111 -114 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34135980 34136088 108 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92718667 92718953 286 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32076716 32076621 -95 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32073546 32073640 94 (0.00%) 0.43%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30314490 30314414 -76 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30762489 30762564 75 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925944 1925948 4 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30750785 30750843 58 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34139255 34139201 -54 (-0.00%) 0.51%
handshake_no_resume_ring_1.2_rsa_aes_client 2563608 2563612 4 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932672 1932669 -3 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30328889 30328842 -47 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2656165 2656169 4 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2662008 2662012 4 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43198536 43198596 60 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43306206 43306266 60 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43871182 43871242 60 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43961812 43961872 60 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10794279 10794267 -12 (-0.00%) 0.82%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30350221 30350203 -18 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42172781 42172801 20 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42246575 42246595 20 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42173277 42173289 12 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 8000 42246987 42246999 12 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46439671 46439680 9 (0.00%) 0.23%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41711804 41711812 8 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41800514 41800522 8 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41711352 41711356 4 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41800062 41800066 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58260235 58260240 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68688407 68688402 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80667617 80667612 -5 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34133234 34133232 -2 (-0.00%) 0.50%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92722957 92722953 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92688768 92688771 3 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46395837 46395836 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46492223 46492222 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58239130 58239129 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80560693 80560694 1 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41814292 41814292 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4217479 4217479 0 (0.00%) 0.21%
handshake_session_id_ring_1.3_rsa_chacha_client 41725582 41725582 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4498503 4498503 0 (0.00%) 0.22%
handshake_session_id_ring_1.2_rsa_aes_client 4237779 4237779 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46484576 46484576 0 (0.00%) 0.22%
handshake_tickets_ring_1.3_rsa_aes_client 42261062 42261062 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3875185 3875185 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43958514 43958514 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4238740 4238740 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43198619 43198619 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11475316 11475316 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43303373 43303373 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42187268 42187268 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43195703 43195703 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5002684 5002684 0 (0.00%) 4.98%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43871241 43871241 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43961871 43961871 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3878943 3878943 0 (0.00%) 2.48%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43306289 43306289 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58356602 58356602 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11291888 11291888 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4682697 4682697 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43867884 43867884 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11481271 11481271 0 (0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_ring_1.3_rsa_aes 983.07 µs 995.91 µs ⚠️ 12.84 µs (1.31%) 1.11%
handshake_no_resume_ring_1.3_rsa_chacha 983.05 µs 995.86 µs ⚠️ 12.81 µs (1.30%) 1.12%
handshake_no_resume_ring_1.2_rsa_aes 977.78 µs 990.50 µs ⚠️ 12.72 µs (1.30%) 1.13%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.37 ms 1.40 ms 0.03 ms (2.26%) 3.04%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.39 ms 1.42 ms 0.03 ms (2.22%) 2.97%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.40 ms 1.43 ms 0.03 ms (2.03%) 2.40%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.08 ms 2.11 ms 0.03 ms (1.55%) 2.55%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.91 ms 1.94 ms 0.02 ms (1.27%) 2.83%
handshake_no_resume_ring_1.3_ecdsap256_aes 501.75 µs 506.10 µs 4.35 µs (0.87%) 2.94%
handshake_session_id_ring_1.2_rsa_aes 1.51 ms 1.52 ms 0.01 ms (0.74%) 2.18%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 460.76 µs 463.50 µs 2.74 µs (0.59%) 2.88%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.87 ms 5.90 ms 0.03 ms (0.58%) 2.87%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.89 ms 5.91 ms 0.03 ms (0.44%) 2.29%
handshake_no_resume_ring_1.3_ecdsap256_chacha 499.31 µs 501.29 µs 1.98 µs (0.40%) 2.77%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.50 ms 4.49 ms -0.01 ms (-0.33%) 5.72%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.23 ms 5.21 ms -0.02 ms (-0.33%) 4.93%
handshake_session_id_ring_1.3_ecdsap256_aes 6.54 ms 6.52 ms -0.02 ms (-0.31%) 1.70%
handshake_session_id_ring_1.3_ecdsap384_aes 9.63 ms 9.61 ms -0.03 ms (-0.28%) 1.08%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.55 ms 5.56 ms 0.01 ms (0.26%) 2.27%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.51 ms 6.49 ms -0.02 ms (-0.26%) 1.43%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.46 ms 5.47 ms 0.01 ms (0.25%) 5.29%
handshake_tickets_ring_1.3_ecdsap256_aes 6.66 ms 6.64 ms -0.02 ms (-0.25%) 1.07%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.56 ms 5.58 ms 0.01 ms (0.25%) 2.67%
handshake_tickets_ring_1.3_ecdsap384_aes 9.74 ms 9.72 ms -0.02 ms (-0.24%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.30 ms 5.29 ms -0.01 ms (-0.24%) 2.09%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.91 ms 4.92 ms 0.01 ms (0.24%) 2.69%
handshake_tickets_ring_1.2_rsa_aes 1.59 ms 1.59 ms 0.00 ms (0.24%) 2.19%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.61 ms 4.60 ms -0.01 ms (-0.23%) 2.43%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.98 ms 12.95 ms -0.03 ms (-0.22%) 1.83%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.36 ms 6.34 ms -0.01 ms (-0.22%) 3.96%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 458.42 µs 459.38 µs 0.96 µs (0.21%) 3.28%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.32 ms 5.31 ms -0.01 ms (-0.19%) 1.94%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.70 ms 13.67 ms -0.03 ms (-0.19%) 1.85%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.59 ms 9.57 ms -0.02 ms (-0.18%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 7.03 ms 7.02 ms -0.01 ms (-0.16%) 1.54%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.70 ms 9.68 ms -0.01 ms (-0.15%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.99 ms 6.98 ms -0.01 ms (-0.15%) 1.46%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.46 ms 9.44 ms -0.01 ms (-0.14%) 2.69%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.61 ms 6.60 ms -0.01 ms (-0.13%) 1.40%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.60 ms 4.59 ms -0.01 ms (-0.12%) 2.23%
transfer_no_resume_ring_1.3_rsa_chacha 13.48 ms 13.49 ms 0.01 ms (0.10%) 1.81%
handshake_tickets_ring_1.3_rsa_aes 7.14 ms 7.14 ms -0.01 ms (-0.09%) 1.31%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.63 ms 5.64 ms 0.00 ms (0.08%) 2.24%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.00 ms 12.99 ms -0.01 ms (-0.07%) 1.84%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms 0.00 ms (0.07%) 1.00%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.48 ms 5.48 ms 0.00 ms (0.06%) 4.76%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.64 ms 5.64 ms -0.00 ms (-0.06%) 2.11%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.17 ms 1.17 ms -0.00 ms (-0.05%) 1.64%
transfer_no_resume_ring_1.3_rsa_aes 6.84 ms 6.84 ms 0.00 ms (0.05%) 3.86%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.10 ms 16.09 ms -0.01 ms (-0.04%) 1.69%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.17 ms 1.17 ms 0.00 ms (0.03%) 1.60%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.93 ms 13.93 ms -0.00 ms (-0.02%) 1.84%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms -0.00 ms (-0.01%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.93 ms 4.93 ms 0.00 ms (0.01%) 2.34%
transfer_no_resume_ring_1.2_rsa_aes 6.76 ms 6.76 ms 0.00 ms (0.01%) 3.29%
handshake_tickets_ring_1.3_rsa_chacha 7.09 ms 7.09 ms 0.00 ms (0.00%) 1.25%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link
codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.63%. Comparing base (df96abd) to head (4f9f644).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2140      +/-   ##
==========================================
- Coverage   94.64%   94.63%   -0.01%     
==========================================
  Files         102      102              
  Lines       23416    23400      -16     
==========================================
- Hits        22161    22145      -16     
  Misses       1255     1255

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cpu
cpu reviewed Sep 30, 2024
View reviewed changes
Copy link
Member
@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :-)

djc
djc approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member
@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Net -100 lines is a good deal!

@ctz ctz force-pushed the jbp-remove-pemfile branch from 4e66781 to 4f9f644 Compare October 1, 2024 16:55
@ctz ctz enabled auto-merge October 1, 2024 16:57
@ctz ctz added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit ce10e59 Oct 1, 2024
60 checks passed
@ctz ctz deleted the jbp-remove-pemfile branch October 1, 2024 17:25
@cpu cpu mentioned this pull request Oct 7, 2024
Closed
@cpu cpu mentioned this pull request Oct 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu
0