8000 Improve receive performance by ctz · Pull Request #2155 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve receive performance #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 15, 2024
Merged

Improve receive performance #2155

merged 8 commits into from
Oct 15, 2024

Conversation

ctz
Copy link
Member
@ctz ctz commented Oct 15, 2024

When reading from a ChunkVecBuffer we Vec::drain() the read bytes. That involves a memmove of the unread bytes, and that is both expensive and avoidable.

A couple of unrelated nits coming along for the ride.

fixes #2154

ctz added 4 commits October 14, 2024 16:38
@ctz
compress: remove 'pub' from 'mod tests'
3d5adae 
Triggers a `missing_docs` warning on nightly.
@ctz
ticketer: fix warning for release builds
85c8a25
@ctz
bench: ensure maximal-sized plaintext reads
d51eda8
@ctz
bench: use vec for temporary buffers
9259adb 
I guess that a zeroed vec is cheaper because
the allocator can back it with mmap, whereas the stack
region would need to be zeroed.
@ctz ctz changed the title Jbp improve receive speed Improve receive performance Oct 15, 2024
@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Oct 15, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1283890 1280328 ✅ -3562 (-0.28%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1281623 1278141 ✅ -3482 (-0.27%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10850657 10812570 -38087 (-0.35%) 1.17%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10831789 10854984 23195 (0.21%) 1.09%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1667388 1663907 -3481 (-0.21%) 1.05%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3621465 3625418 3953 (0.11%) 0.32%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8584178 8593024 8846 (0.10%) 1.25%
handshake_tickets_ring_1.2_rsa_aes_server 4681887 4678423 -3464 (-0.07%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5001844 4998335 -3509 (-0.07%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3622793 3625060 2267 (0.06%) 0.31%
handshake_session_id_ring_1.2_rsa_aes_server 4237990 4235449 -2541 (-0.06%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3082218 3084065 1847 (0.06%) 0.31%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1665988 1666895 907 (0.05%) 1.04%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46489369 46467124 -22245 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3878043 3876261 -1782 (-0.05%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10470832 10475641 4809 (0.05%) 1.67%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80671119 80648881 -22238 (-0.03%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4236339 4235199 -1140 (-0.03%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4497243 4496133 -1110 (-0.02%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46479175 46467812 -11363 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8604551 8606103 1552 (0.02%) 0.71%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80547653 80535651 -12002 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46452481 46446231 -6250 (-0.01%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46395836 46389596 -6240 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46476497 46470681 -5816 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46485858 46480090 -5768 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46492222 46487102 -5120 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3873595 3873175 -420 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3086805 3087132 327 (0.01%) 0.30%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43967451 43962869 -4582 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43311749 43307237 -4512 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43967452 43962909 -4543 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43311726 43307256 -4470 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43964094 43959794 -4300 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43308833 43304599 -4234 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30759964 30757099 -2865 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46464443 46460144 -4299 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4216069 4215679 -390 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30748119 30745410 -2709 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30759957 30757279 -2678 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30725625 30723003 -2622 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30725760 30723202 -2558 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30348175 30345726 -2449 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30782241 30779773 -2468 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30326002 30323635 -2367 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32080069 32077633 -2436 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30311985 30309703 -2282 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717523 1717397 -126 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30311401 30309188 -2213 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41798122 41795074 -3048 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30361920 30359726 -2194 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41811852 41808832 -3020 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32133141 32130822 -2319 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80546262 80540451 -5811 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41797616 41794608 -3008 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30347528 30345349 -2179 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80560688 80554937 -5751 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80667612 80661854 -5758 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58345709 58341600 -4109 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58260231 58256134 -4097 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58352847 58348746 -4101 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32076899 32074645 -2254 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58356605 58352513 -4092 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32132966 32130720 -2246 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32129836 32127631 -2205 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32079895 32077703 -2192 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42258634 42255758 -2876 (-0.01%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58239131 58235170 -3961 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42244157 42241293 -2864 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42244599 42241863 -2736 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2178374 2178235 -139 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80646207 80641256 -4951 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58255285 58251815 -3470 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58257515 58254051 -3464 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41709412 41707084 -2328 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42170889 42168561 -2328 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43874661 43872239 -2422 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41723142 41720842 -2300 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41708906 41706618 -2288 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42184840 42182528 -2312 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42170363 42168063 -2300 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43201919 43199567 -2352 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43874662 43872279 -2383 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43201896 43199586 -2310 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43871304 43869164 -2140 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68687122 68683807 -3315 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43199003 43196929 -2074 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92688764 92684662 -4102 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92718956 92714855 -4101 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92722950 92718849 -4101 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92686931 92682837 -4094 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92716715 92712621 -4094 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92677862 92673770 -4092 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925844 1925770 -74 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932572 1932498 -74 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563586 2563491 -95 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34135798 34134710 -1088 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34141541 34140560 -981 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2175277 2175215 -62 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7619329 7619175 -154 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2656167 2656121 -46 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7617132 7617002 -130 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34138632 34138066 -566 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34144588 34144082 -506 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34138542 34138152 -390 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2662010 2661986 -24 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34144391 34144084 -307 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11481352 11481252 -100 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11475373 11475297 -76 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11291757 11291823 66 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35183056 35183008 -48 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35184991 35184965 -26 (-0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.13 ms 1.08 ms ✅ -0.04 ms (-3.95%) 3.33%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.13 ms 1.09 ms ✅ -0.04 ms (-3.51%) 2.40%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.09 ms 1.05 ms -0.04 ms (-3.60%) 3.72%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.81 ms 1.75 ms -0.06 ms (-3.45%) 4.99%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.64 ms 1.58 ms -0.05 ms (-3.29%) 4.78%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.22 ms 5.11 ms -0.11 ms (-2.08%) 4.78%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.22 ms 5.14 ms -0.08 ms (-1.62%) 4.56%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.28 ms 5.20 ms -0.08 ms (-1.60%) 2.42%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.54 ms 4.47 ms -0.07 ms (-1.54%) 6.04%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.62 ms 5.54 ms -0.08 ms (-1.41%) 2.38%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.28 ms 5.21 ms -0.07 ms (-1.35%) 2.07%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.60 ms 5.53 ms -0.07 ms (-1.33%) 2.67%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.27 ms 5.21 ms -0.06 ms (-1.20%) 5.15%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 463.76 µs 459.52 µs -4.25 µs (-0.92%) 4.35%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 461.95 µs 457.96 µs -3.99 µs (-0.86%) 4.08%
handshake_no_resume_ring_1.3_ecdsap256_aes 508.47 µs 504.15 µs -4.32 µs (-0.85%) 3.39%
handshake_no_resume_ring_1.3_ecdsap256_chacha 504.45 µs 500.30 µs -4.15 µs (-0.82%) 2.65%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.93 ms 4.89 ms -0.04 ms (-0.81%) 2.42%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.60 ms 4.57 ms -0.03 ms (-0.72%) 1.85%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.93 ms 4.89 ms -0.04 ms (-0.71%) 2.38%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.67 ms 13.58 ms -0.09 ms (-0.67%) 2.08%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.64 ms 5.61 ms -0.04 ms (-0.65%) 2.15%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.32 ms 5.28 ms -0.03 ms (-0.64%) 2.03%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.58 ms 4.55 ms -0.03 ms (-0.57%) 1.78%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.29 ms 5.26 ms -0.03 ms (-0.54%) 1.67%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.64 ms 5.61 ms -0.03 ms (-0.53%) 2.04%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.67 ms 6.63 ms -0.03 ms (-0.48%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 7.05 ms 7.01 ms -0.03 ms (-0.47%) 1.46%
handshake_tickets_ring_1.3_rsa_chacha 7.15 ms 7.12 ms -0.03 ms (-0.44%) 1.03%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.55 ms 6.52 ms -0.03 ms (-0.42%) 1.13%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.59 ms -0.01 ms (-0.41%) 2.41%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms -0.01 ms (-0.36%) 2.74%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.39 ms 6.37 ms -0.02 ms (-0.33%) 3.91%
handshake_session_id_ring_1.3_ecdsap256_aes 6.59 ms 6.57 ms -0.02 ms (-0.31%) 1.04%
handshake_tickets_ring_1.3_ecdsap256_aes 6.71 ms 6.69 ms -0.02 ms (-0.31%) 1.01%
handshake_no_resume_ring_1.3_rsa_chacha 999.35 µs 996.37 µs -2.98 µs (-0.30%) 1.62%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.63 ms 9.60 ms -0.03 ms (-0.28%) 1.00%
transfer_no_resume_ring_1.3_rsa_chacha 13.51 ms 13.47 ms -0.04 ms (-0.28%) 1.91%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.98 ms 12.94 ms -0.03 ms (-0.27%) 2.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.74 ms 9.72 ms -0.03 ms (-0.27%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 7.20 ms 7.18 ms -0.02 ms (-0.24%) 1.53%
transfer_no_resume_ring_1.2_rsa_aes 6.81 ms 6.79 ms -0.02 ms (-0.23%) 3.46%
handshake_session_id_ring_1.3_rsa_aes 7.09 ms 7.07 ms -0.02 ms (-0.23%) 1.05%
handshake_no_resume_ring_1.2_rsa_aes 994.32 µs 992.08 µs -2.24 µs (-0.22%) 1.13%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.01 ms 12.98 ms -0.03 ms (-0.22%) 1.88%
handshake_tickets_ring_1.3_ecdsap384_aes 9.79 ms 9.77 ms -0.02 ms (-0.19%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.48 ms 9.47 ms -0.02 ms (-0.19%) 2.45%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.70 ms 13.67 ms -0.03 ms (-0.18%) 2.03%
handshake_session_id_ring_1.3_ecdsap384_aes 9.67 ms 9.65 ms -0.02 ms (-0.17%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.10 ms 16.07 ms -0.02 ms (-0.15%) 1.62%
handshake_no_resume_ring_1.3_rsa_aes 998.42 µs 997.41 µs -1.01 µs (-0.10%) 1.32%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms 0.00 ms (0.10%) 2.03%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms -0.00 ms (-0.06%) 1.00%
transfer_no_resume_ring_1.3_rsa_aes 6.86 ms 6.86 ms 0.00 ms (0.04%) 3.80%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms -0.00 ms (-0.03%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.18 ms 0.00 ms (0.01%) 1.75%

Additional information

Historical results

Checkout details:

djc
djc reviewed Oct 15, 2024
View reviewed changes
@codecov Codecov
Copy link
codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.67%. Comparing base (e2e2d9c) to head (f18a9d5).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2155   +/-   ##
=======================================
  Coverage   94.66%   94.67%           
=======================================
  Files         102      102           
  Lines       23435    23471   +36     
=======================================
+ Hits        22184    22220   +36     
  Misses       1251     1251

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctz ctz force-pushed the jbp-improve-receive-speed branch from a7c87a7 to 77d6fb6 Compare October 15, 2024 14:12
djc
djc approved these changes Oct 15, 2024
View reviewed changes
cpu
cpu approved these changes Oct 15, 2024
View reviewed changes
@ctz ctz force-pushed the jbp-improve-receive-speed branch from 77d6fb6 to f18a9d5 Compare October 15, 2024 14:27
@ctz ctz enabled auto-merge October 15, 2024 14:39
@ctz ctz added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 916494a Oct 15, 2024
60 checks passed
@ctz ctz deleted the jbp-improve-receive-speed branch October 15, 2024 15:01
@ctz ctz mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Poor asymptotic performance when reading plaintext incrementally
3 participants
@ctz @djc @cpu
0