8000 Use re-exported pki-types everywhere by djc · Pull Request #2158 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use re-exported pki-types everywhere #2158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 16, 2024
Merged

Use re-exported pki-types everywhere #2158

merged 1 commit into from
Oct 16, 2024

Conversation

djc
Copy link
Member
@djc djc commented Oct 16, 2024

No description provided.

@djc djc requested review from cpu and ctz October 16, 2024 07:32
@djc djc mentioned this pull request Oct 16, 2024
Merged
@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Oct 16, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10835525 10810605 -24920 (-0.23%) 1.09%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8596917 8608943 12026 (0.14%) 1.06%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8611659 8600453 -11206 (-0.13%) 0.71%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10820914 10808321 -12593 (-0.12%) 1.17%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10459433 10450054 -9379 (-0.09%) 1.67%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3082378 3084768 2390 (0.08%) 0.31%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3087379 3086212 -1167 (-0.04%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2178331 2178161 -170 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3623216 3623482 266 (0.01%) 0.32%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1278055 1278141 86 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1280402 1280321 -81 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58343271 58341611 -1660 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30323683 30323949 266 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30779490 30779716 226 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34143993 34143759 -234 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30345658 30345858 200 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34138136 34137961 -175 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32077759 32077620 -139 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32127672 32127809 137 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717397 1717404 7 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32130601 32130729 128 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30745381 30745502 121 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925777 1925770 -7 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932498 1932491 -7 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34144090 34143980 -110 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2175222 2175215 -7 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32077705 32077796 91 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30723045 30723123 78 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30757158 30757216 58 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7617012 7616999 -13 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34134636 34134686 50 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34137911 34137959 48 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7619155 7619145 -10 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30309171 30309207 36 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32074742 32074705 -37 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30345108 30345076 -32 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30722882 30722912 30 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30309736 30309765 29 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35183025 35182993 -32 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30757034 30757059 25 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30359775 30359799 24 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35184938 35184913 -25 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32130715 32130736 21 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34140547 34140569 22 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46467116 46467127 11 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46470681 46470692 11 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58251826 58251815 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46467804 46467812 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46487100 46487093 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58254062 58254056 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80648884 80648876 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92712624 92712615 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68683808 68683802 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58235174 58235169 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92684670 92684664 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46446232 46446229 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46460142 46460139 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641261 80641256 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661852 80661857 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80540445 80540441 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92682831 92682827 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46389591 46389589 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80554933 80554936 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92714859 92714856 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_c 8000 hacha_client 92673767 92673769 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58352513 58352512 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80535651 80535650 -1 (-0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4235449 4235449 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43872239 43872239 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43962909 43962909 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4215679 4215679 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42241293 42241293 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41794608 41794608 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11481252 11481252 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42168561 42168561 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1662531 1662531 0 (0.00%) 1.04%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42241863 42241863 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41795074 41795074 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11291823 11291823 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43869164 43869164 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41720842 41720842 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4998335 4998335 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43196929 43196929 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43199567 43199567 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43959794 43959794 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41808832 41808832 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43304599 43304599 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43962869 43962869 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4235199 4235199 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46480089 46480089 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43872279 43872279 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1663935 1663935 0 (0.00%) 1.04%
handshake_no_resume_ring_1.3_rsa_aes_server 11475297 11475297 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43307256 43307256 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41707084 41707084 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58256132 58256132 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58348747 58348747 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92718857 92718857 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3873175 3873175 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42255758 42255758 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4496133 4496133 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2661986 2661986 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41706618 41706618 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4678423 4678423 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43307237 43307237 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42168063 42168063 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3624883 3624883 0 (0.00%) 0.31%
handshake_tickets_ring_1.3_rsa_chacha_client 42182528 42182528 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2656121 2656121 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3876261 3876261 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563491 2563491 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43199586 43199586 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.09 ms 1.06 ms -0.03 ms (-2.47%) 8.23%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.43 ms 4.54 ms 0.11 ms (2.42%) 6.01%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.63 ms 1.59 ms -0.04 ms (-2.41%) 5.58%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.12 ms 1.09 ms -0.02 ms (-2.24%) 9.07%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.15 ms 5.27 ms 0.11 ms (2.15%) 4.91%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.79 ms 1.76 ms -0.04 ms (-1.97%) 5.98%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 458.56 µs 467.13 µs 8.57 µs (1.87%) 4.32%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.12 ms 1.10 ms -0.02 ms (-1.78%) 9.25%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.32 ms 6.44 ms 0.11 ms (1.74%) 3.59%
transfer_no_resume_ring_1.3_rsa_aes 6.82 ms 6.93 ms 0.11 ms (1.58%) 3.70%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.09 ms 5.17 ms 0.08 ms (1.57%) 4.92%
transfer_no_resume_ring_1.2_rsa_aes 6.75 ms 6.85 ms 0.10 ms (1.54%) 3.37%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.12 ms 5.20 ms 0.07 ms (1.42%) 4.57%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 457.61 µs 463.84 µs 6.23 µs (1.36%) 3.94%
handshake_no_resume_ring_1.3_ecdsap256_chacha 499.64 µs 505.96 µs 6.32 µs (1.27%) 2.64%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.42 ms 9.53 ms 0.11 ms (1.21%) 1.96%
handshake_no_resume_ring_1.3_ecdsap256_aes 503.98 µs 509.36 µs 5.37 µs (1.07%) 3.34%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.59 ms -0.02 ms (-1.03%) 2.36%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.19 ms 0.01 ms (0.97%) 1.53%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.90 ms 13.01 ms 0.11 ms (0.88%) 1.83%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.26 ms 5.22 ms -0.05 ms (-0.87%) 2.59%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.63 ms 13.74 ms 0.12 ms (0.85%) 1.64%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.93 ms 13.04 ms 0.11 ms (0.84%) 1.85%
transfer_no_resume_ring_1.3_rsa_chacha 13.43 ms 13.54 ms 0.11 ms (0.84%) 1.77%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.19 ms 0.01 ms (0.81%) 2.02%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.61 ms 5.56 ms -0.04 ms (-0.79%) 2.79%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.04 ms 16.14 ms 0.11 ms (0.66%) 1.32%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.89 ms 4.92 ms 0.02 ms (0.49%) 2.42%
handshake_no_resume_ring_1.3_rsa_chacha 1.00 ms 1.00 ms 0.00 ms (0.48%) 1.62%
handshake_no_resume_ring_1.2_rsa_aes 990.89 µs 995.62 µs 4.74 µs (0.48%) 1.08%
handshake_no_resume_ring_1.3_rsa_aes 1.00 ms 1.00 ms 0.00 ms (0.46%) 1.31%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.59 ms 13.65 ms 0.06 ms (0.42%) 1.95%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms -0.01 ms (-0.40%) 2.63%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.61 ms 5.63 ms 0.02 ms (0.37%) 2.21%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.26 ms 5.24 ms -0.02 ms (-0.37%) 2.39%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.58 ms 4.60 ms 0.02 ms (0.34%) 1.85%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.30 ms 5.31 ms 0.01 ms (0.25%) 2.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.54 ms 6.52 ms -0.01 ms (-0.20%) 1.13%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.57 ms 5.56 ms -0.01 ms (-0.19%) 2.48%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms 0.01 ms (0.17%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.59 ms 3.60 ms 0.01 ms (0.17%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 7.18 ms 7.19 ms 0.01 ms (0.14%) 1.53%
handshake_session_id_ring_1.3_rsa_aes 7.07 ms 7.08 ms 0.01 ms (0.10%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.65 ms 6.64 ms -0.01 ms (-0.10%) 1.15%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.58 ms 4.58 ms -0.00 ms (-0.09%) 1.82%
handshake_session_id_ring_1.3_rsa_chacha 7.02 ms 7.02 ms -0.01 ms (-0.07%) 1.40%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.61 ms 9.61 ms -0.01 ms (-0.07%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 7.14 ms 7.13 ms -0.00 ms (-0.07%) 1.03%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.62 ms 5.63 ms 0.00 ms (0.05%) 2.07%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.73 ms 9.72 ms -0.01 ms (-0.05%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.57 ms 6.58 ms 0.00 ms (0.05%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.77 ms 9.78 ms 0.00 ms (0.04%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.29 ms 5.28 ms -0.00 ms (-0.03%) 1.77%
handshake_session_id_ring_1.3_ecdsap384_aes 9.65 ms 9.66 ms 0.00 ms (0.02%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.92 ms 4.91 ms -0.00 ms (-0.01%) 2.51%
handshake_tickets_ring_1.3_ecdsap256_aes 6.70 ms 6.70 ms -0.00 ms (-0.00%) 1.01%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link
codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.67%. Comparing base (916494a) to head (7a0e126).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2158   +/-   ##
=======================================
  Coverage   94.67%   94.67%           
=======================================
  Files         102      102           
  Lines       23471    23471           
=======================================
  Hits        22220    22220           
  Misses       1251     1251

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ctz
ctz approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member
@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Needs a cargo +nightly fuzz build in fuzz/ to refresh the lockfile there.

@djc djc enabled auto-merge October 16, 2024 09:16
@djc djc added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 494f4da Oct 16, 2024
60 checks passed
@djc djc deleted the types-reexport branch October 16, 2024 09:50
@cpu
Copy link
Member
cpu commented Oct 16, 2024

Thanks for picking this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctz ctz ctz approved these changes

@cpu cpu Awaiting requested review from cpu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @cpu @ctz
0