8000 fix: renamed structs to correct naming inconsistency by hex1c · Pull Request #2152 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: renamed structs to correct naming inconsistency #2152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix: renamed structs to correct naming inconsistency #2152

merged 1 commit into from
Oct 14, 2024

Conversation

hex1c
Copy link
@hex1c hex1c commented Oct 13, 2024

Corrected the struct names in crypto/aws_lc_rs/tls13.rs that were incorrectly referred to as part of the Ring crypto library. This resolves potential confusion and ensures accuracy in the codebase.

@codecov Codecov
Copy link
codecov bot commented Oct 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.66%. Comparing base (21a5bc5) to head (0c83f43).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2152   +/-   ##
=======================================
  Coverage   94.66%   94.66%           
=======================================
  Files         102      102           
  Lines       23435    23435           
=======================================
  Hits        22184    22184           
  Misses       1251     1251

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

djc
djc approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member
@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Oct 13, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8606720 8559758 -46962 (-0.55%) 0.56%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10483193 10447589 -35604 (-0.34%) 1.24%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10830760 10801456 -29304 (-0.27%) 1.03%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8555417 8572270 16853 (0.20%) 1.11%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10800655 10808169 7514 (0.07%) 1.15%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3623414 3621374 -2040 (-0.06%) 0.32%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3086308 3086711 403 (0.01%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1281616 1281699 83 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3624780 3624894 114 (0.00%) 0.31%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1665988 1666024 36 (0.00%) 1.04%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30725995 30725466 -529 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34144711 34144291 -420 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32080249 32080020 -229 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3085126 3085148 22 (0.00%) 0.31%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34138551 34138308 -243 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2178411 2178396 -15 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30362254 30362090 -164 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30347591 30347434 -157 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34141479 34141644 165 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30311760 30311639 -121 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30725729 30725850 121 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30782294 30782185 -109 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7619309 7619329 20 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30326240 30326168 -72 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32079886 32079819 -67 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32132999 32133052 53 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34144439 34144384 -55 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30759738 30759773 35 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32076870 32076903 33 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30759960 30759929 -31 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32132893 32132863 -30 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34138582 34138609 27 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35184964 35184991 27 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30748111 30748130 19 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32129887 32129870 -17 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35183041 35183056 15 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30312196 30312184 -12 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7617129 7617132 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46476498 46476508 10 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34135645 34135639 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58345700 58345710 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46489370 46489363 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58255285 58255278 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80667603 80667612 9 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30348092 30348089 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80547647 80547654 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92688770 92688762 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46464442 46464446 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46479178 46479174 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92686929 92686936 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80560691 80560697 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80671123 80671126 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58352848 58352846 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92716723 92716726 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68687128 68687130 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80646207 80646205 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46452478 46452477 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46485858 46485859 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46492222 46492221 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58257513 58257512 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58260231 58260230 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92677870 92677871 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92718956 92718955 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92722954 92722953 -1 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42184840 42184840 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42244599 42244599 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43199003 43199003 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58239129 58239129 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41798122 41798122 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4681887 4681887 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4216069 4216069 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563586 2563586 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11291757 11291757 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43874661 43874661 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41797616 41797616 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4237990 4237990 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43201896 43201896 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5001844 5001844 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43967452 43967452 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43311749 43311749 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11475373 11475373 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43201919 43201919 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11481352 11481352 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2656167 2656167 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925844 1925844 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932565 1932565 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2662010 2662010 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42258634 42258634 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80546266 80546266 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1667388 1667388 0 (0.00%) 1.05%
handshake_session_id_ring_1.3_rsa_aes_server 43308833 43308833 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46395836 46395836 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58356602 58356602 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42170889 42170889 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4497243 4497243 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41811852 41811852 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43964094 43964094 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43874662 43874662 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717516 1717516 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3878043 3878043 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41709412 41709412 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2175370 2175370 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42244157 42244157 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41723142 41723142 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43967451 43967451 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41708906 41708906 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42170363 42170363 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43311726 43311726 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1283809 1283809 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43871304 43871304 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4236339 4236339 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3873595 3873595 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.43 ms 4.55 ms 0.12 ms (2.66%) 6.04%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.16 ms 5.28 ms 0.12 ms (2.31%) 5.15%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.10 ms 5.22 ms 0.12 ms (2.27%) 4.78%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.13 ms 5.24 ms 0.11 ms (2.24%) 4.56%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 456.25 µs 464.86 µs 8.61 µs (1.89%) 3.93%
transfer_no_resume_ring_1.3_rsa_aes 6.78 ms 6.91 ms 0.12 ms (1.81%) 3.80%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.33 ms 6.44 ms 0.11 ms (1.75%) 3.84%
transfer_no_resume_ring_1.2_rsa_aes 6.74 ms 6.86 ms 0.11 ms (1.69%) 3.17%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 460.39 µs 466.55 µs 6.16 µs (1.34%) 4.35%
handshake_no_resume_ring_1.3_ecdsap256_chacha 500.09 µs 506.75 µs 6.66 µs (1.33%) 2.65%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.43 ms 9.55 ms 0.12 ms (1.27%) 2.45%
handshake_no_resume_ring_1.3_ecdsap256_aes 505.32 µs 510.23 µs 4.91 µs (0.97%) 3.29%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.91 ms 13.03 ms 0.12 ms (0.93%) 2.00%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.94 ms 13.06 ms 0.12 ms (0.90%) 1.85%
transfer_no_resume_ring_1.3_rsa_chacha 13.44 ms 13.56 ms 0.12 ms (0.88%) 1.91%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.60 ms 13.72 ms 0.12 ms (0.85%) 2.08%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.64 ms 13.75 ms 0.11 ms (0.83%) 2.03%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.05 ms 16.17 ms 0.12 ms (0.76%) 1.62%
handshake_no_resume_ring_1.3_rsa_chacha 0.99 ms 1.00 ms 0.01 ms (0.68%) 1.40%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.12 ms 1.13 ms 0.01 ms (0.63%) 2.40%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.19 ms 0.01 ms (0.63%) 1.75%
handshake_no_resume_ring_1.2_rsa_aes 990.76 µs 996.31 µs 5.55 µs (0.56%) 1.11%
handshake_no_resume_ring_1.3_rsa_aes 1.00 ms 1.00 ms 0.01 ms (0.55%) 1.08%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.09 ms 1.10 ms 0.00 ms (0.45%) 3.72%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.62 ms 1.63 ms 0.01 ms (0.40%) 4.78%
handshake_tickets_ring_1.2_rsa_aes 1.59 ms 1.60 ms 0.01 ms (0.40%) 2.41%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms 0.00 ms (0.35%) 1.86%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.12 ms 1.13 ms 0.00 ms (0.35%) 3.25%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms 0.01 ms (0.34%) 2.24%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.61 ms 0.01 ms (0.19%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.61 ms 0.01 ms (0.17%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.26 ms 5.27 ms 0.01 ms (0.16%) 2.07%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.63 ms 5.64 ms 0.01 ms (0.15%) 2.15%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.92 ms 4.92 ms 0.01 ms (0.14%) 2.42%
handshake_session_id_ring_1.3_ecdsap256_aes 6.59 ms 6.58 ms -0.01 ms (-0.10%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.58 ms 4.59 ms 0.00 ms (0.10%) 1.81%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.59 ms 5.60 ms 0.01 ms (0.10%) 2.67%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.27 ms 5.28 ms 0.00 ms (0.09%) 2.42%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.28 ms 5.29 ms 0.00 ms (0.09%) 1.66%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.62 ms 5.63 ms 0.00 ms (0.07%) 2.36%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.54 ms 6.54 ms -0.00 ms (-0.07%) 1.11%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.30 ms 5.31 ms 0.00 ms (0.07%) 2.01%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.63 ms 5.64 ms 0.00 ms (0.07%) 2.04%
handshake_tickets_ring_1.3_rsa_chacha 7.14 ms 7.14 ms 0.00 ms (0.07%) 1.03%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.74 ms 9.74 ms 0.01 ms (0.05%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.93 ms 4.93 ms 0.00 ms (0.05%) 2.29%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.65 ms 6.65 ms -0.00 ms (-0.05%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 6.70 ms 6.70 ms 0.00 ms (0.04%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.79 ms 9.79 ms 0.00 ms (0.04%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 7.08 ms 7.08 ms -0.00 ms (-0.03%) 1.05%
handshake_session_id_ring_1.3_ecdsap384_aes 9.67 ms 9.67 ms 0.00 ms (0.03%) 1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.81 ms 1.81 ms 0.00 ms (0.02%) 4.99%
handshake_session_id_ring_1.3_rsa_chacha 7.03 ms 7.03 ms -0.00 ms (-0.02%) 1.46%
handshake_tickets_ring_1.3_rsa_aes 7.19 ms 7.19 ms 0.00 ms (0.02%) 1.45%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.63 ms 9.63 ms -0.00 ms (-0.01%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.57 ms 4.57 ms 0.00 ms (0.01%) 1.78%

Additional information

Historical results

Checkout details:

ctz
ctz approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member
@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ctz ctz added this pull request to the merge queue Oct 14, 2024
Merged via the queue into rustls:main with commit e2e2d9c Oct 14, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hex1c @djc @ctz @tharun-kumar-16675
0