8000 Remove crossbuilds and coverage from merge_checks by ctz · Pull Request #2165 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove crossbuilds and coverage from merge_checks #2165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2024
Merged

Remove crossbuilds and coverage from merge_checks #2165

merged 1 commit into from
Oct 17, 2024

Conversation

ctz
Copy link
Member
@ctz ctz commented Oct 17, 2024

These are the more costly jobs, and it seems unlikely they uniquely will capture rebase failures in a way that other jobs cannot (?).

This should improve our merge queue time, which is currently around 16-24 minutes.

@ctz
Remove crossbuilds and coverage from merge_checks
85ed13d 
These are the more costly jobs, and it seems unlikely
they uniquely will capture rebase failures in a way that other
jobs cannot.

This should improve our merge queue time, which is currently
around 16-24 minutes.
cpu
cpu approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member
@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Oct 17, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_ring_1.2_rsa_aes_server 4250539 4235449 ✅ -15090 (-0.36%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3890031 3876261 ✅ -13770 (-0.35%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4693603 4678423 ✅ -15180 (-0.32%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5012105 4998335 ✅ -13770 (-0.27%) 0.20%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10772917 10813710 40793 (0.38%) 1.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8584452 8615011 30559 (0.36%) 0.71%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8578369 8598120 19751 (0.23%) 1.11%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3084647 3087074 2427 (0.08%) 0.28%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3620617 3622782 2165 (0.06%) 0.45%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1278758 1278134 -624 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32090119 32074686 -15433 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32146065 32130648 -15417 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32142999 32127707 -15292 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32146057 32130783 -15274 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32092882 32077647 -15235 (-0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32093010 32077798 -15212 (-0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34159600 34143956 -15644 (-0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34153450 34137861 -15589 (-0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34159451 34143865 -15586 (-0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34156191 34140674 -15517 (-0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34150291 34134787 -15504 (-0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34153495 34138170 -15325 (-0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1280937 1280402 -535 (-0.04%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43885604 43869164 -16440 (-0.04%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43888679 43872239 -16440 (-0.04%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43888719 43872279 -16440 (-0.04%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43976204 43959794 -16410 (-0.04%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43979279 43962869 -16410 (-0.04%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43979319 43962909 -16410 (-0.04%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43212649 43196929 -15720 (-0.04%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43215287 43199567 -15720 (-0.04%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43215306 43199586 -15720 (-0.04%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43320289 43304599 -15690 (-0.04%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43322927 43307237 -15690 (-0.04%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43322946 43307256 -15690 (-0.04%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4236729 4235199 -1530 (-0.04%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1664483 1663935 -548 (-0.03%) 1.05%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1667442 1666895 -547 (-0.03%) 1.04%
handshake_tickets_ring_1.2_rsa_aes_client 4497513 4496133 -1380 (-0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10452902 10449837 -3065 (-0.03%) 1.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2178898 2178338 -560 (-0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46434710 46446232 11522 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2175756 2175222 -534 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10812746 10814345 1599 (0.01%) 1.09%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30783249 30779508 -3741 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30313413 30309823 -3590 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30726608 30722982 -3626 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30726619 30723016 -3603 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30312831 30309277 -3554 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30760879 30757276 -3603 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30348726 30345180 -3546 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30349229 30345701 -3528 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30363278 30359805 -3473 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30760636 30757179 -3457 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30327215 30323812 -3403 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30748882 30745571 -3311 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932685 1932491 -194 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925964 1925777 -187 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41710636 41707084 -3552 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41798626 41795074 -3552 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41724372 41720842 -3530 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41710146 41706618 -3528 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42172123 42168561 -3562 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41812362 41808832 -3530 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41798136 41794608 -3528 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42245425 42241863 -3562 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42186068 42182528 -3540 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42171601 42168063 -3538 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42259298 42255758 -3540 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42244831 42241293 -3538 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7617549 7616999 -550 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7619693 7619145 -548 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717525 1717404 -121 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3628063 3627823 -240 (-0.01%) 0.45%
handshake_no_resume_ring_1.3_rsa_aes_client 2656291 2656121 -170 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2662156 2661986 -170 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3873385 3873175 -210 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11481800 11481252 -548 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11475844 11475297 -547 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11292292 11291823 -469 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58236459 58235168 -1291 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563535 2563491 -44 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4215739 4215679 -60 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58351862 58352513 651 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58251181 58251826 645 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58255492 58256136 644 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58253411 58254051 640 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58340971 58341610 639 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58348116 58348747 631 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92711981 92712625 644 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92684031 92684672 641 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92714215 92714855 640 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92673129 92673761 632 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92682197 92682828 631 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92718220 92718849 629 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35183198 35182993 -205 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35185103 35184913 -190 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3085012 3085017 5 (0.00%) 0.25%
transfer_no_resume_ring_1.3_rsa_aes_server 46487104 46487091 -13 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46460133 46460144 11 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46389589 46389595 6 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80540451 80540447 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46467811 46467813 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68683805 68683804 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80535649 80535648 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80554934 80554935 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641257 80641256 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80648882 80648881 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661852 80661853 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46470692 46470692 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46480090 46480090 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46467116 46467116 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 468.80 µs 457.40 µs -11.40 µs (-2.43%) 4.32%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.54 ms 4.43 ms -0.11 ms (-2.39%) 5.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.09 ms 0.02 ms (2.21%) 3.85%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.10 ms 1.12 ms 0.02 ms (2.10%) 8.86%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.27 ms 5.16 ms -0.11 ms (-2.07%) 4.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 465.02 µs 456.57 µs -8.45 µs (-1.82%) 4.06%
transfer_no_resume_ring_1.3_rsa_aes 6.93 ms 6.82 ms -0.12 ms (-1.72%) 3.47%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.44 ms 6.33 ms -0.11 ms (-1.67%) 3.46%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.60 ms 1.63 ms 0.03 ms (1.64%) 5.28%
transfer_no_resume_ring_1.2_rsa_aes 6.85 ms 6.74 ms -0.11 ms (-1.60%) 3.37%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.19 ms 5.12 ms -0.07 ms (-1.41%) 3.82%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.17 ms 5.10 ms -0.07 ms (-1.39%) 4.29%
handshake_no_resume_ring_1.3_ecdsap256_chacha 506.19 µs 499.19 µs -7.00 µs (-1.38%) 2.59%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.11 ms 1.12 ms 0.01 ms (1.31%) 9.17%
handshake_no_resume_ring_1.3_ecdsap256_aes 511.00 µs 504.83 µs -6.17 µs (-1.21%) 3.15%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.77 ms 1.79 ms 0.02 ms (1.18%) 5.40%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.53 ms 9.43 ms -0.10 ms (-1.10%) 2.09%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.19 ms 1.18 ms -0.01 ms (-0.96%) 1.71%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.65 ms 5.60 ms -0.05 ms (-0.88%) 1.83%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.92 ms 4.88 ms -0.04 ms (-0.88%) 2.18%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.01 ms 12.89 ms -0.11 ms (-0.87%) 1.73%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.74 ms 13.62 ms -0.12 ms (-0.85%) 1.53%
handshake_no_resume_ring_1.2_rsa_aes 997.57 µs 989.23 µs -8.34 µs (-0.84%) 1.16%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.19 ms 1.18 ms -0.01 ms (-0.77%) 1.40%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.32 ms 5.28 ms -0.04 ms (-0.76%) 1.97%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.30 ms 5.26 ms -0.04 ms (-0.75%) 1.57%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.04 ms 12.94 ms -0.10 ms (-0.75%) 1.56%
handshake_no_resume_ring_1.3_rsa_aes 1.00 ms 0.99 ms -0.01 ms (-0.74%) 1.08%
transfer_no_resume_ring_1.3_rsa_chacha 13.53 ms 13.44 ms -0.09 ms (-0.69%) 1.63%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.60 ms 4.57 ms -0.03 ms (-0.69%) 1.96%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.13 ms 16.04 ms -0.10 ms (-0.61%) 1.22%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.58 ms 4.56 ms -0.03 ms (-0.57%) 1.59%
handshake_no_resume_ring_1.3_rsa_chacha 999.98 µs 994.53 µs -5.45 µs (-0.55%) 1.30%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.64 ms 5.61 ms -0.03 ms (-0.53%) 1.82%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.92 ms 4.90 ms -0.03 ms (-0.52%) 1.80%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.57 ms 5.60 ms 0.03 ms (0.50%) 2.65%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.65 ms 13.58 ms -0.07 ms (-0.49%) 1.61%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.60 ms -0.00 ms (-0.27%) 2.06%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.64 ms 6.63 ms -0.01 ms (-0.21%) 1.13%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.23 ms 5.24 ms 0.01 ms (0.21%) 2.54%
handshake_tickets_ring_1.3_rsa_aes 7.18 ms 7.17 ms -0.01 ms (-0.19%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.59 ms -0.01 ms (-0.17%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 7.13 ms 7.12 ms -0.01 ms (-0.15%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.73 ms 9.72 ms -0.01 ms (-0.14%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms -0.00 ms (-0.13%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.60 ms 9.61 ms 0.01 ms (0.11%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.77 ms 9.76 ms -0.01 ms (-0.11%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.56 ms 5.56 ms -0.01 ms (-0.10%) 2.53%
handshake_session_id_ring_1.3_rsa_aes 7.06 ms 7.05 ms -0.01 ms (-0.10%) 1.01%
handshake_tickets_ring_1.3_ecdsap256_aes 6.69 ms 6.69 ms 0.00 ms (0.05%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.64 ms 9.65 ms 0.00 ms (0.04%) 1.00%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms 0.00 ms (0.03%) 2.14%
handshake_session_id_ring_1.3_ecdsap256_aes 6.56 ms 6.56 ms -0.00 ms (-0.03%) 1.03%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.52 ms 6.52 ms 0.00 ms (0.02%) 1.17%
handshake_session_id_ring_1.3_rsa_chacha 7.01 ms 7.01 ms 0.00 ms (0.01%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.24 ms 5.24 ms 0.00 ms (0.01%) 2.07%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link
codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.12%. Comparing base (d58f86d) to head (85ed13d).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2165      +/-   ##
==========================================
+ Coverage   94.67%   95.12%   +0.45%     
==========================================
  Files         102      102              
  Lines       23471    25816    +2345     
==========================================
+ Hits        22220    24557    +2337     
- Misses       1251     1259       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctz ctz added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit 44f89de Oct 17, 2024
60 checks passed
@ctz ctz deleted the jbp-faster-merge-queue branch October 17, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu
0