8000 client/tls12: remove stale ref to SCT verification by cpu · Pull Request #2166 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

client/tls12: remove stale ref to SCT verification #2166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2024
Merged

client/tls12: remove stale ref to SCT verification #2166

merged 1 commit into from
Oct 17, 2024

Conversation

cpu
Copy link
Member
@cpu cpu commented Oct 17, 2024

The TLS 1.3 equivalent of this list of steps was already updated to reflect the removal of SCT verification. This commit does the same for the TLS 1.2 client code, renumbering steps as required.

@cpu
client/tls12: remove stale ref to SCT verification
7abaf0d 
The TLS 1.3 equivalent of this list of steps was already updated to
reflect the removal of SCT verification. This commit does the same for
the TLS 1.2 client code, renumbering steps as required.
@cpu cpu self-assigned this Oct 17, 2024
@rustls-benchmarking Rustls Benchmarking
Copy link

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10787428 10838394 50966 (0.47%) 1.09%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8562083 8596949 34866 (0.41%) 1.11%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10462862 10422406 -40456 (-0.39%) 1.28%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10806774 10811197 4423 (0.04%) 1.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8596454 8599519 3065 (0.04%) 0.71%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3087447 3087054 -393 (-0.01%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1278668 1278758 90 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3629195 3629423 228 (0.01%) 0.45%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1280937 1280863 -74 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2175825 2175749 -76 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3623684 3623570 -114 (-0.00%) 0.45%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2178770 2178813 43 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3085037 3085086 49 (0.00%) 0.25%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30748851 30749136 285 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30782991 30783264 273 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30313245 30313482 237 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932692 1932707 15 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32145882 32146053 171 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 34159389 34159553 164 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30760753 30760608 -145 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32093029 32093177 148 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30726721 30726595 -126 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30349243 30349355 112 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925964 1925971 7 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32143032 32143138 106 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30760960 30760859 -101 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32089981 32090081 100 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30327280 30327194 -86 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 34159690 34159599 -91 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7619703 7619723 20 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30363245 30363314 69 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 34153542 34153466 -76 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30726504 30726564 60 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 34156333 34156267 -66 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 34150260 34150321 61 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32093022 32093075 53 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30348740 30348789 49 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30312734 30312689 -45 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32146035 32145997 -38 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 34153656 34153691 35 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35185128 35185155 27 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35183183 35183198 15 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7617546 7617549 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46467812 46467802 -10 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58340971 58340962 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58255492 58255500 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46460143 46460137 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92714212 92714222 10 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46434714 46434709 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641254 80641262 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80648877 80648885 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80554934 80554927 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92684031 92684024 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58253411 58253415 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92673122 92673127 5 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46389595 46389597 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661848 80661851 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha 8000 _client 92682190 92682188 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92711983 92711981 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92718216 92718218 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46467118 46467117 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46470691 46470692 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46487101 46487100 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58236448 58236449 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58351871 58351872 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68683803 68683802 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80535647 80535648 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80540444 80540445 1 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41724372 41724372 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43320289 43320289 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58251178 58251178 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3873385 3873385 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2656291 2656291 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43976204 43976204 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717449 1717449 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4250539 4250539 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42244831 42244831 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4497513 4497513 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11475844 11475844 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42172123 42172123 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41798626 41798626 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43888719 43888719 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1663078 1663078 0 (0.00%) 1.04%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3890031 3890031 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42186068 42186068 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43322927 43322927 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5012105 5012105 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2662156 2662156 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43885604 43885604 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41710636 41710636 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43215306 43215306 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41812362 41812362 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42245425 42245425 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43212649 43212649 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43215287 43215287 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1668829 1668829 0 (0.00%) 1.05%
handshake_no_resume_ring_1.3_rsa_chacha_server 11481800 11481800 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11292292 11292292 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58348106 58348106 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4215739 4215739 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41710146 41710146 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41798136 41798136 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43322946 43322946 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4693603 4693603 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43888679 43888679 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42259298 42259298 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46480088 46480088 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43979279 43979279 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43979319 43979319 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4236729 4236729 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42171601 42171601 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563535 2563535 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.22 ms 5.19 ms -0.03 ms (-0.64%) 2.54%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.58 ms 4.55 ms -0.03 ms (-0.61%) 1.59%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.31 ms 5.28 ms -0.03 ms (-0.57%) 1.97%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.91 ms 4.89 ms -0.03 ms (-0.56%) 1.80%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.29 ms 5.26 ms -0.03 ms (-0.55%) 1.57%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.59 ms 4.56 ms -0.02 ms (-0.54%) 1.96%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.56 ms 5.53 ms -0.03 ms (-0.52%) 2.65%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.62 ms 5.59 ms -0.03 ms (-0.47%) 1.82%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.91 ms 4.88 ms -0.02 ms (-0.47%) 2.18%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.23 ms 5.21 ms -0.02 ms (-0.45%) 2.07%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.63 ms 5.60 ms -0.02 ms (-0.43%) 1.83%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 461.98 µs 460.06 µs -1.92 µs (-0.41%) 4.32%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.55 ms 5.53 ms -0.02 ms (-0.35%) 2.53%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.11 ms 5.09 ms -0.02 ms (-0.34%) 3.82%
handshake_no_resume_ring_1.3_ecdsap256_chacha 501.10 µs 499.71 µs -1.39 µs (-0.28%) 2.59%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.60 ms 1.59 ms -0.00 ms (-0.25%) 5.28%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.18 ms 5.17 ms -0.01 ms (-0.23%) 4.26%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.53 ms 6.52 ms -0.01 ms (-0.22%) 1.17%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.45 ms 4.44 ms -0.01 ms (-0.18%) 5.20%
handshake_tickets_ring_1.3_rsa_chacha 7.13 ms 7.12 ms -0.01 ms (-0.17%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 7.02 ms 7.01 ms -0.01 ms (-0.14%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.09 ms 1.08 ms -0.00 ms (-0.12%) 9.17%
handshake_tickets_ring_1.3_ecdsap256_aes 6.69 ms 6.69 ms -0.01 ms (-0.12%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.06 ms -0.00 ms (-0.11%) 3.85%
handshake_session_id_ring_1.3_ecdsap256_aes 6.57 ms 6.56 ms -0.01 ms (-0.10%) 1.03%
handshake_no_resume_ring_1.3_ecdsap256_aes 504.81 µs 504.31 µs -0.50 µs (-0.10%) 3.15%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.65 ms 13.64 ms -0.01 ms (-0.10%) 1.53%
handshake_session_id_ring_1.2_rsa_aes 1.51 ms 1.51 ms -0.00 ms (-0.09%) 2.14%
handshake_tickets_ring_1.2_rsa_aes 1.59 ms 1.59 ms -0.00 ms (-0.09%) 2.06%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.61 ms 9.60 ms -0.01 ms (-0.08%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.09 ms 1.09 ms 0.00 ms (0.08%) 8.86%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.45 ms 9.44 ms -0.01 ms (-0.08%) 2.09%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.08 ms 5.08 ms -0.00 ms (-0.08%) 4.29%
handshake_no_resume_ring_1.2_rsa_aes 991.25 µs 992.04 µs 0.79 µs (0.08%) 1.16%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.65 ms 6.64 ms -0.00 ms (-0.07%) 1.13%
handshake_no_resume_ring_1.3_rsa_chacha 995.72 µs 995.01 µs -0.71 µs (-0.07%) 1.30%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 456.64 µs 456.95 µs 0.31 µs (0.07%) 4.06%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.92 ms 12.91 ms -0.01 ms (-0.07%) 1.73%
handshake_session_id_ring_1.3_ecdsap384_aes 9.65 ms 9.64 ms -0.01 ms (-0.06%) 1.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.76 ms 1.76 ms -0.00 ms (-0.06%) 5.40%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.18 ms -0.00 ms (-0.06%) 1.40%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.73 ms 9.73 ms 0.01 ms (0.06%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.95 ms 12.95 ms -0.01 ms (-0.05%) 1.56%
handshake_no_resume_ring_1.3_rsa_aes 994.26 µs 994.79 µs 0.53 µs (0.05%) 1.08%
handshake_session_id_ring_1.3_rsa_aes 7.06 ms 7.06 ms -0.00 ms (-0.05%) 1.01%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.56 ms 13.56 ms 0.01 ms (0.05%) 1.61%
transfer_no_resume_ring_1.2_rsa_aes 6.76 ms 6.75 ms -0.00 ms (-0.05%) 3.37%
transfer_no_resume_ring_1.3_rsa_chacha 13.44 ms 13.43 ms -0.01 ms (-0.04%) 1.63%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.59 ms -0.00 ms (-0.04%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms 0.00 ms (0.03%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.77 ms 8000 9.77 ms 0.00 ms (0.03%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms -0.00 ms (-0.03%) 1.71%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.35 ms 6.35 ms -0.00 ms (-0.02%) 3.46%
handshake_tickets_ring_1.3_rsa_aes 7.18 ms 7.18 ms 0.00 ms (0.01%) 1.00%
transfer_no_resume_ring_1.3_rsa_aes 6.84 ms 6.84 ms -0.00 ms (-0.01%) 3.47%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.05 ms 16.05 ms -0.00 ms (-0.00%) 1.22%

Additional information

Historical results

Checkout details:

@cpu
Copy link
Member Author
cpu commented Oct 17, 2024

Docs-only. Going to merge w/ 1 review.

@cpu cpu enabled auto-merge October 17, 2024 16:07
@cpu cpu added this pull request to the merge queue Oct 17, 2024
@codecov Codecov
Copy link
codecov bot commented Oct 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.72%. Comparing base (13144a0) to head (7abaf0d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2166   +/-   ##
=======================================
  Coverage   94.72%   94.72%           
=======================================
  Files         102      102           
  Lines       23753    23753           
=======================================
  Hits        22499    22499           
  Misses       1254     1254

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into rustls:main with commit 9af5a44 Oct 17, 2024
32 checks passed
@cpu cpu deleted the cpu-tidy-sct-ref branch October 17, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctz ctz ctz approved these changes

Assignees

@cpu cpu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpu @ctz
0