8000 Don't warn on UserCanceled alerts by djc · Pull Request #2184 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Don't warn on UserCanceled alerts #2184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2024
Merged

Don't warn on UserCanceled alerts #2184

merged 1 commit into from
Oct 28, 2024

Conversation

djc
Copy link
Member
@djc djc commented Oct 27, 2024

Fixes #2182.

@djc djc requested review from cpu and ctz October 27, 2024 20:36
@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Oct 27, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand 8000
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10745863 10706288 -39575 (-0.37%) 1.08%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10457925 10479288 21363 (0.20%) 1.29%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8586149 8596599 10450 (0.12%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3084578 3082198 -2380 (-0.08%) 0.25%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3623580 3621342 -2238 (-0.06%) 0.45%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10740670 10737233 -3437 (-0.03%) 1.12%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3087592 3086966 -626 (-0.02%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1210904 1210823 -81 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2108806 2108924 118 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8584469 8584182 -287 (-0.00%) 0.57%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3625173 3625059 -114 (-0.00%) 0.47%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717497 1717454 -43 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1639805 1639769 -36 (-0.00%) 1.04%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32429095 32428552 -543 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932708 1932686 -22 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 30022246 30022471 225 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30585693 30585492 -201 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1208642 1208635 -7 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30599236 30599071 -165 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 30072716 30072876 160 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30599090 30599230 140 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32425244 32425386 142 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30621504 30621389 -115 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925972 1925965 -7 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 30025447 30025342 -105 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2105792 2105785 -7 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30585333 30585427 94 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 30075523 30075605 82 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30168507 30168428 -79 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30182370 30182447 77 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32431577 32431500 -77 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30204086 30204152 66 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 30075741 30075677 -64 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7596426 7596412 -14 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30168009 30168064 55 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30218501 30218548 47 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30607857 30607818 -39 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30204554 30204591 37 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32428124 32428149 25 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35185160 35185133 -27 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7594238 7594234 -4 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 30025193 30025208 15 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35183220 35183203 -17 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32428429 32428414 -15 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46470692 46470681 -11 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32431453 32431446 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46467118 46467127 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58251826 58251815 -11 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661844 80661853 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92718851 92718860 9 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46467809 46467813 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58341609 58341604 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92673770 92673763 -7 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80535649 80535644 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92682836 92682831 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92714855 92714859 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80540449 80540446 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80648886 80648884 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92712626 92712624 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46434710 46434709 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46480093 46480094 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46487100 46487101 1 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58237089 58237088 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58256139 58256140 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58348746 58348747 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58352512 58352513 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68684442 68684441 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80554934 80554935 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641259 80641260 1 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server11452529 11452529 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42081361 42081361 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43321981 43321981 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 42648797 42648797 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41640516 41640516 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92684671 92684671 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41641024 41641024 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2656296 2656296 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11292338 11292338 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46389588 46389588 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4236879 4236879 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 42557498 42557498 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42080821 42080821 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43318866 43318866 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 42646223 42646223 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5014085 5014085 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41585052 41585052 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2662161 2662161 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42039061 42039061 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43381801 43381801 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3892011 3892011 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41570826 41570826 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 42560117 42560117 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43321985 43321985 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41571316 41571316 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1641170 1641170 0 (0.00%) 1.05%
handshake_tickets_ring_1.3_rsa_aes_client 42095288 42095288 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43378656 43378656 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58254053 58254053 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 42560106 42560106 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4497663 4497663 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41654742 41654742 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3873535 3873535 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43381775 43381775 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42053528 42053528 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563544 2563544 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42039583 42039583 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4251919 4251919 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4694983 4694983 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11458509 11458509 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 42648831 42648831 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4215889 4215889 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46460133 46460133 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.43 ms 4.51 ms 0.08 ms (1.83%) 4.31%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.11 ms 5.20 ms 0.09 ms (1.74%) 3.24%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.16 ms 5.25 ms 0.09 ms (1.65%) 3.76%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.10 ms 5.17 ms 0.07 ms (1.44%) 3.66%
transfer_no_resume_ring_1.2_rsa_aes 6.75 ms 6.84 ms 0.09 ms (1.31%) 2.53%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.34 ms 6.42 ms 0.08 ms (1.27%) 3.27%
transfer_no_resume_ring_1.3_rsa_aes 6.83 ms 6.91 ms 0.08 ms (1.21%) 3.01%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 455.61 µs 460.12 µs 4.52 µs (0.99%) 3.55%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 457.38 µs 461.87 µs 4.49 µs (0.98%) 2.91%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.47 ms 5.52 ms 0.05 ms (0.91%) 1.50%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.79 ms 4.84 ms 0.04 ms (0.89%) 1.36%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.44 ms 9.51 ms 0.08 ms (0.80%) 1.96%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.51 ms 5.56 ms 0.04 ms (0.79%) 1.42%
handshake_no_resume_ring_1.3_ecdsap256_chacha 500.40 µs 504.18 µs 3.78 µs (0.76%) 2.38%
handshake_no_resume_ring_1.3_ecdsap256_aes 503.33 µs 506.69 µs 3.36 µs (0.67%) 2.75%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.80 ms 1.79 ms -0.01 ms (-0.67%) 5.46%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.81 ms 4.84 ms 0.03 ms (0.66%) 1.74%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.94 ms 13.03 ms 0.08 ms (0.64%) 1.46%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.57 ms 13.66 ms 0.09 ms (0.64%) 1.46%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.91 ms 12.99 ms 0.08 ms (0.63%) 1.75%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.54 ms 5.57 ms 0.03 ms (0.60%) 1.32%
transfer_no_resume_ring_1.3_rsa_chacha 13.44 ms 13.52 ms 0.08 ms (0.59%) 1.38%
handshake_no_resume_ring_1.2_rsa_aes 988.15 µs 993.76 µs 5.62 µs (0.57%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.64 ms 13.72 ms 0.08 ms (0.56%) 1.41%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.63 ms 1.62 ms -0.01 ms (-0.47%) 4.30%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.46 ms 4.48 ms 0.02 ms (0.45%) 1.23%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.04 ms 16.11 ms 0.07 ms (0.43%) 1.21%
handshake_no_resume_ring_1.3_rsa_aes 994.76 µs 998.75 µs 3.99 µs (0.40%) 1.03%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.48 ms 5.50 ms 0.02 ms (0.39%) 1.48%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 5.13 ms 5.15 ms 0.02 ms (0.39%) 1.37%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.18 ms 0.00 ms (0.36%) 1.32%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.17 ms 5.19 ms 0.02 ms (0.36%) 1.23%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.11 ms 1.11 ms 0.00 ms (0.29%) 8.79%
handshake_no_resume_ring_1.3_rsa_chacha 995.23 µs 997.95 µs 2.73 µs (0.27%) 1.11%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms 0.00 ms (0.23%) 1.18%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.20 ms 5.22 ms 0.01 ms (0.22%) 1.67%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.61 ms 3.60 ms -0.01 ms (-0.22%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 7.11 ms 7.13 ms 0.02 ms (0.22%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 6.62 ms 6.63 ms 0.01 ms (0.21%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.59 ms 6.60 ms 0.01 ms (0.19%) 1.02%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms 0.00 ms (0.19%) 1.14%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.60 ms -0.01 ms (-0.18%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.49 ms 4.49 ms 0.01 ms (0.16%) 1.83%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 5.15 ms 5.16 ms 0.01 ms (0.15%) 1.85%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.11 ms 1.11 ms 0.00 ms (0.15%) 9.25%
handshake_tickets_ring_1.3_rsa_chacha 7.08 ms 7.09 ms 0.01 ms (0.15%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.57 ms 9.56 ms -0.01 ms (-0.14%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.98 ms 6.97 ms -0.01 ms (-0.14%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 7.02 ms 7.01 ms -0.01 ms (-0.12%) 1.00%
handshake_tickets_ring_1.2_rsa_aes 1.59 ms 1.59 ms 0.00 ms (0.12%) 1.23%
handshake_session_id_ring_1.3_ecdsap384_aes 9.61 ms 9.59 ms -0.01 ms (-0.12%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.07 ms 1.07 ms 0.00 ms (0.10%) 7.70%
handshake_session_id_ring_1.3_ecdsap256_aes 6.52 ms 6.51 ms -0.00 ms (-0.05%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.48 ms 6.48 ms -0.00 ms (-0.02%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.68 ms 9.68 ms 0.00 ms (0.02%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.72 ms 9.72 ms -0.00 ms (-0.00%) 1.00%

Additional information

Historical results

Checkout details:

8000

@codecov Codecov
Copy link
codecov bot commented Oct 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.65%. Comparing base (121d813) to head (7ee9081).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
rustls/src/common_state.rs 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2184      +/-   ##
==========================================
- Coverage   94.66%   94.65%   -0.01%     
==========================================
  Files         102      102              
  Lines       23748    24031     +283     
==========================================
+ Hits        22480    22746     +266     
- Misses       1268     1285      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ctz
ctz approved these changes Oct 27, 2024
View reviewed changes
Copy link
Member
@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could gate this warn! under debug_assertions instead? I don't think a warning alert is ever actionable in production, but it's nice to have it in logs for debugging purposes.

Maybe we could note https://bugs.openjdk.org/browse/JDK-8323517 and https://bugs.openjdk.org/browse/JDK-8282600 somewhere, because AIUI Java is the only implementation that sends user_canceled like it's going out of fashion (I believe NSS also sends it, but that is under user control and matches the purpose of the alert.)

@djc djc force-pushed the canceled-no-warn branch from 3855158 to 79d6973 Compare October 28, 2024 09:21
@djc djc force-pushed the canceled-no-warn branch from 79d6973 to 7ee9081 Compare October 28, 2024 09:22
@djc
Copy link
Member Author
djc commented Oct 28, 2024

Adapted as suggested by @ctz.

@djc djc added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit e07bdc9 Oct 28, 2024
58 of 60 checks passed
@djc djc deleted the canceled-no-warn branch October 28, 2024 10:20
@cpu cpu mentioned this pull request Oct 28, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make UserCanceled Alert Warning not be tracing::warn!
3 participants
@djc @cpu @ctz
0