8000 Support multithreaded benchmarks by ctz · Pull Request #2192 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Support multithreaded benchmarks #2192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 8, 2024
Merged

Support multithreaded benchmarks #2192

merged 3 commits into from
Nov 8, 2024

Conversation

ctz
Copy link
Member
@ctz ctz commented Nov 1, 2024

This produces output like:

$ cargo run --release --example bench -- --threads 8 handshake TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
handshakes	TLSv1_2	Rsa2048	TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256	client	server-auth	no-resume	threads	8	10155.44	10166.96	10092.23	10234.48	9095.63	10098.87	10075.14	9104.87	total	79023.63	per-thread	9877.95	handshakes/s

This means:

handshakes	TLSv1_2	Rsa2048	TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256	client	server-auth	no-resume

old output

threads	8

number of threads used

10155.44	10166.96	10092.23	10234.48	9095.63	10098.87	10075.14	9104.87

individual thread measurements

total	79023.63	per-thread	9877.95	handshakes/s

sum and average of thread measurements

@ctz ctz force-pushed the jbp-threaded-benchmarks branch from d144fa4 to 30165b2 Compare November 1, 2024 11:45
@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Nov 1, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10393705 10483669 89964 (0.87%) 1.39%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8578761 8617940 39179 (0.46%) 0.79%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10732901 10714509 -18392 (-0.17%) 1.18%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3085040 3080565 -4475 (-0.15%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8588525 8597905 9380 (0.11%) 0.98%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10723981 10715237 -8744 (-0.08%) 1.04%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3086755 3086199 -556 (-0.02%) 0.26%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3622780 3622615 -165 (-0.00%) 0.48%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2076730 2076637 -93 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3623442 3623518 76 (0.00%) 0.45%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1179487 1179509 22 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1614034 1614006 -28 (-0.00%) 1.06%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932569 1932591 22 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1181688 1181675 -13 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717479 1717494 15 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28883980 28883770 -210 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28963063 28962903 -160 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28965715 28965867 152 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28193914 28194046 132 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27856319 27856189 -130 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27795990 27796107 117 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30410752 30410879 127 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925848 1925855 7 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2079658 2079665 7 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28190107 28190194 87 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30367178 30367257 79 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28886478 28886540 62 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27793471 27793527 56 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30370704 30370646 -58 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30414090 30414147 57 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27853810 27853773 -37 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30413876 30413839 -37 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28187050 28187083 33 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27800362 27800331 -31 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28220713 28220743 30 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28224740 28224770 30 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27860759 27860780 21 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28217731 28217711 -20 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30370397 30370381 -16 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28886460 28886470 10 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28965665 28965672 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46480088 46480098 10 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46470690 46470681 -9 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46389596 46389589 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46434715 46434709 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46460138 46460144 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46467117 46467123 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68683808 68683800 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661859 80661850 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58254058 58254052 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46467809 46467813 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58256137 58256132 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58348756 58348751 -5 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58236448 58236452 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92684663 92684669 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80648882 80648887 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58352502 58352505 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92712622 92712626 4 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46487102 46487100 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58251817 58251819 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92714862 92714860 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80535650 80535651 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80540443 80540444 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80554934 80554933 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92673768 92673769 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92682831 92682830 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92718857 92718858 1 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 40292413 40292413 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 40511800 40511800 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11292386 11292386 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 40586050 40586050 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 42063278 42063278 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4237209 4237209 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 40288362 40288362 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 40515800 40515800 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 40193982 40193982 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 41601939 41601939 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641263 80641263 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3893661 3893661 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 40198033 40198033 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4498203 4498203 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 41483631 41483631 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11425365 11425365 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563562 2563562 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3873865 3873865 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 41483709 41483709 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5015140 5015140 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 41964748 41964748 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 42060158 42060158 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 40582783 40582783 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58341611 58341611 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 40590050 40590050 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35183086 35183086 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 42063058 42063058 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 40508525 40508525 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2656181 2656181 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11431345 11431345 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 41599268 41599268 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35185016 35185016 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 40285413 40285413 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 41481038 41481038 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2662046 2662046 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 40191025 40191025 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4696093 4696093 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 41601861 41601861 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4216429 4216429 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4253569 4253569 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 41964968 41964968 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 41961848 41961848 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7567070 7567070 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7569248 7569248 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1612605 1612605 0 (0.00%) 1.06%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_ring_1.3_ecdsap256_chacha 501.11 µs 497.82 µs -3.29 µs (-0.66%) 2.59%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 454.94 µs 452.38 µs -2.56 µs (-0.56%) 3.16%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 456.34 µs 454.09 µs -2.25 µs (-0.49%) 3.07%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.21 ms 5.18 ms -0.03 ms (-0.49%) 3.86%
transfer_no_resume_ring_1.3_rsa_aes 6.83 ms 6.80 ms -0.03 ms (-0.41%) 3.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.46 ms 4.45 ms -0.02 ms (-0.40%) 4.45%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.12 ms 5.10 ms -0.02 ms (-0.36%) 3.93%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms -0.00 ms (-0.34%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.34 ms 6.32 ms -0.02 ms (-0.33%) 3.62%
transfer_no_resume_ring_1.2_rsa_aes 6.78 ms 6.76 ms -0.02 ms (-0.31%) 2.90%
handshake_tickets_ring_1.2_rsa_aes 1.60 ms 1.60 ms -0.00 ms (-0.29%) 1.16%
handshake_no_resume_ring_1.3_ecdsap256_aes 504.12 µs 502.77 µs -1.35 µs (-0.27%) 2.70%
handshake_session_id_ring_1.3_ecdsap256_aes 6.37 ms 6.35 ms -0.02 ms (-0.26%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.10 ms 5.09 ms -0.01 ms (-0.25%) 3.76%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.60 ms 1.60 ms -0.00 ms (-0.24%) 2.06%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.18 ms -0.00 ms (-0.24%) 1.15%
handshake_no_resume_ring_1.3_rsa_chacha 994.74 µs 992.40 µs -2.35 µs (-0.24%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 6.44 ms 6.42 ms -0.01 ms (-0.23%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.67 ms 13.64 ms -0.03 ms (-0.22%) 1.64%
handshake_no_resume_ring_1.3_rsa_aes 995.64 µs 993.47 µs -2.17 µs (-0.22%) 1.03%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.77 ms 1.76 ms -0.00 ms (-0.22%) 3.07%
handshake_session_id_ring_1.3_rsa_aes 6.87 ms 6.85 ms -0.01 ms (-0.21%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.48 ms 9.46 ms -0.02 ms (-0.20%) 2.14%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.08 ms 1.08 ms -0.00 ms (-0.20%) 6.66%
handshake_tickets_ring_1.3_rsa_aes 6.94 ms 6.92 ms -0.01 ms (-0.20%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.94 ms 12.91 ms -0.03 ms (-0.20%) 1.80%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.28 ms 4.27 ms -0.01 ms (-0.20%) 2.13%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms -0.00 ms (-0.18%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.59 ms 13.56 ms -0.02 ms (-0.18%) 1.63%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.39 ms 6.38 ms -0.01 ms (-0.18%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.32 ms 6.31 ms -0.01 ms (-0.18%) 1.00%
handshake_no_resume_ring_1.2_rsa_aes 991.30 µs 989.56 µs -1.75 µs (-0.18%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.00 ms 5.00 ms -0.01 ms (-0.17%) 1.57%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.41 ms 9.40 ms -0.02 ms (-0.17%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.82 ms 6.80 ms -0.01 ms (-0.15%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.09 ms 1.09 ms -0.00 ms (-0.15%) 2.36%
handshake_tickets_ring_1.3_ecdsap384_aes 9.53 ms 9.52 ms -0.01 ms (-0.15%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.46 ms 9.44 ms -0.01 ms (-0.14%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.88 ms 6.87 ms -0.01 ms (-0.14%) 1.00%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.96 ms 12.95 ms -0.02 ms (-0.14%) 1.59%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 4.93 ms 4.92 ms -0.01 ms (-0.13%) 1.68%
transfer_no_resume_ring_1.3_rsa_chacha 13.46 ms 13.44 ms -0.02 ms (-0.13%) 1.40%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.48 ms 9.47 ms -0.01 ms (-0.13%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.90 ms 4.89 ms -0.01 ms (-0.11%) 2.06%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.05 ms -0.00 ms (-0.10%) 1.71%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.96 ms 4.96 ms -0.00 ms (-0.10%) 1.58%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.06 ms 16.05 ms -0.01 ms (-0.07%) 1.30%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.11 ms 5.10 ms -0.00 ms (-0.06%) 1.59%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.25 ms 4.25 ms -0.00 ms (-0.05%) 1.53%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms -0.00 ms (-0.05%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.59 ms 3.59 ms -0.00 ms (-0.03%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.47 ms 4.47 ms -0.00 ms (-0.03%) 1.60%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.19 ms 5.19 ms -0.00 ms (-0.02%) 1.31%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.09 8000 ms 5.09 ms -0.00 ms (-0.02%) 1.49%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.43 ms 4.43 ms -0.00 ms (-0.01%) 1.90%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.16 ms 5.16 ms -0.00 ms (-0.01%) 1.55%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link
codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.63%. Comparing base (eddac26) to head (a224b99).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2192   +/-   ##
=======================================
  Coverage   94.63%   94.63%           
=======================================
  Files         102      102           
  Lines       23928    23928           
=======================================
  Hits        22645    22645           
  Misses       1283     1283

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cpu
cpu approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member
@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :-)

@sagudev sagudev mentioned this pull request Nov 2, 2024
Merged
3 tasks
djc
djc reviewed Nov 5, 2024
View reviewed changes
@ctz ctz force-pushed the jbp-threaded-benchmarks branch 2 times, most recently from ad3bdb3 to fd6c77e Compare November 5, 2024 15:19
@ctz ctz mentioned this pull request Nov 5, 2024
Merged
djc
djc approved these changes Nov 6, 2024
View reviewed changes
@ctz ctz force-pushed the jbp-threaded-benchmarks branch from fd6c77e to bb784b5 Compare November 8, 2024 10:34
djc
djc approved these changes Nov 8, 2024
View reviewed changes
@ctz ctz force-pushed the jbp-threaded-benchmarks branch from bb784b5 to d942e3a Compare November 8, 2024 14:58
@ctz ctz enabled auto-merge November 8, 2024 15:11
djc
djc reviewed Nov 8, 2024
View reviewed changes
@ctz ctz added this pull request to the merge queue Nov 8, 2024
@ctz ctz removed this pull request from the merge queue due to a manual request Nov 8, 2024
ctz added 3 commits November 8, 2024 15:45
@ctz
bench: support threaded handshake tests
798e38f
@ctz
Fix unreliablity of multithreaded TLS1.3 resumption
e29e8d8 
The default client session store keeps 8 tickets per server.
In this performance benchmark, we only talk to one server, so
at thread counts higher than 8, we can starve this cache before
it is refilled by the next successful connection.

This means a full handshake would happen, which is undesirable
in a test that wants to measure resumption speed (and, also,
it fails an assertion.)

So: allow any neccessary full handshakes to happen and simply
do not include their costs in the collected timings.
@ctz
bench: support threaded bulk tests
a224b99
@ctz ctz force-pushed the jbp-threaded-benchmarks branch from d942e3a to a224b99 Compare November 8, 2024 15:45
@ctz ctz added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit d1c33f8 Nov 8, 2024
60 checks passed
@ctz ctz deleted the jbp-threaded-benchmarks branch November 8, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu
0