8000 Upgrade hickory-resolver to alpha 3 by djc · Pull Request #2218 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade hickory-resolver to alpha 3 #2218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2024
Merged

Upgrade hickory-resolver to alpha 3 #2218

merged 1 commit into from
Nov 18, 2024

Conversation

djc
Copy link
Member
@djc djc commented Nov 18, 2024 •
edited
Loading

In the latest Hickory alpha I removed the sync shim over the asynchronous API, so we have to use it directly. That also resulted in renaming some things.

Fixate the alpha versions so they don't get upgraded automatically, since subsequent pre-release versions do not guarantee semver-compatibility.

@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Nov 18, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10478021 10437046 -40975 (-0.39%) 1.56%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8594840 8563482 -31358 (-0.36%) 0.85%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10732791 10697979 -34812 (-0.32%) 1.12%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1614034 1618380 4346 (0.27%) 1.07%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1616969 1612641 -4328 (-0.27%) 1.07%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10712695 10739099 26404 (0.25%) 0.80%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8590589 8575596 -14993 (-0.17%) 0.74%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3627749 3623545 -4204 (-0.12%) 0.46%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3624999 3629185 4186 (0.12%) 0.47%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3085162 3084616 -546 (-0.02%) 0.21%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1181682 1181756 74 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2076637 2076551 -86 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925924 1925855 -69 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717494 1717472 -22 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2079680 2079658 -22 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3086764 3086793 29 (0.00%) 0.25%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28193824 28194020 196 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28220972 28220781 -191 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30371390 30371229 -161 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27853908 27853762 -146 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27860666 27860526 -140 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30371476 30371611 135 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28966552 28966673 121 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28217768 28217656 -112 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30368213 30368096 -117 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28887403 28887495 92 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27793467 27793386 -81 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28190138 28190220 82 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27856309 27856237 -72 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28963946 28963879 -67 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30411716 30411652 -64 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28966698 28966649 -49 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27795934 27795895 -39 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7569238 7569248 10 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27800263 27800231 -32 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28884882 28884852 -30 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28187107 28187080 -27 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7567067 7567074 7 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35183067 35183099 32 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30414957 30414983 26 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28224587 28224563 -24 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28887632 28887611 -21 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35184987 35185012 25 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46389586 46389597 11 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30414672 30414666 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46470682 46470691 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46480097 46480088 -9 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46467127 46467119 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58236459 58236449 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661852 80661842 -10 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68683803 68683811 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92718860 92718850 -10 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92684663 92684672 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58251815 58251820 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58256129 58256134 5 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92682830 92682837 7 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92712615 92712622 7 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58348749 58348746 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80540446 80540450 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641260 80641256 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80648880 80648876 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92714859 92714855 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58254059 58254057 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92673765 92673768 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46434716 46434715 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46467812 46467813 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58341600 58341601 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80535647 80535648 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80554934 80554935 1 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4216429 4216429 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4230850 4230850 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2662050 2662050 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 40590050 40590050 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 40292413 40292413 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11425365 11425365 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5015924 5015924 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4695390 4695390 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 40515800 40515800 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563566 2563566 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 42064238 42064238 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 41484591 41484591 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 40511800 40511800 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1179494 1179494 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58352502 58352502 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 41602899 41602899 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3871863 3871863 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 40198033 40198033 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4237209 4237209 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 41600228 41600228 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11431345 11431345 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 41962808 41962808 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 40285413 40285413 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 40508525 40508525 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 41602821 41602821 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46487102 46487102 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 42064018 42064018 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 40586050 40586050 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 41965708 41965708 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 40193982 40193982 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 41481998 41481998 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 41484669 41484669 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 41965928 41965928 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3873865 3873865 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4498203 4498203 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932569 1932569 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 42061118 42061118 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 40288362 40288362 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11292388 11292388 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46460135 46460135 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 40191025 40191025 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 40582783 40582783 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2656185 2656185 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.29 ms 4.27 ms -0.02 ms (-0.42%) 2.21%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.98 ms 4.96 ms -0.02 ms (-0.40%) 2.06%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.64 ms 1.64 ms 0.01 ms (0.33%) 2.02%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.44 ms 6.42 ms -0.02 ms (-0.31%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.00 ms 4.98 ms -0.02 ms (-0.30%) 1.72%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.36 ms 6.34 ms -0.02 ms (-0.30%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.03 ms 5.02 ms -0.01 ms (-0.29%) 1.42%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.17 ms 5.15 ms -0.01 ms (-0.27%) 1.63%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.56 ms 4.55 ms -0.01 ms (-0.27%) 3.87%
handshake_session_id_ring_1.3_ecdsap256_aes 6.41 ms 6.39 ms -0.02 ms (-0.26%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.31 ms 4.30 ms -0.01 ms (-0.24%) 1.83%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 461.29 µs 460.19 µs -1.10 µs (-0.24%) 2.76%
handshake_tickets_ring_1.3_ecdsap256_aes 6.48 ms 6.46 ms -0.02 ms (-0.24%) 1.09%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.62 ms 0.00 ms (0.21%) 1.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.19 ms 5.18 ms -0.01 ms (-0.21%) 1.49%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.80 ms 1.80 ms 0.00 ms (0.21%) 2.58%
handshake_session_id_ring_1.3_rsa_chacha 6.85 ms 6.83 ms -0.01 ms (-0.20%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.97 ms 6.95 ms -0.01 ms (-0.20%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.90 ms 6.89 ms -0.01 ms (-0.20%) 1.00%
transfer_no_resume_ring_1.3_rsa_aes 6.91 ms 6.90 ms -0.01 ms (-0.20%) 3.40%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.47 ms 4.46 ms -0.01 ms (-0.19%) 1.98%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 462.79 µs 461.94 µs -0.85 µs (-0.18%) 2.93%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.51 ms 9.50 ms -0.02 ms (-0.18%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 4.99 ms 4.98 ms -0.01 ms (-0.17%) 1.60%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.49 ms 4.48 ms -0.01 ms (-0.17%) 1.41%
handshake_no_resume_ring_1.3_ecdsap256_aes 508.27 µs 507.39 µs -0.88 µs (-0.17%) 2.12%
handshake_tickets_ring_1.3_ecdsap384_aes 9.55 ms 9.54 ms -0.02 ms (-0.16%) 1.00%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.56 ms 9.54 ms -0.02 ms (-0.16%) 1.98%
handshake_tickets_ring_1.3_rsa_chacha 6.92 ms 6.91 ms -0.01 ms (-0.15%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.44 ms 9.43 ms -0.01 ms (-0.14%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.04 ms 13.02 ms -0.02 ms (-0.14%) 1.58%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.09 ms 1.09 ms 0.00 ms (0.14%) 1.54%
handshake_session_id_ring_1.3_ecdsap384_aes 9.48 ms 9.47 ms -0.01 ms (-0.13%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.72 ms 13.71 ms -0.02 ms (-0.13%) 1.67%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.42 ms 6.41 ms -0.01 ms (-0.13%) 2.97%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.21 ms 5.20 ms -0.01 ms (-0.12%) 1.07%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.12 ms 1.12 ms 0.00 ms (0.11%) 1.68%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.76 ms 13.75 ms -0.02 ms (-0.11%) 1.46%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.25 ms 5.26 ms 0.00 ms (0.09%) 3.77%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.06 ms 13.05 ms -0.01 ms (-0.09%) 1.34%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms -0.00 ms (-0.08%) 1.00%
transfer_no_resume_ring_1.2_rsa_aes 6.87 ms 6.86 ms -0.01 ms (-0.08%) 2.36%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.29 ms 5.28 ms -0.00 ms (-0.08%) 3.63%
transfer_no_resume_ring_1.3_rsa_chacha 13.56 ms 13.55 ms -0.01 ms (-0.07%) 1.37%
handshake_session_id_ring_1.2_rsa_aes 1.53 ms 1.53 ms 0.00 ms (0.06%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_chacha 504.73 µs 504.45 µs -0.28 µs (-0.06%) 2.55%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.16 ms 16.15 ms -0.01 ms (-0.05%) 1.23%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.16 ms 5.16 ms -0.00 ms (-0.04%) 1.43%
handshake_no_resume_ring_1.3_rsa_chacha 998.82 µs 998.51 µs -0.31 µs (-0.03%) 1.14%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.12 ms 1.12 ms 0.00 ms (0.03%) 4.09%
handshake_no_resume_ring_1.3_rsa_aes 1.00 ms 1.00 ms -0.00 ms (-0.03%) 1.02%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.22 ms 5.22 ms 0.00 ms (0.02%) 4.12%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.60 ms 3.60 ms -0.00 ms (-0.02%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.18 ms 0.00 ms (0.02%) 1.15%
handshake_no_resume_ring_1.2_rsa_aes 995.43 µs 995.58 µs 0.15 µs (0.02%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.60 ms 3.60 ms 0.00 ms (0.00%) 1.00%

Additional information

Historical results

Checkout details:

@djc djc added this pull request to the merge queue Nov 18, 2024
Merged via the queue into main with commit 9103dc2 Nov 18, 2024
58 checks passed
@djc djc deleted the hickory-a3 branch November 18, 2024 11:35
@cpu
Copy link
Member
cpu commented Nov 18, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @cpu @ctz
0