8000 Prepare 0.23.18 by ctz · Pull Request #2234 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Prepare 0.23.18 #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2024
Merged

Prepare 0.23.18 #2234

merged 1 commit into from
Nov 22, 2024

Conversation

ctz
Copy link
Member
@ctz ctz commented Nov 22, 2024

Release notes:

  • Availability issue: correct a panic in the Acceptor API when a client hello is fragmented over several TLS messages. This was introduced in 0.23.13. It does not affect earlier versions. Thank you to @kvinwang for the report and fix.
  • Avoid sending TLS1.2 session ticket extension for TLS1.3-only handshakes. Thank you to @link2xt for the report and fix.
  • Improve TLS1.2 receive performance when using aws-lc-rs.
  • Move crate minimum supported Rust version to 1.71.

@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Nov 22, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8609550 8586509 -23041 (-0.27%) 0.78%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10463636 10437809 -25827 (-0.25%) 1.75%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10713064 10688363 -24701 (-0.23%) 0.95%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10690359 10681786 -8573 (-0.08%) 0.84%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8585738 8589008 3270 (0.04%) 1.06%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3082033 3082649 616 (0.02%) 0.26%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2076906 2076714 -192 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1176685 1176589 -96 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1174395 1174481 86 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3080302 3080095 -207 (-0.01%) 0.23%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3622987 3623196 209 (0.01%) 0.31%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3622477 3622417 -60 (-0.00%) 0.48%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1613352 1613375 23 (0.00%) 1.07%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717624 1717602 -22 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58251176 58250540 -636 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925726 1925741 15 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28967718 28967514 -204 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28889069 28889266 197 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28967699 28967520 -179 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30427353 30427165 -188 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28225998 28225826 -172 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27865727 27865572 -155 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28192801 28192683 -118 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27801678 27801564 -114 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28964768 28964879 111 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27806039 27806141 102 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932468 1932461 -7 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28222622 28222720 98 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2073771 2073764 -7 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30427554 30427647 93 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28199707 28199781 74 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28229751 28229681 -70 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28889099 28889164 65 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30381456 30381398 -58 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30424249 30424192 -57 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1611985 1611988 3 (0.00%) 1.08%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27861204 27861245 41 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28886485 28886444 -41 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27799158 27799119 -39 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30384893 30384929 36 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7566478 7566470 -8 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30384446 30384421 -25 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35182605 35182582 -23 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35180652 35180665 13 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7564316 7564314 -2 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27858712 27858705 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46456935 46456943 8 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46464567 46464559 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46467804 46467812 8 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46389595 46389589 -6 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92720780 92720770 -10 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58341605 58341611 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58191639 58191644 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80648878 80648884 6 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28195846 28195848 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58255493 58255497 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46477528 46477531 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92714540 92714544 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92716777 92716773 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661853 80661850 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58253414 58253412 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641256 80641254 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58235168 58235169 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80535649 80535650 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80540452 80540451 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80554933 80554934 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92673768 92673769 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92684670 92684671 1 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11292386 11292386 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46470692 46470692 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 40515976 40515976 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 40590226 40590226 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3872695 3872695 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 40198148 40198148 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 40296573 40296573 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4236939 4236939 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 40594220 40594220 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 41482178 41482178 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4497603 4497603 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 41965918 41965918 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 40202193 40202193 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4230790 4230790 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92682837 92682837 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11424773 11424773 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 41603799 41603799 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4695330 4695330 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 41484771 41484771 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 41966108 41966108 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58348746 58348746 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 40289595 40289595 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11430729 11430729 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 42064948 42064948 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 41603721 41603721 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 40292528 40292528 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2655903 2655903 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 40586975 40586975 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3870183 3870183 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 41963018 41963018 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 41601128 41601128 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563580 2563580 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4214929 4214929 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46487101 46487101 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5020364 5020364 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 40519970 40519970 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 41484849 41484849 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58352502 58352502 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46423829 46423829 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 40512717 40512717 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 40195207 40195207 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 42062048 42062048 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 42065138 42065138 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2661768 2661768 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.61 ms 1.60 ms -0.02 ms (-1.05%) 1.62%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.77 ms 1.76 ms -0.01 ms (-0.83%) 2.23%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.08 ms 5.04 ms -0.04 ms (-0.77%) 4.34%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.50 ms 4.47 ms -0.03 ms (-0.61%) 4.01%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.22 ms 5.19 ms -0.03 ms (-0.60%) 3.63%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.14 ms 5.11 ms -0.03 ms (-0.59%) 3.89%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 460.79 µs 458.13 µs -2.65 µs (-0.58%) 3.05%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.36 ms 6.33 ms -0.04 ms (-0.55%) 2.80%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.60 ms -0.01 ms (-0.51%) 1.77%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.48 ms 4.46 ms -0.02 ms (-0.47%) 1.48%
transfer_no_resume_ring_1.3_rsa_aes 6.86 ms 6.83 ms -0.03 ms (-0.46%) 2.97%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.28 ms 4.26 ms -0.02 ms (-0.46%) 1.53%
transfer_no_resume_ring_1.2_rsa_aes 6.78 ms 6.75 ms -0.03 ms (-0.44%) 2.67%
handshake_no_resume_ring_1.3_ecdsap256_chacha 504.69 µs 502.55 µs -2.14 µs (-0.42%) 2.39%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.30 ms 4.28 ms -0.02 ms (-0.39%) 1.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 458.49 µs 456.80 µs -1.69 µs (-0.37%) 2.66%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.01 ms 5.00 ms -0.02 ms (-0.35%) 1.23%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.52 ms 9.49 ms -0.03 ms (-0.32%) 1.63%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms -0.00 ms (-0.31%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.50 ms 4.48 ms -0.01 ms (-0.29%) 1.23%
transfer_no_resume_ring_1.3_rsa_chacha 13.50 ms 13.47 ms -0.03 ms (-0.25%) 1.37%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.17 ms 16.13 ms -0.04 ms (-0.25%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.97 ms 12.93 ms -0.03 ms (-0.25%) 1.46%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.00 ms 12.97 ms -0.03 ms (-0.25%) 1.27%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.19 ms 5.18 ms -0.01 ms (-0.22%) 1.13%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.69 ms 13.66 ms -0.03 ms (-0.22%) 1.52%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.98 ms 4.97 ms -0.01 ms (-0.21%) 1.23%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.13 ms 5.12 ms -0.01 ms (-0.18%) 1.48%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.40 ms 6.38 ms -0.01 ms (-0.18%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_aes 507.74 µs 506.87 µs -0.88 µs (-0.17%) 2.33%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.14 ms 5.14 ms -0.01 ms (-0.17%) 1.03%
handshake_no_resume_ring_1.2_rsa_aes 995.79 µs 994.26 µs -1.53 µs (-0.15%) 1.15%
handshake_session_id_ring_1.3_ecdsap256_aes 6.44 ms 6.43 ms -0.01 ms (-0.15%) 1.05%
handshake_tickets_ring_1.3_ecdsap256_aes 6.52 ms 6.51 ms -0.01 ms (-0.14%) 1.13%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.21 ms 5.20 ms -0.01 ms (-0.14%) 1.17%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.47 ms 6.46 ms -0.01 ms (-0.12%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.06 ms -0.00 ms (-0.11%) 2.34%
handshake_no_resume_ring_1.3_rsa_aes 999.37 µs 998.33 µs -1.04 µs (-0.10%) 1.03%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.61 ms 13.60 ms -0.01 ms (-0.08%) 1.73%
handshake_no_resume_ring_1.3_rsa_chacha 999.45 µs 998.65 µs -0.80 µs (-0.08%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.95 ms 6.96 ms 0.01 ms (0.07%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.09 ms 1.09 ms -0.00 ms (-0.07%) 2.75%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.11 ms 1.11 ms 0.00 ms (0.07%) 2.40%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.17 ms 1.17 ms -0.00 ms (-0.06%) 1.27%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.66 ms 3.66 ms -0.00 ms (-0.05%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 4.95 ms 4.94 ms -0.00 ms (-0.04%) 1.33%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.54 ms 9.54 ms 0.00 ms (0.03%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.92 ms 4.92 ms 0.00 ms (0.03%) 1.63%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.17 ms -0.00 ms (-0.02%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.59 ms 9.58 ms -0.00 ms (-0.02%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.66 ms 9.66 ms -0.00 ms (-0.02%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.61 ms 9.61 ms -0.00 ms (-0.02%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 7.01 ms 7.01 ms -0.00 ms (-0.02%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.88 ms 6.89 ms 0.00 ms (0.01%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.66 ms 3.66 ms 0.00 ms (0.01%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.94 ms 6.94 ms -0.00 ms (-0.00%) 1.00%

Additional information

Historical results

Checkout details:

@ctz ctz added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 33af2c3 Nov 22, 2024
58 checks passed
@ctz ctz deleted the jbp-prepare-0.23.18 branch November 22, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu
0