8000 Assorted clippy fixes by ctz · Pull Request #2245 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Assorted clippy fixes #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 27, 2024
Merged

Assorted clippy fixes #2245

merged 2 commits into from
Nov 27, 2024

Conversation

ctz
Copy link
Member
@ctz ctz commented Nov 27, 2024

No description provided.

@ctz ctz force-pushed the jbp-clippy-fixes branch from ea564c0 to e863455 Compare November 27, 2024 13:11
ctz added 2 commits November 27, 2024 13:13
@ctz
key_log_file_env: simplify serialized impl
a951553 
This eliminates:

```
warning: creating a mutable reference to mutable static is discouraged
  --> rustls/tests/runners/key_log_file_env.rs:43:26
   |
43 |     let mutex = unsafe { MUTEX.as_mut() };
   |                          ^^^^^^^^^^^^^^ mutable reference to mutable static
   |
```

Which will become a hard error in edition 2024.
@ctz
ci-bench: elide some lifetimes
ad260f3 
fixes some `clippy::needless_lifetimes`
@ctz ctz force-pushed the jbp-clippy-fixes branch from e863455 to ad260f3 Compare November 27, 2024 13:13
@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Nov 27, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10771199 10694970 -76229 (-0.71%) 0.94%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8616704 8590829 -25875 (-0.30%) 1.06%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10730932 10709566 -21366 (-0.20%) 0.98%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8574783 8584473 9690 (0.11%) 1.05%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10425413 10433677 8264 (0.08%) 1.57%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3623215 3620985 -2230 (-0.06%) 0.29%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3080241 3078428 -1813 (-0.06%) 0.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3083533 3081726 -1807 (-0.06%) 0.25%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3622616 3624480 1864 (0.05%) 0.46%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1176775 1176589 -186 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28229848 28229459 -389 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717624 1717602 -22 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28196081 28195774 -307 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2073786 2073764 -22 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2076714 2076732 18 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30427973 30427712 -261 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1613362 1613375 13 (0.00%) 1.07%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30381467 30381704 237 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28967664 28967459 -205 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27861044 27861233 189 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1174395 1174402 7 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28889144 28889309 165 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28886478 28886343 -135 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28967657 28967534 -123 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925726 1925719 -7 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28964950 28964850 -100 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30427344 30427244 -100 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30384858 30384759 -99 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28225849 28225758 -91 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30424301 30424227 -74 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27806126 27806184 58 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27799182 27799239 57 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27858758 27858813 55 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28222713 28222759 46 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28889155 28889195 40 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7566460 7566470 10 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1611985 1611983 -2 (-0.00%) 1.08%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30384461 30384429 -32 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27801751 27801722 -29 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28199703 28199677 -26 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35182557 35182582 25 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27865596 27865583 -13 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35180665 35180652 -13 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7564314 7564316 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58352513 58352502 -11 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46389588 46389596 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46470683 46470691 8 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58348747 58348757 10 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80554936 80554928 -8 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80540445 80540451 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58251181 58251177 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92673763 92673769 6 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92682831 92682837 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46464560 46464557 -3 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46467809 46467812 3 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641254 80641258 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661842 80661846 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92716773 92716777 4 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46456934 46456936 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58253414 58253416 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58341609 58341611 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92720771 92720774 3 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80535648 80535650 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92684673 92684671 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92714543 92714545 2 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58235169 58235168 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58255492 58255491 -1 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563580 2563580 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46487101 46487101 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46477528 46477528 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3872695 3872695 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46423828 46423828 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 41603721 41603721 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 41484849 41484849 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5020364 5020364 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4214929 4214929 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932461 1932461 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2661768 2661768 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80648883 80648883 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11424773 11424773 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4236939 4236939 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 41601128 41601128 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 40289595 40289595 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 42062048 42062048 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 41963018 41963018 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 41603799 41603799 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4695330 4695330 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 40296573 40296573 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 41965918 41965918 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 40292528 40292528 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 40202193 40202193 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58191641 58191641 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11292386 11292386 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4497603 4497603 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 41966108 41966108 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2655903 2655903 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3870183 3870183 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 40512717 40512717 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 40594220 40594220 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 40515976 40515976 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 40195207 40195207 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 40586975 40586975 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 40590226 40590226 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 42065138 42065138 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 41484771 41484771 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 40198148 40198148 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 42064948 42064948 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11430729 11430729 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28192987 28192987 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 40519970 40519970 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4230790 4230790 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 41482178 41482178 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.55 ms 4.43 ms -0.13 ms (-2.84%) 3.87%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.28 ms 5.15 ms -0.12 ms (-2.36%) 3.61%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.20 ms 5.08 ms -0.12 ms (-2.23%) 3.66%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.13 ms 5.02 ms -0.11 ms (-2.17%) 4.32%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 464.56 µs 455.71 µs -8.85 µs (-1.91%) 3.02%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 461.72 µs 454.05 µs -7.67 µs (-1.66%) 2.50%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.40 ms 6.30 ms -0.10 ms (-1.59%) 2.87%
transfer_no_resume_ring_1.3_rsa_aes 6.89 ms 6.80 ms -0.10 ms (-1.41%) 2.96%
handshake_no_resume_ring_1.3_ecdsap256_chacha 507.33 µs 500.21 µs -7.12 µs (-1.40%) 2.39%
handshake_no_resume_ring_1.3_ecdsap256_aes 511.04 µs 504.01 µs -7.03 µs (-1.38%) 2.20%
transfer_no_resume_ring_1.2_rsa_aes 6.81 ms 6.72 ms -0.09 ms (-1.33%) 2.67%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.56 ms 9.45 ms -0.10 ms (-1.09%) 1.95%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.07 ms 1.06 ms -0.01 ms (-1.02%) 1.72%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.77 ms 1.76 ms -0.02 ms (-0.92%) 1.70%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.01 ms 12.90 ms -0.11 ms (-0.88%) 1.45%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.04 ms 12.93 ms -0.10 ms (-0.80%) 1.27%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.66 ms 13.55 ms -0.11 ms (-0.79%) 1.58%
handshake_no_resume_ring_1.2_rsa_aes 999.95 µs 992.24 µs -7.71 µs (-0.77%) 1.18%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.73 ms 13.63 ms -0.10 ms (-0.76%) 1.46%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.15 ms 5.11 ms -0.04 ms (-0.74%) 1.40%
transfer_no_resume_ring_1.3_rsa_chacha 13.53 ms 13.44 ms -0.10 ms (-0.71%) 1.35%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 4.96 ms 4.93 ms -0.04 ms (-0.71%) 1.36%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.17 ms -0.01 ms (-0.70%) 1.27%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.31 ms 4.28 ms -0.03 ms (-0.67%) 1.27%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.50 ms 4.47 ms -0.03 ms (-0.67%) 1.23%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.94 ms 4.91 ms -0.03 ms (-0.65%) 1.09%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.19 ms 16.09 ms -0.10 ms (-0.64%) 1.01%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.02 ms 4.99 ms -0.03 ms (-0.63%) 1.34%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.16 ms 5.13 ms -0.03 ms (-0.61%) 1.19%
handshake_no_resume_ring_1.3_rsa_aes 1.00 ms 1.00 ms -0.01 ms (-0.61%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.48 ms 4.46 ms -0.03 ms (-0.56%) 1.48%
handshake_no_resume_ring_1.3_rsa_chacha 1.00 ms 1.00 ms -0.01 ms (-0.56%) 1.06%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.17 ms -0.01 ms (-0.53%) 1.23%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.20 ms 5.17 ms -0.03 ms (-0.51%) 1.13%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.61 ms 1.60 ms -0.01 ms (-0.51%) 1.72%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.22 ms 5.19 ms -0.03 ms (-0.51%) 1.21%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 4.99 ms 4.97 ms -0.03 ms (-0.51%) 1.25%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.10 ms 1.09 ms -0.01 ms (-0.47%) 2.44%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.11 ms 1.10 ms -0.00 ms (-0.43%) 3.50%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms -0.01 ms (-0.41%) 1.03%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.28 ms 4.27 ms -0.02 ms (-0.39%) 1.03%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.60 ms -0.01 ms (-0.39%) 1.43%
handshake_tickets_ring_1.3_rsa_aes 7.03 ms 7.01 ms -0.02 ms (-0.27%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.97 ms 6.96 ms -0.02 ms (-0.26%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.66 ms 3.65 ms -0.01 ms (-0.26%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.96 ms 6.94 ms -0.02 ms (-0.25%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.66 ms 3.66 ms -0.01 ms (-0.25%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.61 ms 9.58 ms -0.02 ms (-0.23%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.90 ms 6.89 ms -0.02 ms (-0.22%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.67 ms 9.65 ms -0.02 ms (-0.22%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.56 ms 9.54 ms -0.02 ms (-0.20%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 6.53 ms 6.52 ms -0.01 ms (-0.16%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.46 ms 6.45 ms -0.01 ms (-0.16%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.62 ms 9.61 ms -0.01 ms (-0.12%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.40 ms 6.39 ms -0.01 ms (-0.12%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.47 ms 6.47 ms -0.01 ms (-0.08%) 1.00%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link
codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.65%. Comparing base (7623bba) to head (ad260f3).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2245   +/-   ##
=======================================
  Coverage   94.65%   94.65%           
=======================================
  Files         102      102           
  Lines       23917    23917           
=======================================
  Hits        22638    22638           
  Misses       1279     1279

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cpu
cpu approved these changes Nov 27, 2024
8000
View reviewed changes
@ctz ctz added this pull request to the merge queue Nov 27, 2024
Merged via the queue into main with commit 6bc1dc9 Nov 27, 2024
60 checks passed
@ctz ctz deleted the jbp-clippy-fixes branch November 27, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu
0