8000 openssl-tests: fix `clippy::zombie_processes` warnings by ctz · Pull Request #2248 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

openssl-tests: fix clippy::zombie_processes warnings #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

ctz
Copy link
Member
@ctz ctz commented Nov 28, 2024

No description provided.

Copy link
codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.65%. Comparing base (20023ee) to head (10d5d67).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2248   +/-   ##
=======================================
  Coverage   94.65%   94.65%           
=======================================
  Files         102      102           
  Lines       23917    23917           
=======================================
  Hits        22638    22638           
  Misses       1279     1279           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctz ctz enabled auto-merge November 28, 2024 19:04
Copy link
rustls-benchmarking bot commented Nov 28, 2024

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10698259 10737212 38953 (0.36%) 0.98%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8588812 8566520 -22292 (-0.26%) 1.02%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10707234 10695257 -11977 (-0.11%) 0.94%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3078380 3080251 1871 (0.06%) 0.26%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10446902 10442025 -4877 (-0.05%) 1.65%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1176589 1176692 103 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3624717 3624603 -114 (-0.00%) 0.46%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8603951 8604189 238 (0.00%) 1.13%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3080370 3080314 -56 (-0.00%) 0.25%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3623200 3623162 -38 (-0.00%) 0.29%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30424060 30424362 302 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932468 1932483 15 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2073679 2073694 15 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28225875 28225672 -203 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27799002 27799186 184 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28195979 28195803 -176 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1174402 1174395 -7 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30381393 30381555 162 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30384724 30384874 150 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717602 1717609 7 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27801868 27801788 -80 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27858687 27858766 79 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27861235 27861162 -73 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27805980 27806046 66 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30427521 30427588 67 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28229815 28229757 -58 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28199654 28199601 -53 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30427242 30427296 54 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27865598 27865552 -46 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28886320 28886359 39 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30384545 30384512 -33 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28889052 28889081 29 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28192815 28192840 25 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28967423 28967444 21 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28222801 28222788 -13 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35180637 35180652 15 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7564313 7564316 3 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28967592 28967600 8 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46389596 46389585 -11 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46456933 46456943 10 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28889147 28889141 -6 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58352502 58352513 11 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28964733 28964729 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58341602 58341608 6 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80540446 80540452 6 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80648877 80648882 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661852 80661857 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92720780 92720775 -5 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92714545 92714541 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92716782 92716778 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46467802 46467804 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641260 80641257 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58253413 58253411 -2 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92682830 92682827 -3 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46464567 46464566 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46477527 46477528 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46487102 46487101 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58191641 58191642 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80535649 80535650 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80554934 80554933 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92673767 92673768 1 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4230790 4230790 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 40512717 40512717 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 42062048 42062048 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925719 1925719 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 40590226 40590226 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58250536 58250536 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3872695 3872695 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4214929 4214929 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92684671 92684671 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 40594220 40594220 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 41603721 41603721 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46470692 46470692 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 40289595 40289595 0 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58235169 58235169 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 40202193 40202193 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563580 2563580 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11292386 11292386 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 41966108 41966108 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1611983 1611983 0 (0.00%) 1.08%
handshake_session_id_ring_1.3_rsa_chacha_server 41482178 41482178 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 40292528 40292528 0 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2076810 2076810 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 40195207 40195207 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4236939 4236939 0 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5020364 5020364 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2661768 2661768 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 42065138 42065138 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 40296573 40296573 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 41601128 41601128 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 41484849 41484849 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 42064948 42064948 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4695330 4695330 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2655903 2655903 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1613362 1613362 0 (0.00%) 1.07%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 40198148 40198148 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 41963018 41963018 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7566470 7566470 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 40586975 40586975 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 41965918 41965918 0 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3870183 3870183 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46423828 46423828 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 40519970 40519970 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58348746 58348746 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 40515976 40515976 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 41603799 41603799 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35182582 35182582 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11424773 11424773 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11430729 11430729 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 41484771 41484771 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58255491 58255491 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4497603 4497603 0 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.50 ms 4.47 ms -0.03 ms (-0.57%) 1.66%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.00 ms 4.97 ms -0.03 ms (-0.54%) 1.39%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.29 ms 4.27 ms -0.02 ms (-0.54%) 1.48%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.31 ms 4.28 ms -0.02 ms (-0.53%) 1.25%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.21 ms 5.18 ms -0.03 ms (-0.52%) 1.29%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.94 ms 4.92 ms -0.02 ms (-0.50%) 1.43%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.15 ms 5.13 ms -0.02 ms (-0.46%) 1.46%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.02 ms 5.00 ms -0.02 ms (-0.42%) 1.30%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.51 ms 4.49 ms -0.02 ms (-0.41%) 1.56%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.22 ms 5.24 ms 0.02 ms (0.40%) 3.35%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 4.97 ms 4.95 ms -0.02 ms (-0.38%) 1.34%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.22 ms 5.20 ms -0.02 ms (-0.38%) 1.21%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.36 ms 6.38 ms 0.02 ms (0.36%) 2.73%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.50 ms 4.51 ms 0.01 ms (0.32%) 3.83%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.16 ms 5.14 ms -0.01 ms (-0.29%) 1.16%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.77 ms 1.76 ms -0.01 ms (-0.29%) 1.68%
transfer_no_resume_ring_1.3_rsa_aes 6.86 ms 6.88 ms 0.02 ms (0.28%) 2.84%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.52 ms 9.54 ms 0.02 ms (0.26%) 1.94%
transfer_no_resume_ring_1.2_rsa_aes 6.78 ms 6.79 ms 0.02 ms (0.23%) 2.66%
handshake_no_resume_ring_1.3_ecdsap256_aes 509.11 µs 508.02 µs -1.09 µs (-0.21%) 2.23%
handshake_no_resume_ring_1.2_rsa_aes 997.61 µs 995.58 µs -2.03 µs (-0.20%) 1.16%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.00 ms 13.03 ms 0.03 ms (0.20%) 1.27%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.16 ms 16.19 ms 0.03 ms (0.19%) 1.00%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.07 ms 5.08 ms 0.01 ms (0.18%) 4.30%
handshake_no_resume_ring_1.3_ecdsap256_chacha 504.97 µs 504.09 µs -0.88 µs (-0.17%) 2.39%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.96 ms 12.99 ms 0.02 ms (0.17%) 1.51%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.69 ms 13.71 ms 0.02 ms (0.16%) 1.43%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.62 ms 13.64 ms 0.02 ms (0.16%) 1.57%
handshake_session_id_ring_1.2_rsa_aes 1.52 ms 1.52 ms 0.00 ms (0.15%) 1.08%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.61 ms -0.00 ms (-0.15%) 1.35%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.06 ms -0.00 ms (-0.15%) 1.70%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.60 ms 1.60 ms -0.00 ms (-0.14%) 1.76%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.10 ms 1.10 ms 0.00 ms (0.12%) 2.44%
transfer_no_resume_ring_1.3_rsa_chacha 13.50 ms 13.52 ms 0.02 ms (0.12%) 1.35%
handshake_no_resume_ring_1.3_rsa_chacha 1.00 ms 1.00 ms 0.00 ms (0.09%) 1.04%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.15 ms 5.16 ms 0.00 ms (0.09%) 3.64%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 462.24 µs 461.85 µs -0.39 µs (-0.08%) 3.06%
handshake_no_resume_ring_1.3_rsa_aes 1.00 ms 1.00 ms 0.00 ms (0.07%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.90 ms 6.89 ms -0.00 ms (-0.07%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.54 ms 9.54 ms -0.00 ms (-0.05%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 458.98 µs 458.76 µs -0.21 µs (-0.05%) 2.51%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.66 ms 3.66 ms 0.00 ms (0.05%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.66 ms 9.66 ms -0.00 ms (-0.04%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.97 ms 6.97 ms -0.00 ms (-0.04%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.62 ms 9.61 ms -0.00 ms (-0.03%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms -0.00 ms (-0.03%) 1.23%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.48 ms 6.47 ms -0.00 ms (-0.02%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.40 ms 6.40 ms -0.00 ms (-0.02%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 7.02 ms 7.02 ms 0.00 ms (0.02%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 6.52 ms 6.52 ms 0.00 ms (0.01%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.59 ms 9.59 ms -0.00 ms (-0.01%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.45 ms 6.45 ms -0.00 ms (-0.01%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.18 ms 0.00 ms (0.01%) 1.29%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.11 ms 1.11 ms 0.00 ms (0.00%) 3.49%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.66 ms 3.66 ms -0.00 ms (-0.00%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 6.95 ms 6.95 ms 0.00 ms (0.00%) 1.00%

Additional information

Historical results

Checkout details:

@ctz ctz added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit 9864dae Nov 28, 2024
60 checks passed
@ctz ctz deleted the jbp-clippy-lints-1.83 branch November 28, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0