examples: use inner hostname in ech-client HTTPS DNS query #2268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to look up the _inner_ hostname's HTTPS SRV record to get an ECH config to use, not the outer hostname. Importantly the inner hostname isn't leaked by this process because we're using DNS-over-HTTPS.
* Use an alternative defo.ie config that we know only works with the correct inner hostname DNS lookup. Also switch to the JSON output format since it's friendly to grep :) * Switch cloudflare config to use 'cloudflare-ech.com' for the outer hostname. This is the public name in the ECH config for 'research.cloudflare.com'.
115de1c to
f955b8b
Compare
ctz
approved these changes
Dec 10, 2024
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2268 +/- ##
=======================================
Coverage 94.59% 94.59%
=======================================
Files 104 104
Lines 24031 24031
=======================================
Hits 22731 22731
Misses 1300 1300 ☔ View full report in Codecov by Sentry. |
djc
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
ech-client.rsexample we want to look up the inner hostname's HTTPS SRV record to get an ECH config to use, not the outer hostname. Importantly the inner hostname isn't leaked by this process because we're using DNS-over-HTTPS. This fell unnoticed because the test servers we were using had a workable ECH config queryable with the outer hostname by happenstance.This branch fixes the example bug and adjusts the daily-tests CI config accordingly. Here's an example passing run from a manual dispatch.
Thanks to @sftcd for noticing :-)