8000 Take aws-lc-rs 1.12 by ctz · Pull Request #2286 · rustls/rustls · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Take aws-lc-rs 1.12 #2286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 19, 2024
Merged

Take aws-lc-rs 1.12 #2286

merged 3 commits into from
Dec 19, 2024

Conversation

ctz
Copy link
Member
@ctz ctz commented Dec 18, 2024

This is mostly about undoing hacks we had because rustls-post-quantum was incompatible with the rustls/fips feature.

cpu
cpu approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member
@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@rustls-benchmarking Rustls Benchmarking
Copy link
rustls-benchmarking bot commented Dec 18, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

⚠️ There are significant instruction count differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 2073892 2160057 ⚠️ 86165 (4.15%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 2077038 2163085 ⚠️ 86047 (4.14%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8595787 8266056 ✅ -329731 (-3.84%) 1.03%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8599085 8278659 ✅ -320426 (-3.73%) 1.04%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 10728534 10694743 -33791 (-0.31%) 0.99%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 10422399 10443711 21312 (0.20%) 1.24%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 10710217 10719624 9407 (0.09%) 0.99%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3622508 3624783 2275 (0.06%) 0.24%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3080273 3082041 1768 (0.06%) 0.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3079586 3080559 973 (0.03%) 0.24%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 1717543 1717782 239 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 1925601 1925831 230 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 1932343 1932573 230 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3623061 3623403 342 (0.01%) 0.24%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 5019524 5019734 210 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 28180436 28181262 826 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 27779509 27780312 803 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 28173409 28174180 771 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 28891661 28892395 734 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 28891580 28892299 719 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 28203382 28204038 656 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 27838913 27839558 645 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 28206471 28207093 622 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 28176558 28177178 620 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 27782021 27782621 600 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 28969992 28970608 616 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1176810 1176834 24 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 28889440 28890020 580 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 27841514 27841998 484 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 27845980 27846462 482 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 27786542 27787021 479 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 28967889 28968384 495 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1174523 1174543 20 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3864415 3864355 -60 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3872523 3872463 -60 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 30420595 30420156 -439 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4206499 4206439 -60 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 1613619 1613596 -23 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 30423501 30423073 -428 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 30377943 30377527 -416 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 28210493 28210840 347 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 30423149 30422776 -373 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 28970166 28970515 349 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 30380712 30380401 -311 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 30380259 30380059 -200 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 7566714 7566722 8 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 40179989 40180019 30 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 40182932 40182962 30 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 40186983 40187013 30 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 40274309 40274339 30 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 40277252 40277282 30 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 40281303 40281333 30 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 40497499 40497529 30 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 40500760 40500790 30 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 40504760 40504790 30 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 40571689 40571719 30 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 40574950 40574980 30 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 40578950 40578980 30 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35182595 35182618 23 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46470681 46470692 11 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46464558 46464567 9 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58338935 58338945 10 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58342691 58342700 9 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46389596 46389589 -7 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80641264 80641256 -8 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92710957 92710966 9 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58240727 58240723 -4 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58243604 58243600 -4 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92663950 92663956 6 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80535644 80535649 5 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46456942 46456944 2 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46477529 46477527 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58245681 58245679 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80661853 80661851 -2 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92704732 92704734 2 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46467813 46467812 -1 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 58181208 58181209 1 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58225376 58225377 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58331789 58331788 -1 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80540444 80540445 1 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80554933 80554934 1 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92706959 92706960 1 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 11292436 11292436 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 7564559 7564559 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46487102 46487102 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 41972158 41972158 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 41610711 41610711 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 41969798 41969798 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46423827 46423827 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 2661785 2661785 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 42070688 42070688 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 41608658 41608658 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4229019 4229019 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 2655918 2655918 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 41492451 41492451 0 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 2563543 2563543 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92673018 92673018 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 42068138 42068138 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 41490398 41490398 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 41972348 41972348 0 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4233520 4233520 0 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 42070498 42070498 0 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92674859 92674859 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 41610759 41610759 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35180648 35180648 0 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80648884 80648884 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 11430994 11430994 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4698000 4698000 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 1612228 1612228 0 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 41492499 41492499 0 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 11425039 11425039 0 (0.00%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4489533 4489533 0 (0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.15 ms ✅ -0.03 ms (-2.14%) 1.03%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.16 ms ✅ -0.02 ms (-1.44%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.65 ms 3.60 ms ✅ -0.05 ms (-1.43%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.66 ms 3.60 ms ✅ -0.05 ms (-1.42%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_aes 9.57 ms 9.47 ms ✅ -0.10 ms (-1.09%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 9.64 ms 9.54 ms ✅ -0.11 ms (-1.09%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.52 ms 9.42 ms ✅ -0.10 ms (-1.08%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.59 ms 9.49 ms ✅ -0.10 ms (-1.06%) 1.00%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 4.50 ms 4.54 ms 0.04 ms (0.97%) 1.28%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 5.15 ms 5.20 ms 0.05 ms (0.95%) 1.28%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.09 ms 1.10 ms 0.01 ms (0.92%) 2.28%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 4.95 ms 4.99 ms 0.04 ms (0.90%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 4.31 ms 4.34 ms 0.04 ms (0.87%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.10 ms 1.11 ms 0.01 ms (0.86%) 3.32%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.08 ms 5.13 ms 0.04 ms (0.82%) 3.63%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.38 ms 6.33 ms -0.05 ms (-0.77%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.44 ms 4.47 ms 0.03 ms (0.76%) 4.60%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.02 ms 5.05 ms 0.04 ms (0.74%) 3.22%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 5.17 ms 5.21 ms 0.04 ms (0.74%) 1.04%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 1.61 ms 1.63 ms 0.01 ms (0.73%) 1.50%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.45 ms 6.40 ms -0.05 ms (-0.73%) 1.00%
handshake_tickets_ring_1.3_rsa_chacha 6.94 ms 6.89 ms -0.05 ms (-0.69%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.06 ms 1.07 ms 0.01 ms (0.68%) 2.22%
handshake_tickets_ring_1.3_ecdsap256_aes 6.50 ms 6.45 ms -0.04 ms (-0.68%) 1.00%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 4.99 ms 5.03 ms 0.03 ms (0.67%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.43 ms 6.39 ms -0.04 ms (-0.65%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 4.53 ms 4.56 ms 0.03 ms (0.64%) 1.28%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 454.63 µs 457.53 µs 2.90 µs (0.64%) 2.68%
handshake_session_id_ring_1.3_rsa_aes 6.93 ms 6.88 ms -0.04 ms (-0.63%) 1.00%
handshake_session_id_ring_1.3_rsa_chacha 6.87 ms 6.83 ms -0.04 ms (-0.62%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 6.99 ms 6.95 ms -0.04 ms (-0.58%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 456.95 µs 459.37 µs 2.42 µs (0.53%) 2.62%
transfer_no_resume_ring_1.2_rsa_aes 6.72 ms 6.75 ms 0.03 ms (0.47%) 2.35%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 4.34 ms 4.36 ms 0.02 ms (0.46%) 1.24%
handshake_session_id_ring_1.2_rsa_aes 1.53 ms 1.52 ms -0.01 ms (-0.43%) 1.06%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.30 ms 6.33 ms 0.03 ms (0.41%) 3.07%
transfer_no_resume_ring_1.3_rsa_aes 6.79 ms 6.82 ms 0.03 ms (0.41%) 2.76%
handshake_tickets_ring_1.2_rsa_aes 1.61 ms 1.61 ms -0.01 ms (-0.33%) 1.06%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.56 ms 13.60 ms 0.04 ms (0.31%) 1.32%
transfer_no_resume_ring_1.3_rsa_chacha 13.43 ms 13.47 ms 0.04 ms (0.31%) 1.40%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.01 ms 5.03 ms 0.01 ms (0.29%) 1.16%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.94 ms 12.97 ms 0.03 ms (0.27%) 1.43%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.91 ms 12.94 ms 0.03 ms (0.26%) 1.56%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.22 ms 5.23 ms 0.01 ms (0.24%) 1.19%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 1.79 ms 1.79 ms 0.00 ms (0.21%) 1.61%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.16 ms 5.17 ms 0.01 ms (0.16%) 3.63%
handshake_no_resume_ring_1.2_rsa_aes 990.03 µs 991.51 µs 1.48 µs (0.15%) 1.03%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.45 ms 9.44 ms -0.01 ms (-0.15%) 2.04%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.10 ms 16.08 ms -0.02 ms (-0.12%) 1.21%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.63 ms 13.65 ms 0.01 ms (0.10%) 1.47%
handshake_no_resume_ring_1.3_rsa_aes 994.26 µs 995.10 µs 0.84 µs (0.08%) 1.06%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.25 ms 5.26 ms 0.00 ms (0.07%) 1.16%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.06 ms 5.06 ms 0.00 ms (0.06%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_aes 503.76 µs 503.49 µs -0.27 µs (-0.05%) 2.13%
handshake_no_resume_ring_1.3_rsa_chacha 993.99 µs 994.25 µs 0.26 µs (0.03%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_chacha 499.82 µs 499.91 µs 0.09 µs (0.02%) 2.15%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link
codecov bot commented Dec 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are 8000 covered by tests ✅

Project coverage is 94.82%. Comparing base (de8e612) to head (ca64df9).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2286   +/-   ##
=======================================
  Coverage   94.82%   94.82%           
=======================================
  Files         104      104           
  Lines       24100    24100           
=======================================
  Hits        22853    22853           
  Misses       1247     1247

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctz ctz added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit e945935 Dec 19, 2024
60 checks passed
@ctz ctz deleted the jbp-aws-lc-rs-1.12 branch December 19, 2024 08:43
@photovoltex photovoltex mentioned this pull request Dec 19, 2024
Closed
@cpu cpu mentioned this pull request Dec 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctz @djc @cpu
0