CI: deny all Clippy nightly warnings - REJECTED #2311
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2311 +/- ##
=======================================
Coverage 94.82% 94.82%
=======================================
Files 104 104
Lines 24100 24100
=======================================
Hits 22853 22853
Misses 1247 1247 ☔ View full report in Codecov by Sentry. |
|
I don't think we should do this. clippy on nightly can be a little bit flakey and we only warn on those for a reason. I don't see a good reason to change that now. |
|
Closing this for now. I agree with Djc that it feels like the status quo is working well enough. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on other PR that I think should be reviewed & hopefully merged first:
My impression is that new Clippy nightly warnings have not been much of an issue over the past year and it has been pretty easy to resolve the few issues I have seen come up.
I think the ideal situation for PR #2285 is to assume that we will only ignore a single warning that it introduces for most crates, and deny all other warnings for Clippy nightly as well.
I do totally think this would require a discussion & decision among the @rustls maintainers for consideration, will totally understand if this proposal need to be rejected & closed.